Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp870879pxb; Tue, 1 Feb 2022 12:08:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJynXpNm3ZegIIw3o1YjdsNl6NsGONUdt3oAGdEnIz5WXEV2t/+dprts2jwUf8Z6rTZ6rSPm X-Received: by 2002:a17:90b:354f:: with SMTP id lt15mr4220613pjb.83.1643746092487; Tue, 01 Feb 2022 12:08:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643746092; cv=none; d=google.com; s=arc-20160816; b=vHojgtHbpBHHFXVTc1Y5053Gn2BCpzJdCUf5Nc3khz2b0bhHVCM9fHl8e8cYVECoPg gfduu2PaDPH0gIlP2JTuq5yXfXpCmA459A3qRIgWGvvGBOXoseQoSqqJhfVQjJGV5+W5 wfPEbYT78Mt+lGM430l1ZP5UoCnFzDeFQ3wi7HBGviZcyip0RdsZKEldR08wGdkwMz/T a0BzeSSnXy2bkuBOhZOtu92xl1BjERcf1llGO1VplM3rbh99X58WOTQs6bFh/cZp7ZLU Ak+Ao8ZelJ3u4wCvDARmDl7FFrTW5F0Y/SfhrhW1oEcXQSL11XYr49Y7Ug7QnNjK3qD4 P6uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9lUuPvX8caPRqaS4Qo1Eur2lyanH6aNpFGAEGAmgIYE=; b=Bv0iWZgIfjQpWivNQxBW4nABU8JmGwhLFaweCNFTQaZzwDWAtQq8UpHPJ0zBVLANqj UhgyxMt7Wr7+H9ZOV9tgnWurkGsNj0bucNYEGzSTdDOt5AW96y8Q831QwOTbfwAOiAgH hP1wkZtJxwANJoB5/4hBZUNkWsZJleZpUDadx1KlpFU5grl3ig85TLhv5DbPWJpEQvnv IHaaCN6ZNHQm4MmkFifkWY7vscyumt2AbRs6DvbFoSlVaFVE61mJnrMecaJ67EzkpKTG jHjpTeKEbFuG+WQRj5od/HzsZfUFsM5+Iwy8VAol5AAk5HUHRRZl1H1qNDlUUEm0R3aS OLSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=D6L+MRpP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q2si16808202pga.370.2022.02.01.12.08.00; Tue, 01 Feb 2022 12:08:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=D6L+MRpP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379276AbiAaLaG (ORCPT + 99 others); Mon, 31 Jan 2022 06:30:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378557AbiAaLUV (ORCPT ); Mon, 31 Jan 2022 06:20:21 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 614F5C0604DC; Mon, 31 Jan 2022 03:12:46 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F3D2D60ED0; Mon, 31 Jan 2022 11:12:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B95C5C340E8; Mon, 31 Jan 2022 11:12:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643627565; bh=vgJDTUSzjABtMbAOfAarotByZWoPzIx/6Lq1XFK1qBs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D6L+MRpPb1GGUyNcykMFUEUQFIHgsQ3bYMUa8m1OuB4LUlHxTjHRz1qkFtpubYBoR pKeto2kHBPWCM6AB6h01SRL+38zf5KvGkvD1nPOmaQZexCNluQJySI0IK8nisTL+e6 c/AlVHQWNTD6iECQl/7jVxYfNv5af8gwgfh3m3rA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Geetha sowjanya , Subbaraya Sundeep , Sunil Goutham , "David S. Miller" , Sasha Levin Subject: [PATCH 5.15 125/171] octeontx2-af: Increase link credit restore polling timeout Date: Mon, 31 Jan 2022 11:56:30 +0100 Message-Id: <20220131105234.255338097@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220131105229.959216821@linuxfoundation.org> References: <20220131105229.959216821@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Geetha sowjanya [ Upstream commit 1581d61b42d985cefe7b71eea67ab3bfcbf34d0f ] It's been observed that sometimes link credit restore takes a lot of time than the current timeout. This patch increases the default timeout value and return the proper error value on failure. Fixes: 1c74b89171c3 ("octeontx2-af: Wait for TX link idle for credits change") Signed-off-by: Geetha sowjanya Signed-off-by: Subbaraya Sundeep Signed-off-by: Sunil Goutham Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/marvell/octeontx2/af/mbox.h | 1 + drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/af/mbox.h b/drivers/net/ethernet/marvell/octeontx2/af/mbox.h index a8618259de943..26ad71842b3b2 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/mbox.h +++ b/drivers/net/ethernet/marvell/octeontx2/af/mbox.h @@ -700,6 +700,7 @@ enum nix_af_status { NIX_AF_ERR_BANDPROF_INVAL_REQ = -428, NIX_AF_ERR_CQ_CTX_WRITE_ERR = -429, NIX_AF_ERR_AQ_CTX_RETRY_WRITE = -430, + NIX_AF_ERR_LINK_CREDITS = -431, }; /* For NIX RX vtag action */ diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c index 9d4cc0ae61474..959266894cf15 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c @@ -3891,8 +3891,8 @@ nix_config_link_credits(struct rvu *rvu, int blkaddr, int link, NIX_AF_TL1X_SW_XOFF(schq), BIT_ULL(0)); } - rc = -EBUSY; - poll_tmo = jiffies + usecs_to_jiffies(10000); + rc = NIX_AF_ERR_LINK_CREDITS; + poll_tmo = jiffies + usecs_to_jiffies(200000); /* Wait for credits to return */ do { if (time_after(jiffies, poll_tmo)) -- 2.34.1