Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3] kselftest: Fix vdso_test_abi return status
To:     Shuah Khan <skhan@linuxfoundation.org>,
        Cristian Marussi <cristian.marussi@arm.com>
Cc:     linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        Shuah Khan <shuah@kernel.org>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
References: <20220128130701.17511-1-vincenzo.frascino@arm.com>
 <20220128144451.GC5776@e120937-lin>
 <82d59ef7-39a1-c1f7-2746-f4fc19593add@linuxfoundation.org>
 <25eb270c-fa11-f2bc-0686-b5a8c55cd0a7@linuxfoundation.org>
From:   Vincenzo Frascino <vincenzo.frascino@arm.com>
Message-ID: <f1bbd32d-470c-d5ea-f324-85189e00f5e6@arm.com>
Date:   Mon, 31 Jan 2022 11:44:01 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <25eb270c-fa11-f2bc-0686-b5a8c55cd0a7@linuxfoundation.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Shuah,

On 1/28/22 5:41 PM, Shuah Khan wrote:
> On 1/28/22 10:35 AM, Shuah Khan wrote:
>> On 1/28/22 7:44 AM, Cristian Marussi wrote:
>>> On Fri, Jan 28, 2022 at 01:07:01PM +0000, Vincenzo Frascino wrote:
>>>> vdso_test_abi contains a batch of tests that verify the validity of the
>>>> vDSO ABI.
>>>>
>>>> When a vDSO symbol is not found the relevant test is skipped reporting
>>>> KSFT_SKIP. All the tests return values are then added in a single
>>>> variable which is checked to verify failures. This approach can have
>>>> side effects which result in reporting the wrong kselftest exit status.
>>>>
>>>> Fix vdso_test_abi verifying the return code of each test separately.
>>>>
>>>> Cc: Shuah Khan <shuah@kernel.org>
>>>> Cc: Andy Lutomirski <luto@kernel.org>
>>>> Cc: Thomas Gleixner <tglx@linutronix.de>
>>>> Reported-by: Cristian Marussi <cristian.marussi@arm.com>
>>>> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
>>>> ---
>>>
>>> Hi,
>>>
>>> LGTM.
>>>
>>> Tested-by: Cristian Marussi <cristian.marussi@arm.com>
>>>
>>> Thanks,
>>> Cristian
>>
>> Thank you both. Will queue this up for 5.17 rc3.
>>
> 
> Vincenzo,
> 
> A couple of checkpatch warns. Please fix them and send me v4.
> 

It should be sorted now, I just posted v4. Please let me know if anything else
is required from my side.

Thanks!

--->8---

$ scripts/checkpatch.pl v4-0001-kselftest-Fix-vdso_test_abi-return-status.patch
total: 0 errors, 0 warnings, 252 lines checked


> thanks,
> -- Shuah

-- 
Regards,
Vincenzo