Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp876107pxb; Tue, 1 Feb 2022 12:14:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJweZqUo51QjMXtFN+3Q9/fSuu+E+gAWnN9BGjJW3pk8TuAOwFLITtsglDfgmQ/pL1R5vaZr X-Received: by 2002:a17:906:31d0:: with SMTP id f16mr22245791ejf.627.1643746448827; Tue, 01 Feb 2022 12:14:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643746448; cv=none; d=google.com; s=arc-20160816; b=ZXk+XjtqxoXX6CWGiVTut4TfDoDXRzvZwUu2vvW/HhgeYT2NVndBkbYKDTO0Ub8T// vltzeDdrV7khotwH4GcwXLMGiKop2oFvafr60dptEoNa/3mTuPz6WnccJeRrY4oWW23/ 1Oc3GppHKEPJfKxq9JDKLaJuJglMOFogr8XdOy60ne7netYSa3ybKb5NtGQ+35LYL0lS F9l0WGpw1Jyg0Yiwt03krX2PwquaR7jWsI5UAplShaOIaoBzc8UkO2/XaBJpjsj0gBHg ySVeYrTwauDKzMT5IdFRPckh87yKkldSX3nRh2FN31zFbvPIZasKrrqPx+vVdDoTmOeQ pe+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0z3B/eETZIfRue6bYfar3yLwsuY+NPXuuVNl/cKJBKA=; b=SapbAjrSyqvLUFBZ5JHLeD4BxrzVwH9J4SW4Iw1DT/CanKc2qO6sb7K7RsyrMto7PC bx8JMA+tmMTMk4SjRoSUJtSdUPtRTdieAcs1/ANXOcsHmzDud4M3rn9TXZV9/7GKkozQ FjjbNWr+oO3rSvLflWCQzqjXTTd++uQDk0NfNhea4aUN1Q7NtfUF8O5jOqqU3jfbSjcR 1SizGepy6XjbFVqHdfJxt/tgUvoIV2ZBODQvjsP56ht0HwEU7MisOfzAcYWbiNllDupO jX97m29KsD6eyuQ1ADEEOwXEerOJBTyUJkkBM45xeqgoDO+jKUMGoCl1QVtAYa0Gb/PB JusQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hGlabOyN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ga30si10164823ejc.297.2022.02.01.12.13.42; Tue, 01 Feb 2022 12:14:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hGlabOyN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377847AbiAaLrp (ORCPT + 99 others); Mon, 31 Jan 2022 06:47:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378561AbiAaLeZ (ORCPT ); Mon, 31 Jan 2022 06:34:25 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6717AC0698C2; Mon, 31 Jan 2022 03:22:50 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 26D5BB82A66; Mon, 31 Jan 2022 11:22:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42723C340E8; Mon, 31 Jan 2022 11:22:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643628167; bh=lTRCL94DPMWIznAA7wVaKBlQOmSr1xSULJkcqcdiaSc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hGlabOyNJgcn3LVLf3G0uldI7uWgMfwI75qzbB1blcMBk6scLVYs1ZuK8YvsUElNW sS2tFiN7DJVZsUxyOqY9Y362R5PC4yJml/B1n/AP7Kd69XVJHM2/sNtLBHizV7sUFV M6NrzpxDShyaX4KeU0Vmu2uiD2R9sT0Rum+f+S/4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Geetha sowjanya , Subbaraya Sundeep , Sunil Goutham , "David S. Miller" , Sasha Levin Subject: [PATCH 5.16 147/200] octeontx2-af: Increase link credit restore polling timeout Date: Mon, 31 Jan 2022 11:56:50 +0100 Message-Id: <20220131105238.505663336@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220131105233.561926043@linuxfoundation.org> References: <20220131105233.561926043@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Geetha sowjanya [ Upstream commit 1581d61b42d985cefe7b71eea67ab3bfcbf34d0f ] It's been observed that sometimes link credit restore takes a lot of time than the current timeout. This patch increases the default timeout value and return the proper error value on failure. Fixes: 1c74b89171c3 ("octeontx2-af: Wait for TX link idle for credits change") Signed-off-by: Geetha sowjanya Signed-off-by: Subbaraya Sundeep Signed-off-by: Sunil Goutham Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/marvell/octeontx2/af/mbox.h | 1 + drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/af/mbox.h b/drivers/net/ethernet/marvell/octeontx2/af/mbox.h index 4e79e918a1617..58e2aeebc14f8 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/mbox.h +++ b/drivers/net/ethernet/marvell/octeontx2/af/mbox.h @@ -732,6 +732,7 @@ enum nix_af_status { NIX_AF_ERR_BANDPROF_INVAL_REQ = -428, NIX_AF_ERR_CQ_CTX_WRITE_ERR = -429, NIX_AF_ERR_AQ_CTX_RETRY_WRITE = -430, + NIX_AF_ERR_LINK_CREDITS = -431, }; /* For NIX RX vtag action */ diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c index de6e5a1288640..97fb61915379a 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c @@ -3891,8 +3891,8 @@ nix_config_link_credits(struct rvu *rvu, int blkaddr, int link, NIX_AF_TL1X_SW_XOFF(schq), BIT_ULL(0)); } - rc = -EBUSY; - poll_tmo = jiffies + usecs_to_jiffies(10000); + rc = NIX_AF_ERR_LINK_CREDITS; + poll_tmo = jiffies + usecs_to_jiffies(200000); /* Wait for credits to return */ do { if (time_after(jiffies, poll_tmo)) -- 2.34.1