Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp878639pxb; Tue, 1 Feb 2022 12:17:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJzXWztZDDL4l93ipNIdCIjqg9TkMJd2YnK/qohG5ffPg3jMhlY5JG2VOLYNxhDuhfYFHWfi X-Received: by 2002:a05:6a00:1952:: with SMTP id s18mr26694429pfk.54.1643746662623; Tue, 01 Feb 2022 12:17:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643746662; cv=none; d=google.com; s=arc-20160816; b=QHj4P1kyLSP7nkwTIqPl29cGf2+xmcoPZtDr/ZFPeGQZx0xxQhClqhmbziDyu1T1uV Y7Pr2GMgHKWfxyvRZns+YpRzVw1tr5VMJmHj3yv1UZo7tOW7X0VQ3eNiZX1O+YK9xAtk IxQWpsZwr/GnQKWctP8cEm9futvfbRJuXkCTBdx4Lta3O1VA/YNC26Tk8Pq8w5xqswIE PV9h955oiS0lDO/Nc11M+EklOYCqr8F2y0II+6VlgNd320+IZCElvjQgMpYFqt1uSaLp f6TQUk25q1Jcth6QphT3j8ttOKtUalIkUY73DqwqLUc/keQp4jtsJm+mukv942iDwBA7 X9fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=VtJE41wLQXkc9XdllPdBNRZ/IjWKTpi4Cdgc3j0itvk=; b=TnNBFGTKCzuFmB8a2daEJLR7tB9FT4+0Hav193+bTrOSReGLdEWbwifwzTJrkLOl9/ Yfqije+GtFoTlkQnLctonhVv3dSwz+zGHfg981dQegLv8fIjQ8UBsTr4FEp0JS3IKGQq j38pjY+IjfBcoYCS2epLjwH29HCGOX2DM9Xlw5x4WW3oEoJAuiG0GO2VGFaHU0UhJelN 8WVU+zXxz7n3+Aeq9zVcZzLSPnAeYFGeTzC9h4C+PRR/1oz2aYtMRl6P2M3fffk9c0zw w46hGpe6eiQdWuMiFuDb86bJcm2y5Dcdi3L7qzYUtWOGbnT4arHLW3oi04ryfWpZj13Y UkpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=HHZCCUOW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d4si19594487plg.603.2022.02.01.12.17.28; Tue, 01 Feb 2022 12:17:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=HHZCCUOW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359758AbiAaNEO (ORCPT + 99 others); Mon, 31 Jan 2022 08:04:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234504AbiAaNEN (ORCPT ); Mon, 31 Jan 2022 08:04:13 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E457AC061714 for ; Mon, 31 Jan 2022 05:04:12 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 97E10B82ABD for ; Mon, 31 Jan 2022 13:04:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BBBADC340E8; Mon, 31 Jan 2022 13:04:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643634250; bh=TD6/WGLViFunmRccj4Esvf4Me5wXuWjEDYLePglBafw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HHZCCUOWu2G3uXD82pFLev/bcqTxB4xy4sWogDOgLqnut+wu21hlSxO2QMsCn1r6Q 1aWT5cq8Ct2rv7jKeS85epjwJM5GWn7ay/9sPggGm/DCqUKHAF3iMFT+pgH352/PhF aPz2l8hqjoPYNCsEPPDpo6K/5uJs+zHk5+4WmlTg= Date: Mon, 31 Jan 2022 14:03:09 +0100 From: Greg KH To: Abdun Nihaal Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 00/23] staging: r8188eu: remove unneeded ret variables Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 29, 2022 at 09:34:06PM +0530, Abdun Nihaal wrote: > This patchset does the following to functions in ioctl_linux.c: > - Remove unneeded return variable in some functions. > These functions cannot be converted to void either because it is an > iw_handler function or the function does return error code. > - Propagate error code in rtw_p2p_get2 function > - Convert some functions that always return 0 to return void > > v3 -> v4: > - Split the changes into smaller patches to make it easier to review > - Add a new patch to propagate error code in rtw_p2p_get2 function Much nicer and easier to review, all now queued up, thanks! greg k-h