Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 31 Jan 2022 15:23:12 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Javier Martinez Canillas <javierm@redhat.com>
Cc:     Andy Shevchenko <andy@kernel.org>, linux-fbdev@vger.kernel.org,
        Michael Hennerich <michael.hennerich@analog.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Helge Deller <deller@gmx.de>, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Phillip Potter <phil@philpotter.co.uk>,
        Carlis <zhangxuezhi1@yulong.com>,
        Lee Jones <lee.jones@linaro.org>,
        Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH v1 1/4] fbtft: Unorphan the driver
Message-ID: <YffiwCiFnqF1X1pD@smile.fi.intel.com>
References: <f671a112-880d-1526-a395-360947b40c5a@gmx.de>
 <YfEv7OQs98O9wJdJ@kroah.com>
 <YfFIpBb7lL4ukWjm@smile.fi.intel.com>
 <b8eb7111-43aa-cc8a-a1bc-f08e0f2987ed@redhat.com>
 <YfFV4EJosayH+e6C@smile.fi.intel.com>
 <YfFWPmG2D093gz4N@smile.fi.intel.com>
 <6e74d4cc-655a-e38e-0856-a59e4e6deb36@redhat.com>
 <c423a2f0-e7be-3884-3568-7629c7e9104e@redhat.com>
 <YffJujbpUGUqpIk/@smile.fi.intel.com>
 <5a3fffc8-b2d8-6ac3-809e-e8e71b66a8ea@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5a3fffc8-b2d8-6ac3-809e-e8e71b66a8ea@redhat.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Mon, Jan 31, 2022 at 01:08:32PM +0100, Javier Martinez Canillas wrote:
> On 1/31/22 12:36, Andy Shevchenko wrote:

...

> >> +config TINYDRM_SSD130X
> >> +	tristate "DRM support for Solomon SSD130X OLED displays"
> >> +	depends on DRM && OF && I2C
> > 
> > Please, make sure that it does NOT dependent on OF.
> > 
> 
> I actually added this dependency deliberative. It's true that the driver is using
> the device properties API and so there isn't anything from the properties parsing
> point of view that depends on OF. And the original driver didn't depend on OF.
> 
> But the original driver also only would had worked with Device Trees since the
> of_device_id table is the only one that contains the device specific data info.
> 
> The i2c_device_id table only listed the devices supported to match, but then it
> would only had worked with the default values that are set by the driver.
> 
> So in practice it *does* depend on OF. I'll be happy to drop that dependency if
> you provide an acpi_device_id table to match.

The code is deceptive and you become to a wrong conclusion. No, the driver
does NOT depend on OF as a matter of fact. The tricky part is the PRP0001
ACPI PNP ID that allows to reuse it on ACPI-based platforms.

That said, please drop OF dependency.

-- 
With Best Regards,
Andy Shevchenko