Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <75ab0f37-a55e-8e81-8cbf-c0de3002c3e4@amd.com>
Date:   Mon, 31 Jan 2022 10:17:37 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [PATCH -next] drm/amd/display: clean up some inconsistent
 indenting
Content-Language: en-US
To:     Yang Li <yang.lee@linux.alibaba.com>, airlied@linux.ie
Cc:     daniel@ffwll.ch, Xinhui.Pan@amd.com, christian.koenig@amd.com,
        alexander.deucher@amd.com, Rodrigo.Siqueira@amd.com,
        sunpeng.li@amd.com, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
References: <20220129010413.97801-1-yang.lee@linux.alibaba.com>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <20220129010413.97801-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFVwQzFrV1hHYnZZZTEzaEQweXRJbUJJS0pVYWFDcy9DZWZZVjQ4b2tlcStN?=
 =?utf-8?B?bFhKNzJEL3lJQXpUNHNtS0puT3dCVmlGN29SUkFLWUVJQ0JUamgza1lmemkr?=
 =?utf-8?B?eDR6TkM4NzgzL1E1OXZ5cnQ3ejJrejAxS0doWFVTbFJkT1R6SHpqUGcyYlVQ?=
 =?utf-8?B?enFpU2MrVjFrWndzcEtQdTVaZUFvY1VlazNVOFc5b2lpVldnclhkUmQrM1Fx?=
 =?utf-8?B?OE11V3hFajRQUXpLS2pkT0EyRlZYTldwWnZCVDVmUUVnZ0psWDl5UkhYT2dI?=
 =?utf-8?B?UTNjTFFtSHFtRVpLZ0p1bktLQkpENFBldnJsZk05clg0aU9sK0hkeTRHT2pK?=
 =?utf-8?B?Y2hnU2F5dzExZnAxNlh6MGptQ2lmZWNGSEE4THRod3lnYlhCQTlEUWVZNU95?=
 =?utf-8?B?UHZLTWJzUTRXRmJ4NEZkR0ZWcldVNFZYcUk2d3VSL2lUM01HTTVmcmtYbFNZ?=
 =?utf-8?B?dzdNOURiTkJiWkJ0THlGeUhhS0pXQjRYaFpSTHM3Q1VQREdRUlo3aS9FVzhB?=
 =?utf-8?B?N0NBTzUvTS9ERXRLb29pS3lMVDU0dHBDb2x2Ujk3MklHaDUrcUVMZGNURUtl?=
 =?utf-8?B?MW0weE5xWldpY2VpQTlsN3puUlBCZHVwajdHY2RCMUthZkZtWUdSeEx3K2Z2?=
 =?utf-8?B?UkJzMFFPOGlzOENWR3F3cWlMdy9lSi9ZYTNVTlpHbk4wZ1NYRTRKc1V0cGM3?=
 =?utf-8?B?ZmlqMGgyMUg5VzZ3RThCczRIT3dlQWNZUXVxeE5oUWQycnRJUnpQUjlNc3Br?=
 =?utf-8?B?R3crWUtTWGQyRE80ejMrRlpabmJFS1JscWFVZTExeEFRd3NCT3pzOFRVNzdI?=
 =?utf-8?B?Z1JhVk5Wc2Nib2lSLzNFNlQ0MTN2VXVwTWRtaGpWVGlrYjdHN3F1RlpKOTI1?=
 =?utf-8?B?c1paZVdNVkEwRC9UZUo2aEpiTTdrSkVaejY5dWd4c3V5VmxMZ2tzbFEzUXhS?=
 =?utf-8?B?cVcrMk91Q0gzY2MyTldEN0E4ZFhlalY5ZDJNMTFONlV6WCtSMjBiZWYyN1NN?=
 =?utf-8?B?YlZaZXpLRlg1a2IvbVpqNlNuUHFJZTZOMmxJSjUzbWZIZVg2ZFZmZGZZRk43?=
 =?utf-8?B?N1lsOXczZlRaUFFLZW0vMUNCUFNHMHhTbzc1TkxUdVduSU5HcWtVaXVnd1Fk?=
 =?utf-8?B?YWhoSys3YzZVWGNuUTAvM29qWDVEYUMyb01KeVJRY0x4M1hZY0gyRVpRdGFN?=
 =?utf-8?B?K3F2Z3FzWXRxTmp6dUlnWEhBeG01blNFNkNtdkdBU1FNUk56WWNVNkthMEIv?=
 =?utf-8?B?VWhzd3Q0cHBOVGhZYW9XVnF2c3JhYk54d3JSYnhyRzFRQUZFRm5zWTlKTXE2?=
 =?utf-8?B?SVQrWXNrQUNEN2ZoSkNSYzVUbjNRQTh4Uk41SUx5T1I3Z2R5RWpZV2dFemJN?=
 =?utf-8?B?b2E5OXFpcVMvN0FRN09pQ2ttd3FrSlc5MzRDTm9PUmpWMHBVZGhVWmJxNHYx?=
 =?utf-8?B?T0hpalBGZm9ZaTdObU5zQ0NZQVNNQit0SGpyKy9IMDJIVzB0ZHEzajU4dW5q?=
 =?utf-8?B?eXJsZy80QlRINko3dU5IVVFlOWtMUFRwVHNHcFZzNnpOcG9YL0RESmNrUzFN?=
 =?utf-8?B?MUNzRzFZWGtFMVZVdEgyRzJ3TGl3dElmNWxKMjRjajhNTkVsZ1ZsYTM2Nzk0?=
 =?utf-8?B?d1VSVjlSdFpEbXNvUnZoWjZZcmxYZUVFNS9xNmh5cjV6bGJOS3cxSHAxVXpC?=
 =?utf-8?B?Zms1N3NrL0VlRW1rNXM5b0VyWUJjZ0FFQSt1Y2hhclpGMUh0anZSU1RHWUhV?=
 =?utf-8?B?L0RUTDZGM1A5a3BsS1hUc0JnUUNEMWtvZjZQNzNvY2xHOWRHMkRHVDdDOVBD?=
 =?utf-8?B?T1lDMHBPTUg4QkxHWnpJcXViQ3VpWUsyZEFGNFZqeTE1YmhQOTErMnBXS3N3?=
 =?utf-8?B?cndiZ0RaMWMyeFRpVDR4eUlZa3dqVVlPSDZHemJwQ2Z1R05zc3FVYWQ2NS9W?=
 =?utf-8?B?MkpQUWx6bHM0SG5DcHgyOVlRbGRwSG9iTTdUY2k3OEZLU2l0WElMNU5iQ3hV?=
 =?utf-8?B?Ujcrck9wTjFOLy9HekRTR3NSa3NqTnVKckFhbHFyOHdxUFA1NFVaa3BoM2kz?=
 =?utf-8?B?S09wemo1Snk3Smg3ZWhUZnFMdTFRMWQxQzhRSHNRSTVBOFA4WngyajREMWRp?=
 =?utf-8?B?cHlmelRxL2YxSW9yLy9yVGhmQlpuWDFOY05NazFhVHlaemtDMzd3NDNSallp?=
 =?utf-8?Q?2wrJrBZWKSFn2vMC67RPc7I=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a9bf9056-7f9d-40ff-4984-08d9e4ccd392
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2022 15:17:42.7113
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8NYpcfaX377xLg1ggpaGHG0hePeixLPQ76GaehwcuRuKZUTJDlzYYMX4VKBQ5P7hSh1aAaEVdeQ8FlGzS+k49Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2646
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-01-28 20:04, Yang Li wrote:
> Eliminate the follow smatch warning:
> drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c:2246
> dp_perform_8b_10b_link_training() warn: inconsistent indenting
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> index daaec3164875..34ffcd5bb1d7 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> @@ -2243,11 +2243,11 @@ static enum link_training_result dp_perform_8b_10b_link_training(
>  
>  	if (status == LINK_TRAINING_SUCCESS) {
>  		status = perform_clock_recovery_sequence(link, link_res, lt_settings, DPRX);
> -	if (status == LINK_TRAINING_SUCCESS) {
> -		status = perform_channel_equalization_sequence(link,
> -					link_res,
> -					lt_settings,
> -					DPRX);
> +		if (status == LINK_TRAINING_SUCCESS) {
> +			status = perform_channel_equalization_sequence(link,
> +								       link_res,
> +								       lt_settings,
> +								       DPRX);
>  		}
>  	}
>