Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] dmaengine: ptdma: Fix the error handling path in
 pt_core_init()
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Sanjay R Mehta <sanju.mehta@amd.com>,
        Vinod Koul <vkoul@kernel.org>
Cc:     linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        dmaengine@vger.kernel.org
References: <1b2573cf3cd077494531993239f80c08e7feb39e.1643551909.git.christophe.jaillet@wanadoo.fr>
From:   Sanjay R Mehta <sanmehta@amd.com>
Message-ID: <f1081199-cb12-bac2-7fea-f4d2e4808410@amd.com>
Date:   Mon, 31 Jan 2022 20:36:37 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <1b2573cf3cd077494531993239f80c08e7feb39e.1643551909.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2FKcCtCNjRlL3JuYy9LeEdoNTIrSnhKd3VJMFFldVd6Um9Pa3ZLSDhiakRp?=
 =?utf-8?B?RndZWGJKWTJ0YjZINnU1TTdoc3U5ZFVLS0RwcHFocmRaQnNEaTVpZ0VTa05r?=
 =?utf-8?B?dVI0QmFSSk9uVGdaQjlEc0NaTWc3UVpTYll5MzkvYnJDME9QRmNmQ0E0aG55?=
 =?utf-8?B?YitWczlSWTB2cTZHcjY3Yk1QTWlrNFZjcU13Sys1WE1LaDJRNmhlajQzc2M3?=
 =?utf-8?B?Vm1WUk5qbnlHRk1GMThQZjF6ZUlKTXY3M1hZcVB2amVUS0lha1ROSFJQTis2?=
 =?utf-8?B?QVFZSlRQSW5QbENMK2pjaVQxVGk1Wlp1VzczUTNySG1MTUZPU3E2UU50MVVj?=
 =?utf-8?B?NXlUWG9kTGQvdXZBUVBDWTJMUk02UlQ0VHJyVlZJaHhkYzh6ajVWOElIU2Vl?=
 =?utf-8?B?cmVhdXZ1a0pOaUg4bERXNjhId1BOb1llRE9yUUZFRytadGt2YlJxV3Zzb2U0?=
 =?utf-8?B?T1ptUkQxOGhHOXVSd1pQejZiTk5JYmxHdURTQnUxaFRjVkh2WkgwenlYY2k3?=
 =?utf-8?B?NzI2TDc3ZG5zTmdpZnlDZ0tEdUp5S0JadFJzQlFiY2FLZFZGaVhwcElFOVV3?=
 =?utf-8?B?VVB5OVlsaHljNmpjOGFqUGo5ZVJwNnl4b3VqUWlubWxhNTFRMldObEhOcXBh?=
 =?utf-8?B?RmZUVjhVZ1RkR3NlOXliU0NweVhQS1JpU2lTeVRnUm5RR2Q2NDVuV0UrRS9J?=
 =?utf-8?B?VUZKMWhyNVc2dHVZQy9OLzV0bzNzV2hsUTIwTlFEL0tSaUZxUGI5WDJSZmhl?=
 =?utf-8?B?MlRjUUdXVy9oVUJyYzI4R1N3QXlSbk5iNmpoYjZQcWlSQXJqS2tFOTNIQXlv?=
 =?utf-8?B?SzdhK29zSmJRR0dnVGZUcW9iMHhhUWJub21vYlY5bi9Ic2RjYWlGUzdjRHhE?=
 =?utf-8?B?c1h6MTVvTmpicWlCOTZxaFBjK3MvNjVJYkU3ck9ucWR1aU9OV2Jmc0psY0U5?=
 =?utf-8?B?dlduU1NabmhLdXlCQVJXUnBDdU9CNU9uc1ZkVXk5Tkx4VkRzbGlhbllVK2Qw?=
 =?utf-8?B?UVFDaFZEcVBKS2dQWldQN2d5dG5Td3RhbElVcStPbTRFZEF6ZUI0Q29QSE1o?=
 =?utf-8?B?cTZKZXVBWHR3VU1Pb2FvamQ1elBZbDFsbzIyeWUxV09MOElKZ09xekZEd0xY?=
 =?utf-8?B?cUJBKzJ4QWJwVXR5aGZ4dGtaUVNUdUEyUFFBZE8zajBvNXdNVVFGNk1RUFVN?=
 =?utf-8?B?SzJ3N0ZMZ2RocnBEZlJkeEFSM2VKY0svNXBYQlBBSjVHSXVCa0lUT0xrb3NT?=
 =?utf-8?B?ZWVWSmQrSUc2bDQvTG9INEpKTmlFamJxZFJnaDhlVWhPWW5oQ1NPdUZ6cUFU?=
 =?utf-8?B?eVpnbDd0VU9Vem0weWx3cFQyMFYrbDZQZEVoWjBuRmZSWU0wZ05UdUg1L2d0?=
 =?utf-8?B?YjZtdEFHYVlWbkxhQ3NXZVNjUHlFWElqYVEweGpyZEZpU0VjOWpFMEM4dUJ5?=
 =?utf-8?B?ZmxWeEFnQ0FkWkkrMndrakQzL2VCZCtrSGpuZHczU2NkVFNRdml4R2xPMGNp?=
 =?utf-8?B?UnRsamV4WThLWDJlZm53QUFhSnVJRGhFUWNpOXRpWnlVNitXc2dkMC9yMDgz?=
 =?utf-8?B?RzlVUHRFVmRKbUh1Wm5zQ0FZVFNiZkRyWFNpa29tMTFaRGxGbHIzKzJheWU2?=
 =?utf-8?B?SDlwYkVVN0lieDYvL0JSODZaWEY4bkx1d3VOa3U1ck9BMnAvTEJuZjNnSnU2?=
 =?utf-8?B?TS9JUHcydGtTbGk0L282MEU5TkRtMnlTVUxVR0hJUVovdU9jMmg4QnJBckdh?=
 =?utf-8?B?bG5STFJ1TXh3RkdVazR6RnRZRHAyb2hqbnpyNTY2N0lTcUhkUG5DQWxtSVcw?=
 =?utf-8?B?dnhlYkdJdXI2ZHRrQjlmVXcxZXAwUDJHdTBYZndnWkVlVU5KTlkxdWxNZXpS?=
 =?utf-8?B?SWswZmRWTHlLOGdPT3ZwWnBWMVVnSkEvV2E2cXZnWUxZTXJ0STNqbDErQ2lT?=
 =?utf-8?B?dkhnMllZemc1NTBjdHVSaGlTK3YxY0MydkdyK1JjaytLWFhXTm5MZWtjNXV2?=
 =?utf-8?B?QVBnenZIWTlsc044LyszMmloZ2t1TEVIWVBiNDRQNzB0dmJGendRN3B4RFND?=
 =?utf-8?B?ZzFIajlqbUk3aUVDRlEwcEdMelRTVktYODBmMnlMRnVIREFrdUx3SlF2NFNM?=
 =?utf-8?B?eG4rRVQ5bkc2cVo5QUh0dzBHdThNNjhDTEFuZ2xPSmdKbEZJMVBkZjBmVFdS?=
 =?utf-8?Q?wZpgi/T5R4Yh3dXlCsK4Ovg=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e659cb59-70ab-428c-ae6c-08d9e4cb4d2a
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1242.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2022 15:06:47.5335
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZtfwaGOHF5W0OZWoU2giJy2X+QWmAJvkyHM3BgoqDmdOaV9Z6CXjJYo6DJzc7H3WYjdTAI8oyqXaHjsaaQq3WA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4128
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/30/2022 7:42 PM, Christophe JAILLET wrote:
> In order to free resources correctly in the error handling path of
> pt_core_init(), 2 goto's have to be switched. Otherwise, some resources
> will leak and we will try to release things that have not been allocated
> yet.
> 
> Fixes: fa5d823b16a9 ("dmaengine: ptdma: Initial driver for the AMD PTDMA")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Acked-by: Sanjay R Mehta <sanju.mehta@amd.com>
> ---
>  drivers/dma/ptdma/ptdma-dev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/ptdma/ptdma-dev.c b/drivers/dma/ptdma/ptdma-dev.c
> index 8a6bf291a73f..3fa2a6ed4b68 100644
> --- a/drivers/dma/ptdma/ptdma-dev.c
> +++ b/drivers/dma/ptdma/ptdma-dev.c
> @@ -207,7 +207,7 @@ int pt_core_init(struct pt_device *pt)
>  	if (!cmd_q->qbase) {
>  		dev_err(dev, "unable to allocate command queue\n");
>  		ret = -ENOMEM;
> -		goto e_dma_alloc;
> +		goto e_pool;
>  	}
>  
>  	cmd_q->qidx = 0;
> @@ -230,7 +230,7 @@ int pt_core_init(struct pt_device *pt)
>  	/* Request an irq */
>  	ret = request_irq(pt->pt_irq, pt_core_irq_handler, 0, dev_name(pt->dev), pt);
>  	if (ret)
> -		goto e_pool;
> +		goto e_dma_alloc;
>  
>  	/* Update the device registers with queue information. */
>  	cmd_q->qcontrol &= ~CMD_Q_SIZE;
>