Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp897964pxb; Tue, 1 Feb 2022 12:43:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJxKI5PE4QciZpGKsXa4mwQXdD02JTr6e1069vWkprIiVogGkJ8nFEHzloUKxUM+NkHaGg9R X-Received: by 2002:aa7:cb48:: with SMTP id w8mr26786372edt.218.1643748181055; Tue, 01 Feb 2022 12:43:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643748181; cv=none; d=google.com; s=arc-20160816; b=HwJJjdlxPI4WsMuPehgj7DAMUoTlyH9+RPX+UWGsbYE4CVt64aVZWMFewcQqZro8/c tDZr5aulXfH3kczIf4pTMKS7eXuMXqoMVxNNcZWh/7i5k8Sa6fZQTEaF4uySLxBJ9wNq NDMBvA0Hj7fUXQRw/GUSkr4CrujgzPnXwr+ic1Tj7DSDTH8f2lVMF3E32hXNSv0yX7LY GWlZDqxY9uVQoSCY05Snry+Zbtxm4e47N2xNlKKgD5j1K+6x9IU7zXXpmfc2Zr3SzfzB cQ8mWzpJA2S0hoRUtWFzabiNxSDBHXiH9e+y9Mls4KZfLd4gLvz9uSTcdas6OLb2WmR3 6dwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=Gc9j6jTzs9/+1DXXuEa2a9CFcwDmyGnp8Sdtv9hjqN0=; b=GlfbpPxnqMXwimKZ6wjKhyMWXIhNkRTmCYW+67GqzBtFyrqaspX1gSMccIAbfzvnyj y2HVTnOprvCGKJlaDwCqFxQbsJQ+XITtOSCguqQ1/84FfTTGmt5mPHxkO7SNDA1NqUDO sD5HnU9EcLQOpl4d8TqTgNVahDY8K/JNRQ7XvMOLw+mCjviXlynMtFu1NLDII4JCWdZE 1gGgMUV0dcHnjcDNK9Iv2UsNsfRrBbUpHlRDUCJlhPkzh5LMccHT0mNws8y6QAAPssLC TvKMJlBulqmvaSiWHAMwy1rxgQUwgBttyE6xVOvP7kEIbmPEwPAtbQrxzExEe+ZEQsHc BuAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bi11si9858354edb.320.2022.02.01.12.42.35; Tue, 01 Feb 2022 12:43:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379884AbiAaPuV (ORCPT + 99 others); Mon, 31 Jan 2022 10:50:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245390AbiAaPuU (ORCPT ); Mon, 31 Jan 2022 10:50:20 -0500 Received: from theia.8bytes.org (8bytes.org [IPv6:2a01:238:4383:600:38bc:a715:4b6d:a889]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AC65C061714 for ; Mon, 31 Jan 2022 07:50:19 -0800 (PST) Received: by theia.8bytes.org (Postfix, from userid 1000) id 268E24DC; Mon, 31 Jan 2022 16:50:18 +0100 (CET) Date: Mon, 31 Jan 2022 16:50:16 +0100 From: Joerg Roedel To: John Garry Cc: will@kernel.org, robin.murphy@arm.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu: Fix some W=1 warnings Message-ID: References: <1643366673-26803-1-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1643366673-26803-1-git-send-email-john.garry@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 28, 2022 at 06:44:33PM +0800, John Garry wrote: > The code is mostly free of W=1 warning, so fix the following: > > drivers/iommu/iommu.c:996: warning: expecting prototype for iommu_group_for_each_dev(). Prototype was for __iommu_group_for_each_dev() instead > drivers/iommu/iommu.c:3048: warning: Function parameter or member 'drvdata' not described in 'iommu_sva_bind_device' > drivers/iommu/ioasid.c:354: warning: Function parameter or member 'ioasid' not described in 'ioasid_get' > drivers/iommu/omap-iommu.c:1098: warning: expecting prototype for omap_iommu_suspend_prepare(). Prototype was for omap_iommu_prepare() instead > > Signed-off-by: John Garry Applied, thanks.