Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
CC:     "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Russell King <linux@armlinux.org.uk>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Lee Jones <lee.jones@linaro.org>,
        "katie.morris@in-advantage.com" <katie.morris@in-advantage.com>
Subject: Re: [RFC v6 net-next 4/9] net: mdio: mscc-miim: add ability to
 externally register phy reset control
Thread-Topic: [RFC v6 net-next 4/9] net: mdio: mscc-miim: add ability to
 externally register phy reset control
Thread-Index: AQHYFVv0asWdnHBRe0uYWzT4HTrVl6x9YPYA
Date:   Mon, 31 Jan 2022 17:13:19 +0000
Message-ID: <20220131171318.ryule6y6ffowbrsm@skbuf>
References: <20220129220221.2823127-1-colin.foster@in-advantage.com>
 <20220129220221.2823127-5-colin.foster@in-advantage.com>
In-Reply-To: <20220129220221.2823127-5-colin.foster@in-advantage.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YiQfq5lUmQnEiB4hh0obnfxUFJBSX+Tkr06h5L0qZTUpzkrOtbjboD8O3BWd?=
 =?us-ascii?Q?RwMg4sKKiszYJ693N1Y2Thw/7AIYgZFlUI46zPmdIBLnLRJFtnAWDrb0kXLz?=
 =?us-ascii?Q?71HqrgSSTTO7irqUiqjOlax08rRuY3n1a/rLYt5R73YSTaqd/FmdWcEqD2TY?=
 =?us-ascii?Q?m3PGhDkoecmrdyVfqECnIvO/Z34LbaeMFq4Tjf1KpN8vI3IpI+zaiNObgKQT?=
 =?us-ascii?Q?Id6XzvQL8wX8gPsfAxPhDSfuGyNYRPwjk1CDCv78oA6mLMKyK/mRhQscGE+s?=
 =?us-ascii?Q?06eBcmQmHpazT79LGlCcBC0I4TZ/f3PkUFckd1cO303jmj9QvsMR0tKTYtai?=
 =?us-ascii?Q?1SM2vU7Xzne46IayWcpEUY1Qv2RCJ3hGkrmcovT5sMv00qdgijh9fQCBGevO?=
 =?us-ascii?Q?7i9wgdJxG1bdjMuox6iu59ebOkZxiL9IwNHz4I5taU2ThppLIOQVqZef+yhW?=
 =?us-ascii?Q?MRw6rrcDaxYdOPuIkp+XnLXvUOSpeCyormZP/ZaWDHMrvwmcFimLhFjZkEZC?=
 =?us-ascii?Q?SBJZYw9nX/8orcCxhVTKbUAyo5lSgbjkDTXedDmFG+Elj2QRe0Z3ffF5hNTV?=
 =?us-ascii?Q?wCWsHi4LwK8bn8w40aYOIIH45N4eRbO85kzmUPlIwJQJS5fuHPVNEEiCPZM9?=
 =?us-ascii?Q?jVI07q3JPjY5nN/x2okkm9U7j3P+SQKGY8o0/KgjiTgy1DdQxhNCDbASGcI9?=
 =?us-ascii?Q?Z7dctiW8dTwBPDODsgBpebivp49GTOaV8lrVNinx8gq0iQEKMJW8ityjhb/p?=
 =?us-ascii?Q?sHXdrYR+MmfV8EpCGm1wyP058gsLVoyhj1fUfGroMJCq0rUCgo+NAefwciFW?=
 =?us-ascii?Q?A1hX8xSWyyRSNjrCnpMwjq0NC6EorFfavW/d+rh5zDjyxnHQH2E36j9U4yH8?=
 =?us-ascii?Q?rQ+xUw+iB8IfEZ13+a0E/ag8BT4gDURQ9uAmHVgU8KCktfSipTp+30uGz5id?=
 =?us-ascii?Q?ApojcNm2Pt7zErf7ncYvxzkm4sHgrxmNhaD3XyErkezCISbSf6z/yAa0G6q4?=
 =?us-ascii?Q?rTovpCM+qMQ0YotSmuRDKisokapIkLMWmgujVDfKi1m4L2BxGL2d49+pIX3q?=
 =?us-ascii?Q?zwGdATqaVqUuvOBenn2p9uP081mIdLlbNqZf5xR7c90ChGNZRZK6qFi9bQuK?=
 =?us-ascii?Q?APQFt7+qfsu9j+IoSmcEf1x3jdNpXHcYPt/4tKBnsvkySND/6S4qrQOvu9ng?=
 =?us-ascii?Q?Eozmit5r3XGvCF4sy7X9FRbfxpHcoQwa2/4Q0BENRg2g/wZIyuPlIg3Po+/n?=
 =?us-ascii?Q?t41NaeyDJTMG2V2dXl/AJis91RzO8h3R58vSffo8jqM551mft7+sOXc1zc74?=
 =?us-ascii?Q?KIems3T0057lN4I5y3yzUSOFS8adu8zgne2XKyEMvx2EN7ei6dIqkc3m7fcb?=
 =?us-ascii?Q?j/fpc+hdTqRq2sv/ctbFAZgXwnQKn7hwpldXWZVw8lrP0Q7ivJMjTB+8hK8f?=
 =?us-ascii?Q?JVY+3J8SJuS3Xw/krMnqR0ON7pOcWJ/9F7aWpiJ1RhWPIKT3obSix2GAC4G5?=
 =?us-ascii?Q?e5H5A3CSgO93M9oed2mq/1UerQXlJpmLeejmvUfGRZL2Nqajrv5u+52oInuf?=
 =?us-ascii?Q?ENI+NSfKyWMDkc6w2uEYb2oB+ikJaAjXhTAbGxESef+Xk+zu3sOFGxLN4De/?=
 =?us-ascii?Q?HJ+ZYOjsBQTwgyz/VN+8op4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F72DD5EB1572B4438E08098CBC088719@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c27f38de-b6f8-4d72-3603-08d9e4dcfa3e
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2022 17:13:19.0861
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fkZvpP/n4FmVBz45pB5KXzmqYA1tr/p2J/qoegnNjB4Aps/UqMwvZuTTxQDv+XtG0D/+VFmgRkK0QmS9XSV2Ng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9156
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jan 29, 2022 at 02:02:16PM -0800, Colin Foster wrote:
> @@ -257,15 +260,14 @@ static int mscc_miim_probe(struct platform_device *=
pdev)
>  		}
>  	}
> =20
> -	ret =3D mscc_miim_setup(dev, &bus, "mscc_miim", mii_regmap, 0);
> +	ret =3D mscc_miim_setup(&pdev->dev, &bus, "mscc_miim", mii_regmap, 0,
> +			      phy_regmap, 0);
>  	if (ret < 0) {
>  		dev_err(dev, "Unable to setup the MDIO bus\n");
>  		return ret;
>  	}
> =20
>  	miim =3D bus->priv;

You left this variable set but not used. Please delete it.

> -	miim->phy_regs =3D phy_regmap;
> -	miim->phy_reset_offset =3D 0;
> =20
>  	ret =3D of_mdiobus_register(bus, dev->of_node);
>  	if (ret < 0) {=