Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Jesse Hathaway <jesse@mbuki-mvuki.org>
To:     ycheng@google.com
Cc:     davem@davemloft.net, edumazet@google.com,
        gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        ncardwell@google.com, pavel@denx.de, sashal@kernel.org,
        soheil@google.com, stable@vger.kernel.org, weiwan@google.com,
        jesse@mbuki-mvuki.org
Subject: Re: [PATCH 5.10 099/167] tcp: disable TFO blackhole logic by default
Date:   Mon, 31 Jan 2022 11:17:32 -0600
Message-Id: <20220131171732.1018990-1-jesse@mbuki-mvuki.org>
In-Reply-To: <CAK6E8=cEX6MjxdnW36t9qq8+RqkPp9ZTwwH9Mr=emfbJ4=WV0Q@mail.gmail.com>
References: <CAK6E8=cEX6MjxdnW36t9qq8+RqkPp9ZTwwH9Mr=emfbJ4=WV0Q@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, Jul 28, 2021 at 09:32:42 -0700 Yuchung Cheng <ycheng@google.com> wrote:

> On the other hand maybe we do not hear middlebox issues because this
> mechanism is working. So I am okay to avoid applying to stable and
> keep in net-next to test this new policy.

This change did indeed break our mail servers at Wikimedia, causing
difficult to diagnose timeout errors on sending outgoing email. I
resorted to bisecting the kernel, which resulted in finding this commit.
I have verified that reverting the sysctl value for
tcp_fastopen_blackhole_timeout_sec to 3600 does resolve the timeouts.

Given that it is not clear how a user would discover that this sysctl
has changed, or know how to fix a middle box somewhere on a path to
their destination, I would love to see this change reverted.

Yours kindly, Jesse Hathaway