Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20220114091502.333083-1-allen.chen@ite.com.tw> <f4696a8d-5c1d-1007-7814-b2e6cbe334ae@collabora.com>
In-Reply-To: <f4696a8d-5c1d-1007-7814-b2e6cbe334ae@collabora.com>
From:   Robert Foss <robert.foss@linaro.org>
Date:   Mon, 31 Jan 2022 17:37:03 +0100
Message-ID: <CAG3jFytN9iu0BteAxFCLVRorxM20Q3Zrfn1T4k8bnDYy5oL7bg@mail.gmail.com>
Subject: Re: [PATCH v11] drm/bridge: add it6505 driver
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
Cc:     allen <allen.chen@ite.com.tw>,
        Kenneth Hung <Kenneth.Hung@ite.com.tw>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Jau-Chih Tseng <Jau-Chih.Tseng@ite.com.tw>,
        David Airlie <airlied@linux.ie>,
        "open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
        Neil Armstrong <narmstrong@baylibre.com>,
        open list <linux-kernel@vger.kernel.org>,
        Jonas Karlman <jonas@kwiboo.se>,
        Hermes Wu <Hermes.Wu@ite.com.tw>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Hsin-yi Wang <hsinyi@chromium.org>,
        Hsin-Yi Wang <hsinyi@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 20 Jan 2022 at 16:25, AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> Il 14/01/22 10:14, allen ha scritto:
> > This adds support for the iTE IT6505.
> > This device can convert DPI signal to DP output.
> >
> > From: Allen Chen <allen.chen@ite.com.tw>
> > Tested-by: Hsin-yi Wang <hsinyi@chromium.org>
> > Signed-off-by: Hermes Wu <hermes.wu@ite.com.tw>
> > Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
> > ---
> > v10 -> v11 : remove drm_bridge_new_crtc_state
> > ---
> >   drivers/gpu/drm/bridge/Kconfig      |    8 +
> >   drivers/gpu/drm/bridge/Makefile     |    1 +
> >   drivers/gpu/drm/bridge/ite-it6505.c | 3352 +++++++++++++++++++++++++++
> >   3 files changed, 3361 insertions(+)
> >   create mode 100644 drivers/gpu/drm/bridge/ite-it6505.c
> >
>
> ...snip...
>
> > +static const struct of_device_id it6505_of_match[] = {
> > +     { .compatible = "ite,it6505" },
> > +     { }
> > +};
>
> If you want to have a DT compatible and DT properties, you have to also add
> dt-bindings (yaml) for this driver, otherwise, any SoC/device DT will fail
> the dt binding check.... So, please, add that.

Let me second this. A dt-binding is needed for this driver to be
complete, it functions as both documentation and a way to test the DTS
that use this device, so it is really important.

>
> For the driver by itself, though:
>
> Acked-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
> > +
> > +static struct i2c_driver it6505_i2c_driver = {
> > +     .driver = {
> > +             .name = "it6505",
> > +             .of_match_table = it6505_of_match,
> > +             .pm = &it6505_bridge_pm_ops,
> > +     },
> > +     .probe = it6505_i2c_probe,
> > +     .remove = it6505_i2c_remove,
> > +     .shutdown = it6505_shutdown,
> > +     .id_table = it6505_id,
> > +};
> > +
> > +module_i2c_driver(it6505_i2c_driver);
> > +
> > +MODULE_AUTHOR("Allen Chen <allen.chen@ite.com.tw>");
> > +MODULE_DESCRIPTION("IT6505 DisplayPort Transmitter driver");
> > +MODULE_LICENSE("GPL v2");
> >
>