Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp900316pxb; Tue, 1 Feb 2022 12:46:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJwR7sXbJOe8oSJ947uQ7R4HgFlYx6wmYOXqfU5nOVK0nN/aSRCfuvE4DvMMFlQuyhHlwRJP X-Received: by 2002:a17:903:1cc:: with SMTP id e12mr26199831plh.150.1643748367149; Tue, 01 Feb 2022 12:46:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643748367; cv=none; d=google.com; s=arc-20160816; b=R3ssEk3ds8qXnDktwTQeOITXKgN1viH+tFHTWjtkfeckDXPXePpKuKSPs/bDW6VCAj 17elWKG1du/It4pjP/aFFgd63FpgvLQnt5W79oBmUvqb8u8vboN2LLnkSJ1HGdzXZ/C6 0S/pAloWaMdrBlLE3hzaTkkhGwmaoagjNhNOkUIgdzE5NN7xjP5fAs46iPdzy26Sp5FX atueObrS++b4OVAndu22ndoCaOfRYzwPROrvM3ZhI6lDThEEjEMxuxpaXIhYkHnB24Tr etZdLm03yA5bPt5wQ2kSqCSMoXS7R+5AlcBXPS9IKtZiYMyGOJrqQFCZG12NN8gaC5X6 c2qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=2YAk2qmL1jvKsAvHFxP+29GfF6Oz1VRnK3+46u7RjKg=; b=Vx2RV5TT+bfHBNNAbTdmfAVMCaYEVTPsTUEYWaEnZzKlvGEAuvGcGDMds4xUBsaK4m fNHhDvDyw/7HwdJjkAKyA3nzThi0xhQQUufwY8zbIiDYyZEIBzHPZbRQRH3eTC6H1hRJ rePlHOo62/rbpAJqj3P8MtHog/q2UgKX9Zr4LE3BJvCiqWcHWHm8sAricebKZC9zqgXq vaBrsGrQ7noUmRlTiaEjVxIhhsqpvRblloMBdKo1xdTRdrIKdPvdHbU2PwuOY+ZiLt1C gKOyTLKCj3l2xsOXwuQxlbLhhvfMPmtAKPVQPZXuBP/FueY7PAeX3Df8RWi9WrI8akYg SM0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=l4jC6Fnv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h14si1574890pfv.60.2022.02.01.12.45.55; Tue, 01 Feb 2022 12:46:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=l4jC6Fnv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1380562AbiAaQz5 (ORCPT + 99 others); Mon, 31 Jan 2022 11:55:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232421AbiAaQz4 (ORCPT ); Mon, 31 Jan 2022 11:55:56 -0500 Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20835C061714 for ; Mon, 31 Jan 2022 08:55:56 -0800 (PST) Received: by mail-il1-x129.google.com with SMTP id q11so3761762ild.11 for ; Mon, 31 Jan 2022 08:55:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2YAk2qmL1jvKsAvHFxP+29GfF6Oz1VRnK3+46u7RjKg=; b=l4jC6Fnvz4YWeocB1LDcxqIYS1XhOhwypDQk9XyVGOfwBi9dxSsAf/3+ql8devyalw 1Ov0Ww3huiiRc9tzmqI2mpZ5w66MUcOHqg2RZvBVZNBKTfFWLGNJAFwyQ/BnEVWdXjMo 6R1UPzgaiOgOMljHT1KBW9dC/G2EJvKqSpJXs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2YAk2qmL1jvKsAvHFxP+29GfF6Oz1VRnK3+46u7RjKg=; b=u8Ln1GHMpTNhhAe4ut4zDYX+XA9+VNI+NqoWT4h6PyWyI/E5q6vklway+SNsZn4Z3Y JnDKavmco1pMPXdtHEx2s9umFES7ZIeppaicLoO6fqcQ5XeInie+cmAhZff74hk07Db9 9OWi76en+5/XowMGflNKe4wJqw//hcOmTEeasHPYpz1eYFrKt5rZV9uuj1B2kOvOTr7z +GrWBibTVrkPreN9J+lHt11tSVBJqYHNxwJeqmq/eDj2eo/dUdMyEkpqy8Hust5RWQGX LvG1vDA1um5c/44S72p7AqffK8br+A54xz8EFoQrio8AETkegM9/BZXUay0ATM6zhdCd 1uAQ== X-Gm-Message-State: AOAM531/P33RRYxbDGizP6y4t77Y4fa5CHRQIrp+pep6BLFCBiseL6mk KZV5BBBf/grYWPINGIj8GqV2XVeiYaECkdPEgNpySA== X-Received: by 2002:a05:6e02:12e6:: with SMTP id l6mr12825345iln.10.1643648155481; Mon, 31 Jan 2022 08:55:55 -0800 (PST) MIME-Version: 1.0 References: <20220114091502.333083-1-allen.chen@ite.com.tw> In-Reply-To: From: Hsin-Yi Wang Date: Tue, 1 Feb 2022 00:55:29 +0800 Message-ID: Subject: Re: [PATCH v11] drm/bridge: add it6505 driver To: Robert Foss Cc: AngeloGioacchino Del Regno , allen , Kenneth Hung , Jernej Skrabec , Jau-Chih Tseng , David Airlie , "open list:DRM DRIVERS" , Neil Armstrong , open list , Jonas Karlman , Hermes Wu , Laurent Pinchart , Andrzej Hajda , Hsin-Yi Wang Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 1, 2022 at 12:37 AM Robert Foss wrote: > > On Thu, 20 Jan 2022 at 16:25, AngeloGioacchino Del Regno > wrote: > > > > Il 14/01/22 10:14, allen ha scritto: > > > This adds support for the iTE IT6505. > > > This device can convert DPI signal to DP output. > > > > > > From: Allen Chen > > > Tested-by: Hsin-yi Wang > > > Signed-off-by: Hermes Wu > > > Signed-off-by: Allen Chen > > > --- > > > v10 -> v11 : remove drm_bridge_new_crtc_state > > > --- > > > drivers/gpu/drm/bridge/Kconfig | 8 + > > > drivers/gpu/drm/bridge/Makefile | 1 + > > > drivers/gpu/drm/bridge/ite-it6505.c | 3352 +++++++++++++++++++++++++++ > > > 3 files changed, 3361 insertions(+) > > > create mode 100644 drivers/gpu/drm/bridge/ite-it6505.c > > > > > > > ...snip... > > > > > +static const struct of_device_id it6505_of_match[] = { > > > + { .compatible = "ite,it6505" }, > > > + { } > > > +}; > > > > If you want to have a DT compatible and DT properties, you have to also add > > dt-bindings (yaml) for this driver, otherwise, any SoC/device DT will fail > > the dt binding check.... So, please, add that. > > Let me second this. A dt-binding is needed for this driver to be > complete, it functions as both documentation and a way to test the DTS > that use this device, so it is really important. > The binding seems to be accepted before the driver: https://elixir.bootlin.com/linux/v5.16.4/source/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > > > > For the driver by itself, though: > > > > Acked-by: AngeloGioacchino Del Regno > > > > > + > > > +static struct i2c_driver it6505_i2c_driver = { > > > + .driver = { > > > + .name = "it6505", > > > + .of_match_table = it6505_of_match, > > > + .pm = &it6505_bridge_pm_ops, > > > + }, > > > + .probe = it6505_i2c_probe, > > > + .remove = it6505_i2c_remove, > > > + .shutdown = it6505_shutdown, > > > + .id_table = it6505_id, > > > +}; > > > + > > > +module_i2c_driver(it6505_i2c_driver); > > > + > > > +MODULE_AUTHOR("Allen Chen "); > > > +MODULE_DESCRIPTION("IT6505 DisplayPort Transmitter driver"); > > > +MODULE_LICENSE("GPL v2"); > > > > >