Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 31 Jan 2022 09:15:41 -0800
From:   Roman Gushchin <guro@fb.com>
To:     Waiman Long <longman@redhat.com>
CC:     Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>,
        Vladimir Davydov <vdavydov.dev@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        <linux-kernel@vger.kernel.org>, <cgroups@vger.kernel.org>,
        <linux-mm@kvack.org>, Shakeel Butt <shakeelb@google.com>,
        Muchun Song <songmuchun@bytedance.com>
Subject: Re: [PATCH 1/3] mm, memcg: Don't put offlined memcg into local stock
Message-ID: <YfgZPSs8H6PBCwdt@carbon.dhcp.thefacebook.com>
References: <20211001190938.14050-1-longman@redhat.com>
 <20211001190938.14050-2-longman@redhat.com>
 <YVefHLo1+6lgw3aB@carbon.dhcp.thefacebook.com>
 <f7026256-4086-6632-569e-5b13594cb3fc@redhat.com>
 <YfgV2iiaVlR0hozD@carbon.dhcp.thefacebook.com>
 <95ba1931-e9c9-45c3-b080-d28f2ad368a7@redhat.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <95ba1931-e9c9-45c3-b080-d28f2ad368a7@redhat.com>
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1tDU4AyBhLMW31S6/FzEjw4RwJ7gxnCIGiqFJyqAYueBlUg2nVigYPwHvQMF?=
 =?us-ascii?Q?NBuWtUbNQlIPJZCh9u6sopRfnAMDQ1bypri4P7+hRjwTSZHZ609DNE6uaqCQ?=
 =?us-ascii?Q?J1xQxTLmik403ycSdiXS0pSQzvalr2rSAqU2eu+vcwAWTelimLGohfRlhudy?=
 =?us-ascii?Q?1blkfdsEUJtREDMf9ZzxBm0jR55vy4vDF7uItZbDKYMk7B+AtCUK5SqdGQ1v?=
 =?us-ascii?Q?vUTMSqqPEZBnVmlgsn9ve+5XSBRYWHZ35BLAM1vVm3tnbEuPDHjsNZryXy7Y?=
 =?us-ascii?Q?+F3IdS6T9ckIxupTA7xbwr0eW38B4udKSzK471topVSkHuYJFIiRMjDTdM3q?=
 =?us-ascii?Q?xrQmwV3WpDC8bRSp2sc5evvkC7Bm8kFeDfNwAqWblsXX4tx8eVtJ12NEEn0M?=
 =?us-ascii?Q?L/YK+6Ex24gyN8koHdvpvb2lG5L8rSZVSkBtqGZT0RPnCtaS6oUEDoRD7avz?=
 =?us-ascii?Q?WDcOAS6Ao5NOsBxIA7EJJY8L5OVXtzVkrxhEqnQE19My38lrXrcqB4pErNG0?=
 =?us-ascii?Q?SX43VBreyPJJm0zcN/pT6auAfgxPzVslF2JcY6suTEViNpWoEWZvr/xNPgKA?=
 =?us-ascii?Q?yKu7jSM+WrQ7AKHhSi5bSyq60Z7UL3gqkpix132M0P+SXW15WnWrZvNsXNTk?=
 =?us-ascii?Q?TJRovVA5H2s1QTG3V4Afd+MUBdcneftC5Bh0JJtg6qDhEKn6EC4mgYCq/lXj?=
 =?us-ascii?Q?DVF7YLpl7xiAxWqGGFNntsO1b54iqJ0rhxi1K27iWr3o7bxJKhnILLd6NUMy?=
 =?us-ascii?Q?lG/jZKCtQrCwNVmpPyR8pba99q8n8EdivILtxvSErm5mQZrTJFFpmexx1Mn5?=
 =?us-ascii?Q?i+NfeTG1W07wSu5LSD0afV3OlUytY7wPgNEDsn9uVBLOqAera67lKfoa4dWT?=
 =?us-ascii?Q?Xsq9kUst4DVbYbikKS2y4EoFYEH6CfUyd/FpRZ+zfUOMa4EP8gaZy3JNS5Hx?=
 =?us-ascii?Q?1h/6QnuICRrByiBhNr8B/M0YHHxxImznFujFikcTgb/a4IuvcAeJTy0YcWnp?=
 =?us-ascii?Q?557jKm64Qpt83p/GBx6BAJtgxY/9C+Pdu0G5b7/WCx03BmKjB4tpOtIGSo+y?=
 =?us-ascii?Q?stWXNDLFlMVE5urXO+c55mqYnu1tTMBZoqfZvJjp+n1r6d96BvUuL2jqbhiJ?=
 =?us-ascii?Q?uQU9CC1IePdRzxJDvc56ZhZKhRiygxi1CPHnq49/b33E2MMWrvpsPyCQ/VjZ?=
 =?us-ascii?Q?CWKAD/rFfIy0WFCBfGrc8KA5LioE8RicM+wphuUQ8ij2Q+L0iOTjwRp6OWCt?=
 =?us-ascii?Q?+2tzx9ich4lLjxF/i3fmOd9jga90RIQj5uLJwBYBAVL7cDEiRNV2BF/cKA3z?=
 =?us-ascii?Q?yiJzV4bSH4t8qyv73r1sML/K5wjVju7bDCJxeiW+yzBmDedM41x0rBBvhSgh?=
 =?us-ascii?Q?Sudv7DqxQ+H1oohNOJlEatRf7vbZt6ztwxaScFiSn/iOLyKMa0edv/1KaLkS?=
 =?us-ascii?Q?Q/J3oYw5LCBywNs7c9sVGgikl8yNi8Og8YVF0RRbNLbRTieqgw7pmt3J/3L5?=
 =?us-ascii?Q?1ZPM0jqZDYokUWI9+/XmyeKc99KhWBM3pfN/uwQnQG0eF+2gVuEdKvvd/nFl?=
 =?us-ascii?Q?x0GBzIAxC8FQtd4ZCHOwNC+1vnoVH03wvPV8FqT6?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ca13162-5475-4999-7075-08d9e4dd513c
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2022 17:15:45.2237
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tgUX1LhETCicIChLUhXANGP45p3AA6AFmOzuYzdV0TdSCpuKVYie1HCKAHfKhytb
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR15MB4724
X-OriginatorOrg: fb.com
X-Proofpoint-GUID: _-e6E2-a_gdg1qqhi2oL-kOUZNWgJv3c
X-Proofpoint-ORIG-GUID: _-e6E2-a_gdg1qqhi2oL-kOUZNWgJv3c
X-Proofpoint-UnRewURL: 1 URL was un-rewritten
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-01-31_07,2022-01-31_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=1 adultscore=0 mlxscore=1
 phishscore=0 spamscore=1 impostorscore=0 lowpriorityscore=0
 mlxlogscore=199 priorityscore=1501 malwarescore=0 clxscore=1015
 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2201310113
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 31, 2022 at 12:09:09PM -0500, Waiman Long wrote:
> On 1/31/22 12:01, Roman Gushchin wrote:
> > On Sun, Jan 30, 2022 at 10:55:56PM -0500, Waiman Long wrote:
> > > On 10/1/21 19:51, Roman Gushchin wrote:
> > > > On Fri, Oct 01, 2021 at 03:09:36PM -0400, Waiman Long wrote:
> > > > > When freeing a page associated with an offlined memcg, refill_stock()
> > > > > will put it into local stock delaying its demise until another memcg
> > > > > comes in to take its place in the stock. To avoid that, we now check
> > > > > for offlined memcg and go directly in this case to the slowpath for
> > > > > the uncharge via the repurposed cancel_charge() function.
> > > > Hi Waiman!
> > > > 
> > > > I'm afraid it can make a cleanup of a dying cgroup slower: for every
> > > > released page we'll potentially traverse the whole cgroup tree and
> > > > decrease atomic page counters.
> > > > 
> > > > I'm not sure I understand the benefits we get from this change which
> > > > do justify the slowdown on the cleanup path.
> > > > 
> > > > Thanks!
> > > I was notified of a lockdep splat that this patch may help to prevent.
> > Would you mind to test this patch:
> > https://www.spinics.net/lists/cgroups/msg31244.html  ?
> > 
> > It should address this dependency.
> 
> Thanks for the pointer. I believe that your patch should be able to address
> this circular locking dependency.
> 
> Feel free to add my
> 
> Reviewed-by: Waiman Long <longman@redhat.com>

Thank you!