Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 31 Jan 2022 09:32:58 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Russell King <linux@armlinux.org.uk>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Lee Jones <lee.jones@linaro.org>,
        "katie.morris@in-advantage.com" <katie.morris@in-advantage.com>
Subject: Re: [RFC v6 net-next 4/9] net: mdio: mscc-miim: add ability to
 externally register phy reset control
Message-ID: <20220131173258.GA28216@COLIN-DESKTOP1.localdomain>
References: <20220129220221.2823127-1-colin.foster@in-advantage.com>
 <20220129220221.2823127-5-colin.foster@in-advantage.com>
 <20220131171318.ryule6y6ffowbrsm@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220131171318.ryule6y6ffowbrsm@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ckwmohITuBMnL3awEr3jzX76UzJ91GfQg4Q4IDGDLYBP6hfO/vZHSBuSvL4N?=
 =?us-ascii?Q?0D3+8t9zQeTpH2ILNALpWquHxiiF7MsK534HI1nBnjPOI7ox10aBEMZPFoSl?=
 =?us-ascii?Q?CgXIlh4sPExXti78FJvNn74MQT7K+7sImQQZ1ZkWqS3G6HwmOB9PDt0QFwys?=
 =?us-ascii?Q?cCCI2GvehnbLMa1KdgNulUrSt/qA/5Ld79Vvo/7IK3XTWIcZ7qmdMkZQpbuY?=
 =?us-ascii?Q?ZY5+no00ruZ2NGj7/oI03mdshl+BzMbW0QIF8QZWAV38pv7cruvCBM1QA8z7?=
 =?us-ascii?Q?lw0CcxOsYxOLjIGY7I4dZriUAzMf5k0uJPV1dW6/O/V8HBs1jZE9G3nVFDzJ?=
 =?us-ascii?Q?y6ToCuQ+gkuLMCUpoM3xs4e1w3+aMr/r2oOAjqdeRLk+9iXT8YsOzWQlRbvs?=
 =?us-ascii?Q?2WO2luhrTCEEv3VunzG1ijtQBhUyb057CKnP1EW2uSWOTKJXAs2i+FnXf98V?=
 =?us-ascii?Q?9aLluPLLyYM+G9N8LJcHVMqBHuFFGMttYmli2yHvWSoKH5e//HdaHV7lVH9G?=
 =?us-ascii?Q?5c/BeEVrNRCkg5ZcmGppuIaUkMdRBvnbysueIXKFKq2FG8x6Vv/cYbAkVzIS?=
 =?us-ascii?Q?xd6yxW3omSd9wp0xULxvdeGehPLWO0Z1Fail1UXjpf9hB55Bp7Dm+BpgayRk?=
 =?us-ascii?Q?h2mFWa3e6qW+EX2x3Pl3+prrJ2vGjsv+iE0Li9tqPtNKrrD2p68cT6UYGtU7?=
 =?us-ascii?Q?SWLnyrKfYIDkopLGPsEAdzjM+1WnSz+BpGCSu4VYV5EWirWZLys+3IAKIA+Z?=
 =?us-ascii?Q?ZArpYrcNWqDGWs9mXKc8izeZQzxpSxnHC1WPjcVVVNVLJndyrqMq+GuF0g2F?=
 =?us-ascii?Q?mpWmOJQDckssbiXoUuENXSfobUBHzRLVrFua+lGiyJjXbgJWFV3AdpsKRJ0E?=
 =?us-ascii?Q?DCfed80CpWIWE8c7UxT1GBfbwmlGWVmQMYd+uC6woEMiL01w5Dw/aWEVg2oK?=
 =?us-ascii?Q?/Rmhy5J+fs3OjPcGVUOiP/6nHKMCi5uHdX2jd8AFqRVHEnRIg8XJ593BntLb?=
 =?us-ascii?Q?fUs4osVT8MTCbrYnghleYDtq3L4anNTkeLsir4FNNmR0iksLCv4wcL7eitrj?=
 =?us-ascii?Q?lfG7O//SuGpkf3JrzLLn7uMh/3Hk93wBxO6p8iS+//AO4cfVbBE8nwwfiBHE?=
 =?us-ascii?Q?gcaKGpyerO2PE1vhDCZq44TOZMS8xHCD1Of45wn4dj5DwMIem+PkisO80VPM?=
 =?us-ascii?Q?VU4H34UmczDFnZvfEIn33IOVMbsfCuZoP6ZZbNQWWC9OosilyMxV+/nwFOTY?=
 =?us-ascii?Q?83okQVeyk9hwSDhSOIzP+UYGhxJGkgsz30LC8/152YofNE0v0+s1T4rw0vDG?=
 =?us-ascii?Q?LGj+bwYN0Y6q/n4RPkQBEdn3sGeVZXbz4tN17qkuGv7qeTinBjfL53I9U9o7?=
 =?us-ascii?Q?2oqxrEohua7/KqKtJgIw7eIq2PmDoSoUGPsWW1L2D+j8/FC2N18odTwEvF/6?=
 =?us-ascii?Q?BXDNC28eIIPUFuVzencmfnMa74F+iujv/pImFWNpn0QV1U+xkort13lx0Be5?=
 =?us-ascii?Q?eiQNMnaCNxvGVvd76W6RoStyobXGwOHU3SDIUO4vIcTXX+hNtAVdhloYZAbD?=
 =?us-ascii?Q?9yGwyLVfcZu7dpxCy9PBS9Wx79ouamo+rquwzzWwTc7k69Ti2awd95iI1P4A?=
 =?us-ascii?Q?pVnioDHGNMpmc4/ReRrMvXlzhnFvShcGO7hd6lec0mEi8MD6yqcJDhKOvOPF?=
 =?us-ascii?Q?KpFU2w=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19723e15-cbb9-4ea7-ff7e-08d9e4dfb40d
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2022 17:32:50.0698
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BP/9ByIWZWos8jB8ugOTKR9x1OtT75eP6KCpsorxvtlu/gP0Dkm/pj0NezZPTihcQpRzFXO875Oo9U/pcg82ZzGTtfan23Gk92wnpOuVduc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2178
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Vladimir,

On Mon, Jan 31, 2022 at 05:13:19PM +0000, Vladimir Oltean wrote:
> On Sat, Jan 29, 2022 at 02:02:16PM -0800, Colin Foster wrote:
> > @@ -257,15 +260,14 @@ static int mscc_miim_probe(struct platform_device *pdev)
> >  		}
> >  	}
> >  
> > -	ret = mscc_miim_setup(dev, &bus, "mscc_miim", mii_regmap, 0);
> > +	ret = mscc_miim_setup(&pdev->dev, &bus, "mscc_miim", mii_regmap, 0,
> > +			      phy_regmap, 0);
> >  	if (ret < 0) {
> >  		dev_err(dev, "Unable to setup the MDIO bus\n");
> >  		return ret;
> >  	}
> >  
> >  	miim = bus->priv;
> 
> You left this variable set but not used. Please delete it.

Correct. Good catch. There were a couple of these in v6 that
kernel-test-robot is happy to point out to me :-)

Already fixed in my v7 branch.

> 
> > -	miim->phy_regs = phy_regmap;
> > -	miim->phy_reset_offset = 0;
> >  
> >  	ret = of_mdiobus_register(bus, dev->of_node);
> >  	if (ret < 0) {