Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 31 Jan 2022 10:35:40 -0800
From:   Saeed Mahameed <saeedm@nvidia.com>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Stephen Hemminger <stephen@networkplumber.org>,
        Saeed Mahameed <saeed@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Mark Einon <mark.einon@gmail.com>,
        Lino Sanfilippo <LinoSanfilippo@gmx.de>,
        Maxime Ripard <mripard@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Shay Agroskin <shayagr@amazon.com>,
        Arthur Kiyanovski <akiyano@amazon.com>,
        David Arinzon <darinzon@amazon.com>,
        Noam Dagan <ndagan@amazon.com>,
        Saeed Bishara <saeedb@amazon.com>,
        Chris Snook <chris.snook@gmail.com>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        Hans Ulli Kroll <ulli.kroll@googlemail.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Jeroen de Borst <jeroendb@google.com>,
        Catherine Sullivan <csully@google.com>,
        David Awogbemila <awogbemila@google.com>,
        Yisen Zhuang <yisen.zhuang@huawei.com>,
        Salil Mehta <salil.mehta@huawei.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "K . Y . Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
        Jon Mason <jdmason@kudzu.us>,
        Simon Horman <simon.horman@corigine.com>,
        Rain River <rain.1986.08.12@gmail.com>,
        Zhu Yanjun <zyjzyj2000@gmail.com>,
        Shannon Nelson <snelson@pensando.io>, drivers@pensando.io,
        Sergey Shtylyov <s.shtylyov@omp.ru>,
        Jiri Pirko <jiri@resnulli.us>,
        Edward Cree <ecree.xilinx@gmail.com>,
        Martin Habets <habetsm.xilinx@gmail.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <Jose.Abreu@synopsys.com>,
        Andy Gospodarek <andy@greyhouse.net>,
        Michal Simek <michal.simek@xilinx.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Jacob Keller <jacob.e.keller@intel.com>,
        Vegard Nossum <vegard.nossum@oracle.com>,
        Rob Herring <robh@kernel.org>, l.stelmach@samsung.com,
        rafal@milecki.pl, Florian Fainelli <f.fainelli@gmail.com>,
        Edwin Peer <edwin.peer@broadcom.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Michael Chan <michael.chan@broadcom.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Marcin Wojtas <mw@semihalf.com>,
        Oleksij Rempel <linux@rempel-privat.de>,
        Gabriel Somlo <gsomlo@gmail.com>,
        Joel Stanley <joel@jms.id.au>, Slark Xiao <slark_xiao@163.com>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        Liming Sun <limings@nvidia.com>,
        David Thompson <davthompson@nvidia.com>,
        Asmaa Mnebhi <asmaa@nvidia.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Steen Hegelund <steen.hegelund@microchip.com>,
        Prabhakar Kushwaha <pkushwaha@marvell.com>,
        Omkar Kulkarni <okulkarni@marvell.com>,
        Shai Malin <smalin@marvell.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Stefan Wahren <stefan.wahren@i2se.com>,
        Gary Guo <gary@garyguo.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-sunxi@lists.linux.dev, intel-wired-lan@lists.osuosl.org,
        linux-hyperv@vger.kernel.org, oss-drivers@corigine.com,
        linux-renesas-soc@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH net-next] net: kbuild: Don't default net vendor configs
 to y
Message-ID: <20220131183540.6ekn3z7tudy5ocdl@sx1>
References: <20220131172450.4905-1-saeed@kernel.org>
 <20220131095905.08722670@hermes.local>
 <CAMuHMdU17cBzivFm9q-VwF9EG5MX75Qct=is=F2h+Kc+VddZ4g@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <CAMuHMdU17cBzivFm9q-VwF9EG5MX75Qct=is=F2h+Kc+VddZ4g@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ivo1wHeq5JAa6C6utzDOSxsdL66cT2qCqkvqHYZ72sLzx6cAk3VvURBLypuY?=
 =?us-ascii?Q?uqz3cBrbH8ooWa7+sDwKJWwpnWzRnaPMJpCYkz6NBqOJaFCleUdKe8Wq5IUj?=
 =?us-ascii?Q?P794xTKMdyfK3aXza0/1akucDByHX+f7ykSPpluoRvAV+okDZZnTF2WG9eqI?=
 =?us-ascii?Q?ZT0P25eNRhbIHptn8oSzrTCF2s+O8p/VKZLiaRwTd1/etjY83kPYBc9CVqAG?=
 =?us-ascii?Q?Zspp395/gZ7RxZmH8cQqyQxCllSXSY6Bpx6S+/9GRiCP2sgSoJMgpsAugjkj?=
 =?us-ascii?Q?Qh12ZyAlUAOp4z4z0g9s1XpOQmHuDlWO8KA58oycLb8f+1U+H/SZ+d4loLIt?=
 =?us-ascii?Q?KpMciz4fvhjuuG+31EnayIhuKaF5vew1umDplkHuAxbnCY6bdEcKjXYIS7/R?=
 =?us-ascii?Q?v9igS1a7Lmn8H0WDonAE5p9KKhXq7wgKqOPgoWzNpOu37oL5P0ySVwc9gohG?=
 =?us-ascii?Q?ocuhtdT237qxtg8MYgKdeSIl5CLdmCwdbw2LApTU7H/jAVc1VjThQcryvWx7?=
 =?us-ascii?Q?4l/FK9PsjKn/GE942fXiXv1Stq+6+L33sC0s596hj/R/TJKRBf+2FugW0VuQ?=
 =?us-ascii?Q?4Ayan03BYvtVj+fUpYBYxHkkbIUrFCBlYvYjKMyxy7gAKWIGN/nMAz2nr9/d?=
 =?us-ascii?Q?evOw8UHO9lFJxCSBS9XofolzJZNbCeD4FzMpekr4yCT+3fbqYL5bFUqR6JbU?=
 =?us-ascii?Q?Rfug0KxiX8GbGkJmxnhhPrLV0jcVbbhEQ8u6polnk0oFWo5FcKyf7U+6HHkV?=
 =?us-ascii?Q?Hm3A7mXfbnltvSqbLmyBC1Jy9GWwMbSIU31YumwlO5MXweRTyOC9XLKuIYF/?=
 =?us-ascii?Q?z2DWeuUXUXQGMg57uytEF/uojJe0Tl/aRTViaNiJCyizYPxBtw54ZdPyw2qn?=
 =?us-ascii?Q?+uYstvkXjB155AspUbI/ltKW5gHs8T4g8pBsCQEN//RwoT6hog/5V0ZqiQoG?=
 =?us-ascii?Q?I6VchMx4dRoD6bhmZLa0J1i3CJZHj6Fh38sSw/uqkntDhNDjCmQzvyS09yi7?=
 =?us-ascii?Q?d/4AmW+iSEtkMbqLVBSQwDQXgF3I9knxg/94R4pyze+3G3+kGv7M760hV5qu?=
 =?us-ascii?Q?6nAzpf+4qCwgeXasdsv+z6Liz/r6TnRp94eQf1beNT8XcoBKioW+MUsWRiQy?=
 =?us-ascii?Q?xU27TJfX9oaHrqrnkI6dXgeSZfkASaAxAOcd+IyHDo5l42yuMCy2pkgPV/J9?=
 =?us-ascii?Q?ZhaUvP9d48+1tLN4cjAY4/b+CFbl88od8eIqS7Byq2EX/b06tyZ1SGcYL774?=
 =?us-ascii?Q?Wuj97yb7QKj9ikgqyctF9U5VNLwSkx8JoX46Luv+yic25C3yOV9O6tpEit6c?=
 =?us-ascii?Q?CUG1fHLrUTpmkR+nx9Y0zxZaFrC74ew8Z0rW/hnXfAXBVpvu0NBgTNL8lqj5?=
 =?us-ascii?Q?pTYWi+BFcZp68uD40N7krCWlVbFbq4apbO8dg9YWOGJinIIqq1nQg5RXkAmA?=
 =?us-ascii?Q?X3/2MJOfslK/Rzz6Hkwpj2Ej4IqVc+hWGPxTia4Y7MLb7hR82OtpBBMZ0mKr?=
 =?us-ascii?Q?XTgO8igu6ARA4IKYCAfkIG08X1tCc9IJOFxKJN5wC18D7O83tzjzjmlAcBqQ?=
 =?us-ascii?Q?Tj8+Vc4lUqCY1TTpwjvK5l+fB228RKX9smIsJ1V8Fq2WNjOgtJbEOGQYPgQH?=
 =?us-ascii?Q?gO3YrXEtpQU6mw7RqKokUNg=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0377cf89-0b6d-444e-004f-08d9e4e87bce
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4209.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2022 18:35:41.5122
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HbhP/vrOeyqyR6IsOZJx2nhyCU9T75DcHbkng7KgEgvDY2P1vUry8vRkyUtnrqA9TNsGL5FkQxCHIJnJ+mmGLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2970
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 31 Jan 19:30, Geert Uytterhoeven wrote:
>On Mon, Jan 31, 2022 at 6:59 PM Stephen Hemminger
><stephen@networkplumber.org> wrote:
>> On Mon, 31 Jan 2022 09:24:50 -0800
>> Saeed Mahameed <saeed@kernel.org> wrote:
>>
>> > From: Saeed Mahameed <saeedm@nvidia.com>
>> >
>> > NET_VENDOR_XYZ were defaulted to 'y' for no technical reason.
>> >
>> > Since all drivers belonging to a vendor are supposed to default to 'n',
>> > defaulting all vendors to 'n' shouldn't be an issue, and aligns well
>> > with the 'no new drivers' by default mentality.
>> >
>> > Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
>>
>> This was done back when vendors were introduced in the network drivers tree.
>> The default of Y allowed older configurations to just work.
>
>And changing the defaults means all defconfigs must be updated first,
>else the user's configs will end up without drivers needed.
>

As I understand correctly, at least for most common net drivers, 
having NET_VENDOR_XYZ=y doesn't actually build anything, we have flags per
module for each vendor and those are defaulted to N.

>> So there was a reason, not sure if it matters anymore.
>> But it seems like useless repainting to change it now.
>
>It might make sense to tune some of the defaults (i.e. change to
>"default y if ARCH_*") for drivers with clear platform dependencies.
>

either set hard default to 'n' or just keep it as is, anything else is just
more confusion.

>Gr{oetje,eeting}s,
>
>                        Geert
>
>--
>Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
>In personal conversations with technical people, I call myself a hacker. But
>when I'm talking to journalists I just say "programmer" or something like that.
>                                -- Linus Torvalds