Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
CC:     "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Russell King <linux@armlinux.org.uk>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Lee Jones <lee.jones@linaro.org>,
        "katie.morris@in-advantage.com" <katie.morris@in-advantage.com>
Subject: Re: [RFC v6 net-next 8/9] net: dsa: felix: add configurable device
 quirks
Thread-Topic: [RFC v6 net-next 8/9] net: dsa: felix: add configurable device
 quirks
Thread-Index: AQHYFVv1JbeGvfMOAkqmHy+3zuj7iKx9ck8A
Date:   Mon, 31 Jan 2022 18:15:25 +0000
Message-ID: <20220131181524.zgbsbrq4yzukw2ir@skbuf>
References: <20220129220221.2823127-1-colin.foster@in-advantage.com>
 <20220129220221.2823127-9-colin.foster@in-advantage.com>
In-Reply-To: <20220129220221.2823127-9-colin.foster@in-advantage.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GJTYjbMol978Fs1ySHaGYDJk9ETQk2PnBfk/cwFqnPgRsA+fjZGCnvKc0irZ?=
 =?us-ascii?Q?evO4eTi8qBIboN0yBTYStfN+Ekdm23COiO3pHh4EA6pNIFp+acvGW3nDJGUK?=
 =?us-ascii?Q?osOebKsSkqp+3mwGMqMRI0xj/NobZ+J13eJJ6gFxrS40q0rz78xynZNTHgCd?=
 =?us-ascii?Q?HE8QEauneNpOaiiBPPP8uSseg+w66QDsfYAHgLfIIXAd91b0+wdESyYsB+jh?=
 =?us-ascii?Q?SV8lpZ05G0FgFuobFu/6o3Gm52WIXSQTG1KqQ/8wIEZu46oA0oitXG5V8NaF?=
 =?us-ascii?Q?Yd1xLmknD8n7JQK2sDHd0Je90C/QsF7KauDOKeeGhkZpB44hABoxLLR79pO9?=
 =?us-ascii?Q?CBI2AVl7eSjSeON86yS5HilrVDlndKY+ffZ07Iq2Fx4r5ixTSo6/1xDL8IHG?=
 =?us-ascii?Q?xafeo/nRMSj26uca/FRkKVYpOuWz2bTiE5uG1iT/NQ+i8W6+yi6TYm3ORW2U?=
 =?us-ascii?Q?1OPcaWOMc84oOKTDtoUdEGJNkYORnYBWGNyNjw36x+uUFAuy/um8z5DT8xHx?=
 =?us-ascii?Q?QDNLBicqbq0NmLFFoeKBeofRq9Pc+jcunxKVfmfyw4ShCy8Kpo+trdJo3pnC?=
 =?us-ascii?Q?9EoReGVlSNR5nalqdG0YL2oEGmpv4l6QriTCaG6RCQHCHn681M1Z7o85nvpY?=
 =?us-ascii?Q?UCeZJ+F7xG5F770dE6n4CYMTqBis5Wiy61QRDegKOCcap/S6Ib1EXZ6nASwY?=
 =?us-ascii?Q?u5Kp0c46fyKBpORs1IF84b7wPKTcT+n6ccZsCZ2LlvpD9SjkqETo0sdPqFwV?=
 =?us-ascii?Q?iu8U5lq/jdkuSuyM8uHakgA5z9PKANMRa8NhtKZnXI3IuQUDz+lZh+yEIp1U?=
 =?us-ascii?Q?QsvLPpU5TePU99ziGed3TyZBPvLVy5ghTJevRR3q36qvDFSVSQFiD/ij+84Q?=
 =?us-ascii?Q?5JfjP0/WiAocPp0tCvI4BOGWmV+4Mu6JydETXRKDTYYN+NrlyyR9GKFN9sml?=
 =?us-ascii?Q?nvdp7N8QKCpkmzPT3nr9Qd3VMJ3U7r35EsZ26e6gfc6yltBNIayuMjd94bhU?=
 =?us-ascii?Q?hDpv+8q15fryl8xwknHH+JhyVMdZpM3FQ16k2gIUOno3u7t2xUKcLi3g1hDT?=
 =?us-ascii?Q?y5g3ynodsVSweIrwixxZX9jnnwUS9L5KF5kGlegBwxMV0IJpMAdCtnNtsx3A?=
 =?us-ascii?Q?EqSn1CqCJ+pqJKBWfShcsVNKLfzbVwtUyUzc36NtE2R7vKcIxHLy5FrVyZaR?=
 =?us-ascii?Q?3+6pl3k5VkLvGnMssl87pRUQK1peBo2UdVAWqTGvSNQ3ZzyT8c6Y+GrgeM+c?=
 =?us-ascii?Q?c5jTvP+2cZNyO+VHbsck+bfhz6kbvSitit/XB5rwJEq87kiENscQnQrwMaO+?=
 =?us-ascii?Q?Yz6U3Gf6y1wcD7HEXedD2AAllnUG2myoP2iZGLFKfOPnEQCwRHFoOCtJFBJD?=
 =?us-ascii?Q?WkIa7Yn88CFtWFLD5zvU0oNvzuqxpF3H1vvzQZzqIHI439M9leCbTV7NjDF3?=
 =?us-ascii?Q?GWT14MglAFnljbhEVGf7ylIbu2M1+LwmjIrMw97sO0WfXeflj1tjV0MDKLzG?=
 =?us-ascii?Q?m3p93w8vmWHK+vktcePtZeq/8oDBCTtD1qBTmlY+mYJa7DQMXxzEyhr7xQYZ?=
 =?us-ascii?Q?tPFB56meISU3znhadyJFO2H/Xoo1ePEQm2wvhUMYeC9nLI+gEKA/GUIdHbwj?=
 =?us-ascii?Q?vRRReVDRAcbjCQuIxitO4Rk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <28EFC784406F7E43884737E4097A9D9C@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 705f6eeb-64ce-461e-cd78-08d9e4e5a787
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2022 18:15:25.7568
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RkHOeSpOn3K7P0iDFnWF4Vbzn2XTAyzlqIPz+QGDYmpxYx6C07/LV0qDUmTl6NEm510ZtfyN7jcxGr7Hm0HB8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6690
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jan 29, 2022 at 02:02:20PM -0800, Colin Foster wrote:
> The define FELIX_MAC_QUIRKS was used directly in the felix.c shared drive=
r.
> Other devices (VSC7512 for example) don't require the same quirks, so the=
y
> need to be configured on a per-device basis.
>=20
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Just one small comment.

> diff --git a/drivers/net/dsa/ocelot/felix.h b/drivers/net/dsa/ocelot/feli=
x.h
> index 9395ac119d33..f35894b06ce5 100644
> --- a/drivers/net/dsa/ocelot/felix.h
> +++ b/drivers/net/dsa/ocelot/felix.h
> @@ -26,6 +26,7 @@ struct felix_info {
>  	u16				vcap_pol_base2;
>  	u16				vcap_pol_max2;
>  	const struct ptp_clock_info	*ptp_caps;
> +	u32				quirks;

It's an "unsigned long" when passed to ocelot_phylink_mac_link_{up,down},
so please keep it the same here.=