Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <6502adba-c91b-cafa-35a5-635636b31075@intel.com>
Date:   Mon, 31 Jan 2022 20:17:33 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.5.1
Subject: Re: [PATCH] acpi: require CRC32 to build
Content-Language: en-US
To:     Guenter Roeck <linux@roeck-us.net>,
        Randy Dunlap <rdunlap@infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-next@vger.kernel.org>
CC:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Linus Torvalds <torvalds@linux-foundation.org>
References: <20220130223818.16985-1-rdunlap@infradead.org>
 <f153d3dc-f4c1-9c4b-aac3-da3a696a3313@roeck-us.net>
From:   "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Organization: Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego
 173, 80-298 Gdansk
In-Reply-To: <f153d3dc-f4c1-9c4b-aac3-da3a696a3313@roeck-us.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VjVDZ04zUC90TWdIVEEzRHRZRk1LbzFWYkdYRXFkckhIOHJtTi9yRG1ac3Ji?=
 =?utf-8?B?bi90RnFSMVhyREN0RDBvUmJBalhybmQrM2V1a2dhaEI3TlluOEpJejhydFVE?=
 =?utf-8?B?ZmcxUGtBY2JUbnRBSGdlQk9VeXFVNEdrdThPSjJHQVV3V1VXWGhoTi9PcU1X?=
 =?utf-8?B?U0ozYTIxa3F1eTlFVVByTDNMUm9XdFp1TlBGWGhvaVVFWDhtb0FONFVzK1E2?=
 =?utf-8?B?dTJtUlpVY3Nwb2NKL1lZM2RIUGlaQml1c2hoV0tHK0lNUGF5eEJuQUpxdmVC?=
 =?utf-8?B?RmUvV3ROZGora1o3VDVhT2lDWEVyUy9abHlmaWJBblhvaVRnSlcvQWw4YUdt?=
 =?utf-8?B?NGRuaDVEREFvQ0pPM1duQllOK1B6RXdmK0l6VVViUWUvT0VlRkN2KzlJVW41?=
 =?utf-8?B?RlZaT012b2d5czM1KzR1QndGUUx3UXRJWFBNRXc1Z2RUUDdCVEhxclY0VXdT?=
 =?utf-8?B?eE5sd1RuTWpQelhVQUNTZHAzZ2lDM0J5VmVITVJmeE9BU0l0T2xRVHlDcFBF?=
 =?utf-8?B?a2hOWEhkTWVSYkRHZUZBQnZKdk9Ua2FLWGwxUmdhYnhGSmt4U2pJRmt6anRs?=
 =?utf-8?B?cGRhMUh0Mms0M2NINUQyODBMcU5wMVNSMW5UKzQvZVFkeVZyVlVJMkhEaFM0?=
 =?utf-8?B?K0RUVEg2bXg0NlNMRkJycHFwYW4vSk1YTHBZay8zT1QvRit4K0R3YTRUbm5T?=
 =?utf-8?B?UVhxYWhGSHNFNXBDY3BTSFRpQWwzdHJMSCtadEJUY3BJVkhjQjhDajJjelEx?=
 =?utf-8?B?UWlBNGhBclpzRURkbXdOaW8wNG1HMXJFYXBzOU5Fbzl1b2RBcXBLeVEycS9J?=
 =?utf-8?B?RkdZalVHanFmMjdzbGh4UkRzeXR0eTFhdmlPZTNXNVVWZXh0VWJja2IyNXVJ?=
 =?utf-8?B?Tm1oMzlYWkNYck1waG8vWUNCSlVTWG84bGdRWVlzazVsc1VpdG1zSWRuNVV3?=
 =?utf-8?B?M29CalFhY2xpdTRzSEd2QU51RXBOaDNmNnhDb0FURjdFV091TkNzVU80OThu?=
 =?utf-8?B?YXNJSkpzYnZxY1pnU0xJc2J4aGVSb25JNjh1UytxUlRrSmlkSVEzaEZOSVZY?=
 =?utf-8?B?aXJLZTlKRmdNbis4cjdnbXd5Uk44U0lJYUFoWWRRTzY4cVpQdWtjd1Q0Y3U0?=
 =?utf-8?B?Ymx2b3NqeEtyZGdveWRIMk1VWDhUcG1sSFBoT1ZaSzIyVlBYWlR6UWMwa0Rs?=
 =?utf-8?B?R1NJaFRYVFJCZS9laGpRYXF4R0UxN0Rld2JzMGNiYWdDYkRROG5HTzhKb1NG?=
 =?utf-8?B?L1JUM3AwNlQyRHcxRi9BWjA5ZWt2QXY4b3ljWHVmR25QMUVKUUNJZ2t2WmtQ?=
 =?utf-8?B?Tnl0TXk4MGhWbzRDVEVCTzlwczN4cXVkWEZxVXlFdzB3ZGdPVi85ejFMZ0dO?=
 =?utf-8?B?TDE3My9HUmJQNlJKYnVQNU4wY2N6dnJVakttempVbWwvMWRBM0t6ZndpalVO?=
 =?utf-8?B?aThwV2t4bk5kNHB3WkxCM2pVMUhsdDFTbEdEMDNKVFRxNGNZTVBITVNEWmJS?=
 =?utf-8?B?MjkyTytWeVZ2QURsRHR5OVBCWWxoa056dG9uOU5YTm9FckZKaFZER0hxd1Ar?=
 =?utf-8?B?b2YxdWNNRzU5ZXE2R2RCRlN6R1hqV1YyRCtnR2luUlNSRHVlei9EeHA5UHZj?=
 =?utf-8?B?M1l1dm51bDZ6blZtd2dpbzJ6b0svY21pUzNMek9YNHBOZzRGc3BheUpVTXBi?=
 =?utf-8?B?eXNONThRM3R5RURTUDJlVzhkSWdOaW4yNjNmMm9GZmVCYkhnTjFHdjhxaFRo?=
 =?utf-8?B?aldrVWZZYlRWNEg2eFVCaGJHMkxoWHN4aU9qa0E3Y0s2OSs2WnVpT3kwaE92?=
 =?utf-8?B?ZGpzSnBpUmZ5dklDMkpOL2Y4RzhXZGx0Nm8waDcrRGxZc3BLZEtPM1dVWER6?=
 =?utf-8?B?NVlUR3lOWVJUbHZ4RVJNSnlqSkZkdUozRUdObCtrQUtIZ0pnd2h0Mmg4QUlQ?=
 =?utf-8?B?aUtqTlZkcWozVSt2QWRCdEFLTXV2U08xWERtZkxqQnRuN2lYTGFLSzdTUlNU?=
 =?utf-8?B?NktiNEsyM1BSWEtxWEJ2Y3dkbHJLTTgwZ3g2eHNlTlJKYnQ2QTYrMkdNYXhF?=
 =?utf-8?B?bnRMSUZIa3ZPRU5QNkw0RnZ4MmpUM2V2TUNxeFk2M1VuSXNxWGFxaTdTNmdo?=
 =?utf-8?B?dTh5ZEFsVkw3cXBEaWIxR0VIektrNHAwWERNdElLM0pDMDJ0MnlDbE0xcHhZ?=
 =?utf-8?B?U0xBdDE1TlFSdTJxMXZZRWZWdHU3L3FVdEh0NXQyMDlPQmNBSnAwOVc0ck1k?=
 =?utf-8?Q?tldAYrJGmjE4387KRBX3Cz1VtpC4ubIzUNz9VKtZs0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a1dbb6ed-9e89-4685-64fc-08d9e4ee594b
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5810.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2022 19:17:40.3910
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OYvYdHLXRiyQSk1IQbG2TYe+LIk512SPU+fnvGFDIuREnLAjkjqMnP2TolYzVAwFanC1dImSDLjK6ahADMIva5T+LPVZH97wGUNrIyPPtjI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3846
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/30/2022 11:58 PM, Guenter Roeck wrote:
> On 1/30/22 14:38, Randy Dunlap wrote:
>> ACPI core now requires crc32() but the kernel build can fail when
>> CRC32 is not set/enabled, so select it in the ACPI Kconfig entry.
>>
>> Fixes this build error:
>>
>> ia64-linux-ld: drivers/acpi/scan.o: in function `acpi_store_pld_crc':
>> include/acpi/platform/aclinuxex.h:62: undefined reference to `crc32_le'
>>
>> Fixes: 882c982dada4 ("acpi: Store CRC-32 hash of the _PLD in struct 
>> acpi_device")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Reported-by: Guenter Roeck <linux@roeck-us.net>
>> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>> Cc: Linus Torvalds <torvalds@linux-foundation.org>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> Tested-by: Guenter Roeck <linux@roeck-us.net>
>
Applied as 5.17-rc material, thanks!


>> ---
>>   drivers/acpi/Kconfig |    1 +
>>   1 file changed, 1 insertion(+)
>>
>> --- linux-next-20220128.orig/drivers/acpi/Kconfig
>> +++ linux-next-20220128/drivers/acpi/Kconfig
>> @@ -11,6 +11,7 @@ menuconfig ACPI
>>       depends on ARCH_SUPPORTS_ACPI
>>       select PNP
>>       select NLS
>> +    select CRC32
>>       default y if X86
>>       help
>>         Advanced Configuration and Power Interface (ACPI) support for
>