Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp902525pxb; Tue, 1 Feb 2022 12:48:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJzvybB8qL32dfq9NQ5irTSiPMQHq48m156Huc1onRLcE0fWY5SOdK6MWk2AaAGUPxsNQvxS X-Received: by 2002:a63:5f48:: with SMTP id t69mr21904934pgb.98.1643748531986; Tue, 01 Feb 2022 12:48:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643748531; cv=none; d=google.com; s=arc-20160816; b=CTtrZKYZ7LePozZgKxXgQhNgUM+OjKMmhtPilY9GGxBG8A+CZnFDX1kR2vbusXNhQG 4L1f1Q0P2gP/IVh3vVClLhH03EM5h/8QJCM0gmCAPAebT+GmG8rTeDlhF3fMaCr+/gZg FDE3kKz11WZGtBunmP8XsCEvh3W0LrmHVBq3uCy1ekPOoYNMNdg6KJ80ZGsD2QNCKG0F 1Qz6VXiwA26TH8svEgS+nhG9RtuPVPwHv9zI5kRNF92xwhjGRDROYoBe1lf7yvKySCdf UAXqrRfDa1niMs23wFw9u7jQi6hSqyyvPQnAPjt5dRYJTxJqeY+aE/m2FPFwPX2ZFMSg L3DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:mime-version:user-agent:message-id :in-reply-to:date:references:cc:to:from; bh=eGRqLmbv+Iasx/grQaXh2qii/dguiV5hpIN0c6VXoeY=; b=dAaZSBx/Ur8Ppto9hh5vPBAOrsK8y7aeNXnR67CC2XWUzsdN4K5c8hcMkP9RIaYRV9 CsHbzbNhrbpnmY/DELVKIGq6qdCMncHzwdG+k4pKiS3vAFwFVNf+UrZVL2rQPe8aSMgK TIF2iB7T7kwJlWDySEEXCkOD/Ftk7io9UB5fNZAlZKDFwYozFjC+yV6o1DY9FK62iNPa 3E+HIjJaj8B36BDqcZ3RWOMGHJj5V3s1spQfwxQ0WsnL5xMvLsQnDucisjt57KwnDKC4 KJ3p+PMQ9BIxx/5YBaiOIirtp4N1dwFMHycrqkv0nFWqLqx2WeTA6faBFjyjWS0Le5LX GWsw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 9si16573131plj.340.2022.02.01.12.48.39; Tue, 01 Feb 2022 12:48:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357442AbiAaSpj (ORCPT + 99 others); Mon, 31 Jan 2022 13:45:39 -0500 Received: from out02.mta.xmission.com ([166.70.13.232]:58930 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357451AbiAaSpb (ORCPT ); Mon, 31 Jan 2022 13:45:31 -0500 Received: from in01.mta.xmission.com ([166.70.13.51]:43508) by out02.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1nEbg7-00HX5m-Ap; Mon, 31 Jan 2022 11:45:27 -0700 Received: from ip68-110-24-146.om.om.cox.net ([68.110.24.146]:56304 helo=email.froward.int.ebiederm.org.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1nEbg6-00ExG7-Ey; Mon, 31 Jan 2022 11:45:26 -0700 From: "Eric W. Biederman" To: Jann Horn Cc: Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Viro , Denys Vlasenko , Kees Cook , Vlastimil Babka , "Liam R . Howlett" References: <20220131153740.2396974-1-willy@infradead.org> <871r0nriy4.fsf@email.froward.int.ebiederm.org> <877dafq3bw.fsf@email.froward.int.ebiederm.org> Date: Mon, 31 Jan 2022 12:44:53 -0600 In-Reply-To: (Jann Horn's message of "Mon, 31 Jan 2022 18:13:42 +0100") Message-ID: <87bkzroica.fsf_-_@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1nEbg6-00ExG7-Ey;;;mid=<87bkzroica.fsf_-_@email.froward.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.110.24.146;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX19oFCEDmwWeui1ca5Jl0D8bAX1MI6wleEw= X-SA-Exim-Connect-IP: 68.110.24.146 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa04.xmission.com X-Spam-Level: * X-Spam-Status: No, score=1.3 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TooManySym_01,XMNoVowels autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4984] * 1.5 XMNoVowels Alpha-numberic number with no vowels * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa04 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa04 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *;Jann Horn X-Spam-Relay-Country: X-Spam-Timing: total 312 ms - load_scoreonly_sql: 0.09 (0.0%), signal_user_changed: 11 (3.4%), b_tie_ro: 9 (2.9%), parse: 0.96 (0.3%), extract_message_metadata: 2.7 (0.9%), get_uri_detail_list: 0.56 (0.2%), tests_pri_-1000: 3.7 (1.2%), tests_pri_-950: 1.14 (0.4%), tests_pri_-900: 0.91 (0.3%), tests_pri_-90: 84 (26.9%), check_bayes: 82 (26.3%), b_tokenize: 4.3 (1.4%), b_tok_get_all: 6 (1.8%), b_comp_prob: 1.67 (0.5%), b_tok_touch_all: 67 (21.4%), b_finish: 1.25 (0.4%), tests_pri_0: 178 (57.1%), check_dkim_signature: 0.90 (0.3%), check_dkim_adsp: 3.6 (1.1%), poll_dns_idle: 0.91 (0.3%), tests_pri_10: 2.9 (0.9%), tests_pri_500: 20 (6.3%), rewrite_mail: 0.00 (0.0%) Subject: [PATCH 0/5] Fix fill_files_note X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matthew Wilcox has reported that a missing mmap_lock in file_files_note, which could cause trouble. Refactor the code and clean it up so that the vma snapshot makes it to fill_files_note, and then use the vma snapshot in fill_files_note. Folks please review this as this looks correct to me but I haven't done anything beyond compile testing this yet. Eric W. Biederman (5): coredump: Move definition of struct coredump_params into coredump.h coredump: Snapshot the vmas in do_coredump coredump: Remove the WARN_ON in dump_vma_snapshot coredump/elf: Pass coredump_params into fill_note_info coredump: Use the vma snapshot in fill_files_note fs/binfmt_elf.c | 61 ++++++++++++++++++++++-------------------------- fs/binfmt_elf_fdpic.c | 18 +++++--------- fs/coredump.c | 55 +++++++++++++++++++++++++++++-------------- include/linux/binfmts.h | 13 +---------- include/linux/coredump.h | 20 ++++++++++++---- 5 files changed, 88 insertions(+), 79 deletions(-) Eric