Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     Colin Foster <colin.foster@in-advantage.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v4 net-next 0/2] use bulk reads for ocelot statistics
Thread-Topic: [PATCH v4 net-next 0/2] use bulk reads for ocelot statistics
Thread-Index: AQHYFIJ8ACyf1j3JaEubMb+rEidhLqx9kDeAgAACtwA=
Date:   Mon, 31 Jan 2022 20:06:05 +0000
Message-ID: <20220131200604.orl7da2oyljh626c@skbuf>
References: <20220128200549.1634446-1-colin.foster@in-advantage.com>
 <20220131115621.50296adf@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20220131115621.50296adf@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jRlLcHQ70YyEteVnlnZPLy4DpMqghzAYDgbKykTQ4WdFKsNXZwqiJbc7+sqp?=
 =?us-ascii?Q?yBLON7lMG/0eId9Yzd8SqdHzhRm5ImC3Xoi9ncy2Lk0cprIrXk3+B5Z1whDF?=
 =?us-ascii?Q?tcThxf3muNUm8oxFVYgumUeuoXVgvtAXOlQzk0kmveKWgnu/VtaCZv3Pb/zw?=
 =?us-ascii?Q?HDmk2v5tAUAMO4xzNSLpNSygHlskDc5Msp4VKExd8fBw/SJNKBsElH+7EIaj?=
 =?us-ascii?Q?L5I6HaawbfoSCoxDvGo6gUK2N/Ez60hKdJroa6NrtEQG7ymshDIGACFnCgsM?=
 =?us-ascii?Q?beB9J0yPXJkDN1xo3rD392Th0H6gA2iIf8Z625m6l7XIipMFeGUgSV54MLP8?=
 =?us-ascii?Q?vSfaGAHCxSLWhSlrq+4D6zLvY73AXMbvG7zI2qoHt2TKSDgx0nyiFbSCFx5x?=
 =?us-ascii?Q?VFrbNsj48rYdSRG3ck7rgD1edSh0kVTCrcakuhpwjfExLw6OZbVO2e6v5ux3?=
 =?us-ascii?Q?9dRzjIcr9URjXYGHf/OuHkvC8dhHUTWVgvPY5E8zj0lK/MOMnDyu23dC8M4D?=
 =?us-ascii?Q?3/3V08g1s1S4YVPdK34eR5vSJqJZXoxOsHLZUhCUVU8G+xhLG2oaGDrx/66i?=
 =?us-ascii?Q?4Zscn38WTRikXlLEVOCqzILHcADT/fDj/nSYqwpn5X8XPNDxEx4wjVl5uSCj?=
 =?us-ascii?Q?kCfi4entySbRPVgnrfE21WH5aBmyCA4iW4yyvSZFdjLB4Nxb53MTRhI2TWg8?=
 =?us-ascii?Q?W8OvYTP2mjlxYa9ZV7GD4An6m4uDbaMcUPk+55vW/3KGL1BoD4nzSuBSTRMV?=
 =?us-ascii?Q?TN1nVzUc4CIyWLBCSADxD19UUZcay08Ynm9gtAvrqEX9EqKd8+WQn5V8cZif?=
 =?us-ascii?Q?/2feVMM5ZHBNEl6++4/EEefU/B4Mecrp1oAybojqimseiZ8Dg+i4H2xCiRk9?=
 =?us-ascii?Q?uXZ9pMLSdZ7RZ7oxWX2Jno6q86uIBxUY5wZsyKq97b5t7SyYpFG0lFl0vrYs?=
 =?us-ascii?Q?iZnDw1iwlF+zmDzHa/gtPGjAs/NQ5wyICJARlUQz56Rbmh4rA3qAkvJl+60n?=
 =?us-ascii?Q?yqSHcX1KIyLrkdeymQq3Dkrpz5T02KVlQNXm36VH95xNlfgbJdd/EdQGg+j0?=
 =?us-ascii?Q?HIyv7EHEwAByFGLAzoO+mEY3RdoVm1MKFoixWFlCf/1q30qYW6u0XEESWb3d?=
 =?us-ascii?Q?/O87QjT+XPKQoojqt87hgis+XaUEC6OqGK7/lPegR14aoE6qaYXnJMU/lAT3?=
 =?us-ascii?Q?pjhSkzrakMWONkuoBbL0IbjLurr/Lr2ZLxCe+8IJyNeIAY4mIc/aBlBpHs2P?=
 =?us-ascii?Q?Y5vD8JwR5qTLm/4vxwAQ6Yji/lBsWUCF+Wq50jNYVwCcNhsGaKypa2YzXT46?=
 =?us-ascii?Q?EeEkKRZKWP2XvfKobyy/zuGOTAfzUEs6+16cdKeztW7hqPlgjsCpm4Jk8PDC?=
 =?us-ascii?Q?9X0bO7QX2dbDE8sgX4h9PHMfrjp7hHYT+0SIdYfpdxJTf3sw7FxXzQtvoV5F?=
 =?us-ascii?Q?PqVrSYUVZtGPMUEoSc3bF9CtCMgGLllMKV/jt9RjZhJYYTzb4JHlvgLbnEsJ?=
 =?us-ascii?Q?RHaaNpu/lc92CJIJj64AiDHr/aUymw7MQ++zOTLo3TLmcKaH3/qlsj+s8Fsl?=
 =?us-ascii?Q?SfLOKHgmL4rv1g5T5dT83jjctXpdkQz5kTzI8xLb42ghktJaN6AayqAiQdrb?=
 =?us-ascii?Q?xu/EizyQMYoknbTsnMeSbNI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <933FB3B4C9FF0C4CB60B42316FC2FF73@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 84f88152-6ea4-4b10-ce2f-08d9e4f51d20
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2022 20:06:05.5195
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Ffxb5K0dCRtCB2YZ/gIyxkvMg5rrgjnmq5+EzA9/XbGIsS3U1v3YL+nyge4O2WBO968H3rv7tfvIIZn5DIG3QA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6977
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 31, 2022 at 11:56:21AM -0800, Jakub Kicinski wrote:
> On Fri, 28 Jan 2022 12:05:47 -0800 Colin Foster wrote:
> > Ocelot loops over memory regions to gather stats on different ports.
> > These regions are mostly continuous, and are ordered. This patch set
> > uses that information to break the stats reads into regions that can ge=
t
> > read in bulk.
> >=20
> > The motiviation is for general cleanup, but also for SPI. Performing tw=
o
> > back-to-back reads on a SPI bus require toggling the CS line, holding,
> > re-toggling the CS line, sending 3 address bytes, sending N padding
> > bytes, then actually performing the read. Bulk reads could reduce almos=
t
> > all of that overhead, but require that the reads are performed via
> > regmap_bulk_read.
>=20
> This got into Changes Requested state in patchwork, I'm not sure why.
>=20
> I revived it and will apply it by the end of the day PST if nobody
> raises comments.

Maybe this is the reason?
https://patchwork.kernel.org/project/netdevbpf/patch/20220125071531.1181948=
-3-colin.foster@in-advantage.com/#24717872=