Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946265AbXBIKPe (ORCPT ); Fri, 9 Feb 2007 05:15:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1946304AbXBIKPe (ORCPT ); Fri, 9 Feb 2007 05:15:34 -0500 Received: from smtp.osdl.org ([65.172.181.24]:41488 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946265AbXBIKPd (ORCPT ); Fri, 9 Feb 2007 05:15:33 -0500 Date: Fri, 9 Feb 2007 02:14:44 -0800 From: Andrew Morton To: Jiri Kosina Cc: "Ananiev, Leonid I" , linux-kernel@vger.kernel.org, linux-aio , Zach Brown , suparna@in.ibm.com, Chris Mason , Badari Pulavarty , Jan Kara Subject: Re: [PATCH] aio: fix kernel bug when page is temporally busy Message-Id: <20070209021444.2213deb6.akpm@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 713 Lines: 18 On Fri, 9 Feb 2007 10:54:36 +0100 (CET) Jiri Kosina wrote: > @@ -1204,7 +1204,7 @@ generic_file_aio_read(struct kiocb *iocb, const struct iovec *iov, > do_generic_file_read(filp,ppos,&desc,file_read_actor); > retval += desc.written; > if (desc.error) { > - retval = retval ?: desc.error; > + retval = desc.error; > break; > } Nope. On error the read() syscall must return the number of bytes which were successfully read. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/