Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <a525220e-86cf-e9d7-116b-fe988a59239e@oracle.com>
Date:   Mon, 31 Jan 2022 17:06:50 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] userfaultfd/selftests: use swap() to make code cleaner
Content-Language: en-US
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     cgel.zte@gmail.com, akpm@linux-foundation.org
Cc:     shuah@kernel.org, linux-mm@kvack.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        Changcheng Deng <deng.changcheng@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
References: <20211028112331.16152-1-deng.changcheng@zte.com.cn>
 <beff2e58-cc75-7c91-543c-ed35b8939470@oracle.com>
In-Reply-To: <beff2e58-cc75-7c91-543c-ed35b8939470@oracle.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djBSTm5NYzkvcndKZVpPNTRSNDNVek1udlpsanpSdld6Vk9FV3NyQnNrYXZD?=
 =?utf-8?B?d2tvWUJMVzZ2YTVsN05hemhhTk5BYkEvWmJPbEU5aGFkclVLSDNrSk9EMW1l?=
 =?utf-8?B?YmV0UW1wemNUdG9mNG1WM0xJcjBNZmJCVm9hM2VNUU11d0o3QUNPYWdselRm?=
 =?utf-8?B?elRvYUl0bWZNTUVkTmtqVUp5TVE1c3NqbW1OTlBIeGFweGhmS0NyUS9mVWdv?=
 =?utf-8?B?eGRmSjI1SW1oblVNb3ZNaENBQlhGQ05TZVB6VUd3Skw2bjFrRkZjTjFnVVpm?=
 =?utf-8?B?dU03MHhnK2dSbmd3SFk5WFhyVytFczFOa2o4ZnhHSUlMS3p0S2dtdUgraTlu?=
 =?utf-8?B?NG5zS0I2S0FEVjN6Nzc2ZWExdVk1YnJFZXhDdnlYLzdWNWlMMU82SnczR25N?=
 =?utf-8?B?M1JOelUvcmVkWml1Tzl2RW4vWk12UUZSKzZHRHB5QWtyRGN0aVB6QzJLZGo5?=
 =?utf-8?B?WG1KV1lnSVBDbmFpb0oxK2gwMnl5Z2o3NUIzemFmS3Fyem1OSXRtanh4ck91?=
 =?utf-8?B?ekVWbzFqelFqaHUraGlTYWY4VVhnSXB6eHFpVFpJNlRXekpaWEpldzhWYzdE?=
 =?utf-8?B?dXZCU1ZNRm0vUWhZaHcybVJadzhXMlFFUlE1RTFEaGYwdW9taHJldWZweVZ3?=
 =?utf-8?B?aEJ1djhOYU9DZW9YaWh2VHVPd2N2MWU3M1NJOHpxNUhnd0dFQk1wVmdvNUdU?=
 =?utf-8?B?a2dOY0tPZzNOUDF5ZFp3bjNSWk9PS2wxNWhnamtvTjV1SlRhcnRNeGRsN0xN?=
 =?utf-8?B?M2RvcXF0cHFQUFNoZkE4NTdxVWJLUmlEVmJBVnQvdTloUWwxWk9SSFI0dXdF?=
 =?utf-8?B?UUFucWhwcUFOdzNhVHVsWWRPMkFOc1cvZy9nY2F3RkVpSlVhWWUzdldOZWR1?=
 =?utf-8?B?TXd5MnlLWlFWNzR0OWhnS1NxNlZYcXMwYWExWld4TjMrbE51OVRTazBNRzJo?=
 =?utf-8?B?ZEYxN3dFejlqVFRPZm9nMHEycFZJMWg5elFTUWJhdG4rZDE2SXBGOGlHcUtB?=
 =?utf-8?B?Wm5GY1I0dlJ1dUsvdWpnZWdHSXhlTEFJalpROS9NU09JUXJiMkxmTEhiK0xI?=
 =?utf-8?B?Vk9YcTRsMHdrMDRzZ05GaUJ3NldOejlCTmdRMTZVazg2WmxGNytadGlra1Ra?=
 =?utf-8?B?QzBmQ0wvaU9haWpuUHdTTVBvbG9aaFlKT1hKQ2lxK0VPdU9QRnNCUUdkR1U0?=
 =?utf-8?B?NmFvRElBbFk5d25zWjlkeVJ2c0kzUGlJMldmTisxOGFpSVlTZ0p4ZUtwcjlu?=
 =?utf-8?B?Nlh2ZmhTT3lhQzB0Y0lDaW5acUR6NUIrR0JFUjBSWnJpalJMQ203ZS8yNUp0?=
 =?utf-8?B?TnlGc2NPTkNzMytMRmhJWjAweDJiemtaTVdsek9oL1kzRjY4N1VlcXVjUEJU?=
 =?utf-8?B?UjVnSGZ5eU1FbHMvV1M1VXErQXI1a3NFWDVGbjQ1UVFhWVRSK2NvUzI3Q1Zk?=
 =?utf-8?B?SzRjU2g3aDV5cEJVMFBUZzFZN0NHQ2ZrYVpUUVR2dGRwMUl4WFpaU0VEWEVX?=
 =?utf-8?B?SmNBVjB5OWJsbGloRCtMMEw4eUNWWC92ZE1VVG1lMm0vWDFXWFMyaVlXREg3?=
 =?utf-8?B?QXdJNmpnWEZxWS9HenpVd3dTZ2U0NDF0QWZ4R1Zkb3MzeVZXemRtRkZzZlBj?=
 =?utf-8?B?dGI5Z3dtQ0twdXFvbkR6VlVCNDhTcDNmVFQ1WkxRanl6TEo4YWZPNUNyeGlZ?=
 =?utf-8?B?MFlrbzRNNW4vYVNYUzlOMVk2ajZmcHpvbE1vV1hEbFRvbGZtRHNrRXB6ZGpy?=
 =?utf-8?B?TmdWNVlQZnlrV1JvM3lOZW1kdnBaZDRoaWQxcS9QMjVPRFpJK1kvQkhFdzEz?=
 =?utf-8?B?c3RmTE80aXJGT1IvMmN2YlNYNllacTQrR1M4MURCUDBZRkdnRlZLQmtNQ201?=
 =?utf-8?B?b2VqcHVZMkpzbzFXTnJDU3Azem9JbTVjM0FuWnpwa01kY0hmemEwTGZHbkhi?=
 =?utf-8?B?bnowTStTZzlSaWZHdTZLYW5uWXNObDJFbXhYUGZBWGtacjBha2txblloVzNM?=
 =?utf-8?B?aDd2MWdzM01Va3BTL3hQSlYxeDlaY1k3M1piRUFXL2txSW1MNUdUTnFwWEN3?=
 =?utf-8?B?Mm11cmJkSzRySm43Vjl3TnhmcS9KeVA2WUcra2ltbHh0Uloyd2hhdUM1ZFhm?=
 =?utf-8?B?SklHZTh2WVFrT0dDRENTaFA0elpSdjVYSkNYWXJoTVJpUk5sdHlFTGs4bFMr?=
 =?utf-8?Q?e5hAbCuxSHE6m6fEx3SX7DY=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 67005009-24ac-456f-33d3-08d9e51f2174
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 01:06:51.9848
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LomIY653kDBnadnw/icAesbU7rkwmG0sVBWTay8ismtlfodXHN2o1yFqaOiuiB+cXnwywWH6u/hSMIzedTZEOA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5728
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10244 signatures=673430
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0
 suspectscore=0 malwarescore=0 bulkscore=0 mlxscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202010004
X-Proofpoint-ORIG-GUID: 2RxVMeSGPLfSDJqjfMHNyxIBiBpl5tTv
X-Proofpoint-GUID: 2RxVMeSGPLfSDJqjfMHNyxIBiBpl5tTv
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/31/22 15:00, Mike Kravetz wrote:
> On 10/28/21 04:23, cgel.zte@gmail.com wrote:
>> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>>
>> Use swap() in order to make code cleaner. Issue found by coccinelle.
>>
>> Reported-by: Zeal Robot <zealci@zte.com.cn>
>> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
>> ---
>>  tools/testing/selftests/vm/userfaultfd.c | 10 ++--------
>>  1 file changed, 2 insertions(+), 8 deletions(-)
>>
>> diff --git a/tools/testing/selftests/vm/userfaultfd.c b/tools/testing/selftests/vm/userfaultfd.c
>> index 8a09057d2f22..41dfe6f4ebfb 100644
>> --- a/tools/testing/selftests/vm/userfaultfd.c
>> +++ b/tools/testing/selftests/vm/userfaultfd.c
>> @@ -1413,7 +1413,6 @@ static void userfaultfd_pagemap_test(unsigned int test_pgsize)
>>  static int userfaultfd_stress(void)
>>  {
>>  	void *area;
>> -	char *tmp_area;
>>  	unsigned long nr;
>>  	struct uffdio_register uffdio_register;
>>  	struct uffd_stats uffd_stats[nr_cpus];
>> @@ -1524,13 +1523,8 @@ static int userfaultfd_stress(void)
>>  					    count_verify[nr], nr);
>>  
>>  		/* prepare next bounce */
>> -		tmp_area = area_src;
>> -		area_src = area_dst;
>> -		area_dst = tmp_area;
>> -
>> -		tmp_area = area_src_alias;
>> -		area_src_alias = area_dst_alias;
>> -		area_dst_alias = tmp_area;
>> +		swap(area_src, area_dst);
>> +		swap(area_src_alias, area_dst_alias);
>>  
>>  		uffd_stats_report(uffd_stats, nr_cpus);
>>  	}
> 
> Sorry for the late comment/question.
> 
> Where is the test supposed to get the definition of swap()?  When trying to
> build, I get:
> 
> gcc -Wall -I ../../../../usr/include  -no-pie    userfaultfd.c -lrt -lpthread -o /home/mkravetz/tmp/linux-stable/tools/testing/selftests/vm/userfaultfd
> userfaultfd.c: In function ‘userfaultfd_stress’:
> userfaultfd.c:1530:3: warning: implicit declaration of function ‘swap’; did you mean ‘swab’? [-Wimplicit-function-declaration]
>  1530 |   swap(area_src, area_dst);
>       |   ^~~~
>       |   swab
> /usr/bin/ld: /tmp/ccPiwPM0.o: in function `userfaultfd_stress':
> userfaultfd.c:(.text+0x4b6d): undefined reference to `swap'
> /usr/bin/ld: userfaultfd.c:(.text+0x4b8b): undefined reference to `swap'
> collect2: error: ld returned 1 exit status
> make[1]: *** [../lib.mk:146: /home/mkravetz/tmp/linux-stable/tools/testing/selftests/vm/userfaultfd] Error 1
> 
> As far as I can see, swap is only defined in 'include/linux/minmax.h'.
> However, that is not part of the user API and not available to the tests.
> What am I missing?

Please disregard.

It was failing for me on v5.17-rc2, but I see it was fixed in linux-next
with commit "selftests: vm: remove dependecy from internal kernel macros".

Sorry for the noise,
-- 
Mike Kravetz