Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1107252pxb; Tue, 1 Feb 2022 18:45:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJzXL5MozoD9tHUQWVO1LDwKMI7PeFzM91OPUTeX2YsTGDDlUwXZkGvCjhcB7fNSQlDex5zQ X-Received: by 2002:a05:6402:2806:: with SMTP id h6mr28018961ede.223.1643769913369; Tue, 01 Feb 2022 18:45:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643769913; cv=none; d=google.com; s=arc-20160816; b=pHxHoxItL+IJUqOCj478TnVfxV1FazGos5UKOfcYasfqGUFXKgwxnm2hDkYQZQeQzt tW80C0K/WkCKszYswtOz9azgaEaLmooowX4GCa4H0W4Twgf+kZF9/VlNpN25DA+TEU/m EZjCfpxSynLiuVqZe6dDrINu5+RckPgNRHi3KGWXuRSWUGqM2CvtCwofDGtP2dXc6K6T wSAi3/o/uTiOiDsh1/1LdeRMDDSO+hJ3HcFL7qvAd2a4hGUdWss/cfNxMWo6746x5+TC QZ/Tf+pMhaKkYB6w2qDm4RY9ri9la9sLsB8RAWtmpdABk3EvPna9HEqhd2S/gWEUtqx6 wyOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=pOGMqJJpokNe23I9w0DAGD5uDNxb9lYmNYzFb2yZcGw=; b=oDHaKGgaqCYvdGqZzL7z4N2QSxlcy6N9KxoK9SDqylPIs8k+sK3TrMGrFOLku6k1Hn 3mjryYRMyMYObpHBwlh0Si/ppwSW54UicvXJ0L3cIpCr0YJxC3nKprnaGL2gT489eZ65 N11fda89Y2sdRUniXTbGdhn5dCC+tzW6Ojoz9ZFa+s4HuXfGcU4QvDfRhEoGqtaSS1M/ 0XVYg2xN3JzIeh5H4M/fbzJJHwG9DawSy4PLtmTABmMasMSJzEWLNFlzs4HRByHTLyU2 hlZ+fSu1uf6jymEQv0XCp8uBypDLCuBITC+rtgprFO9lmHGbyJ9SU6JEU+SFlyQrkAwG 8WxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2021-07-09 header.b=VwwNzDEh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w5si11341158edc.577.2022.02.01.18.44.48; Tue, 01 Feb 2022 18:45:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2021-07-09 header.b=VwwNzDEh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232600AbiBACDq (ORCPT + 99 others); Mon, 31 Jan 2022 21:03:46 -0500 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:5782 "EHLO mx0a-00069f02.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232255AbiBACDh (ORCPT ); Mon, 31 Jan 2022 21:03:37 -0500 Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 20VMWrRx008746; Tue, 1 Feb 2022 02:03:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2021-07-09; bh=pOGMqJJpokNe23I9w0DAGD5uDNxb9lYmNYzFb2yZcGw=; b=VwwNzDEh8R2WjxBxW2U1ZqXQXbEp27d1d8nOz1DoAC3xc5JVgF41J5VTyGpDAsE3PYv4 zXFuO4InCy2J+GO+ve1bX5FPabPtvGlGcPho4yb6yPmckXVS7jV3A7+WHm+Vwb5mmAM/ 1u1ijnRFPNjIUGKEtVCiIvZpQvfVuYT9YWMTYW89a0LNbCXviDiKu8csqZp5trHHFqw1 VWMJwlfYjtoBoYCuYzPvcUI6bmp9lHVdem0Z7OOVEu8DEAwfvXXe0AVap6xphQ6cD6SY qRo45xnZnzasfJZBCA2eqtdh5iUv/bt9GeU+ysqwxz39yqIGHR8h0p1QuTfuEp148DBw sQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3dxnk2gs7x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Feb 2022 02:03:30 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 2111tKeN079022; Tue, 1 Feb 2022 02:03:29 GMT Received: from pps.reinject (localhost [127.0.0.1]) by userp3030.oracle.com with ESMTP id 3dvtpy6w8a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Feb 2022 02:03:29 +0000 Received: from userp3030.oracle.com (userp3030.oracle.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 21123EPh096319; Tue, 1 Feb 2022 02:03:29 GMT Received: from ca-mkp.mkp.ca.oracle.com (ca-mkp.ca.oracle.com [10.156.108.201]) by userp3030.oracle.com with ESMTP id 3dvtpy6w3w-4; Tue, 01 Feb 2022 02:03:28 +0000 From: "Martin K. Petersen" To: John Garry , jejb@linux.ibm.com Cc: "Martin K . Petersen" , linuxarm@huawei.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: hisi_sas: Fix setting of hisi_sas_slot.is_internal Date: Mon, 31 Jan 2022 21:03:22 -0500 Message-Id: <164368097302.23346.15184270668603623540.b4-ty@oracle.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <1643627607-138785-1-git-send-email-john.garry@huawei.com> References: <1643627607-138785-1-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: G-8oQKFLQxGxaDiehhlTBKPdy2wXNbjr X-Proofpoint-ORIG-GUID: G-8oQKFLQxGxaDiehhlTBKPdy2wXNbjr Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 31 Jan 2022 19:13:27 +0800, John Garry wrote: > The hisi_sas_slot.is_internal member is not set properly for ATA commands > which the driver sends directly. A TMF struct pointer is normally used as > a test to set this, but it is NULL for those commands. It's not ideal, but > pass an empty TMF struct to set that member properly. > > Applied to 5.17/scsi-fixes, thanks! [1/1] scsi: hisi_sas: Fix setting of hisi_sas_slot.is_internal https://git.kernel.org/mkp/scsi/c/c763ec4c10f7 -- Martin K. Petersen Oracle Linux Engineering