Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1217811pxb; Tue, 1 Feb 2022 22:51:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJy4bMiese+49WblbzHEpqqcgtc28BFvKVVWI9vj3z6odtBtPfj2jspvEcLcJ4gcAudx2NI0 X-Received: by 2002:a63:d1:: with SMTP id 200mr11075812pga.402.1643784681811; Tue, 01 Feb 2022 22:51:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643784681; cv=none; d=google.com; s=arc-20160816; b=AhPFrhOvOrqTrJSi40P+OnrwqXlpn8yOyNIhKmWO3+kGmPVtGUFhrYY5O9dfm3JfG+ eJXoDXKXckeSVYcL4oic9iYXMBE4o/Q/dLXIim179RcYFo68iI2QVBiaxqTuHET/0JLU Ej6AR4riGQW4DcNUS4NND9C3I6DuDOduTGs1atNvZuUTTwXAW68lgsnOu9veVDyURKTV s+awsG2X+EZD9Q/IJoc373UaoQRz+PrGi3ChGbRwleCoZ2by2P7NtBkI3TJGzHxoDY3I tauuRjjF7y6WgSJCCxIo8b15y2TBFhw3ZRvO3W8mru8K4vNnxmlMNpyMaUf66IMQj68A MeiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:subject:cc:to:from:message-id :date:dkim-signature:dkim-signature; bh=e5pD/uyOwT+fedUBHy30mmqQQ/tiB8vLKqaMblLPE4c=; b=eFij9TIhjcihsibUlNYnA8LhH9aQMJxq07bEFDiGIAaGzDWeIsZDiqYOLX1HI5l7zh MW2T5ClrXDKsNmtGqnJ0L2DeMnVvG+bK2v9t0vrd956pWaLXKFt5thkWaHhcLSPQ8xB8 PwU9roVRc4w/629S/oWvnJ4nhwnYkLDclMDpSOwqBLLO3U1Sa+8fwUxjc8976xCQK/3n 1EqZ4Cpi1mMqhaOaijzNLySh1SSVJhQyUaM5SxHTaW73SmruX9cGINxz2Idyrs7UcSsg 4g3gxFr7zFAKM36uHOCG6dMLaRXZvBLA84yjINNGnoYBQzs+DndNoeCM0clwOh/ndIUr y2BA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=LJZAXPRK; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kk16si4921546pjb.95.2022.02.01.22.50.44; Tue, 01 Feb 2022 22:51:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=LJZAXPRK; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234589AbiBAHMK (ORCPT + 99 others); Tue, 1 Feb 2022 02:12:10 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]:60416 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230420AbiBAHMJ (ORCPT ); Tue, 1 Feb 2022 02:12:09 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 98B4C21123; Tue, 1 Feb 2022 07:12:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1643699528; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e5pD/uyOwT+fedUBHy30mmqQQ/tiB8vLKqaMblLPE4c=; b=LJZAXPRKUz7u/m1675ly31YhkgZUyGmM++COT5l+I3BYdijN0y9CFdzvW81HaQibiKAKNs tzvMthLe/OJRxWwmsr8QOg4aNgd4lJAu8PPwkHYG54Fo7jHaUkzwxOjDH0pFqk8APO4W7z hiiXZq6WITtRCrcZ2U32etwl2SxlYpE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1643699528; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e5pD/uyOwT+fedUBHy30mmqQQ/tiB8vLKqaMblLPE4c=; b=pRjGTbt27b62yWSDQPxoQJlHNAHrM7cbpA+qM2kJYNix6Kmi3QYHSRjtfBlqUu6LuS5yEi Bom8ceSSw/AA6rDQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 8BD9FA3B84; Tue, 1 Feb 2022 07:12:08 +0000 (UTC) Date: Tue, 01 Feb 2022 08:12:08 +0100 Message-ID: From: Takashi Iwai To: Jonas Hahnfeld Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jukka Heikintalo , =?UTF-8?B?UGF3ZcWC?= Susicki , stable@vger.kernel.org Subject: Re: [PATCH] ALSA: usb-audio: Correct quirk for VF0770 In-Reply-To: <20220131183516.61191-1-hahnjo@hahnjo.de> References: <20220131183516.61191-1-hahnjo@hahnjo.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 31 Jan 2022 19:35:16 +0100, Jonas Hahnfeld wrote: > > This device provides both audio and video. The original quirk added in > commit 48827e1d6af5 ("ALSA: usb-audio: Add quirk for VF0770") used > USB_DEVICE to match the vendor and product ID. Depending on module order, > if snd-usb-audio was asked first, it would match the entire device and > uvcvideo wouldn't get to see it. Change the matching to USB_AUDIO_DEVICE > to restore uvcvideo matching in all cases. > > Fixes: 48827e1d6af5 ("ALSA: usb-audio: Add quirk for VF0770") > Reported-by: Jukka Heikintalo > Tested-by: Jukka Heikintalo > Reported-by: Paweł Susicki > Tested-by: Paweł Susicki > Cc: # 5.4, 5.10, 5.14, 5.15 > Signed-off-by: Jonas Hahnfeld Thanks, applied now. Takashi