Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1219520pxb; Tue, 1 Feb 2022 22:55:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJwc2m71aVL0GQcN/cmxNFBxahQauqZ3m7nuHUDRa87GRna1GNY1MonYwnqfXLMx+LZ+my+7 X-Received: by 2002:a62:f207:: with SMTP id m7mr28223168pfh.44.1643784926476; Tue, 01 Feb 2022 22:55:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643784926; cv=none; d=google.com; s=arc-20160816; b=w2BBBW8lWXaS69NHbYqDHba9DTDUcCZ2XEo0Vk3JAnnC9RvGDtaXIEpsCvHyDvIoPQ JBCRx2M7NhP9no4ht/+UnfIXia+UVMJzqw1zpzcz+BDlYQ6P4KMxI9zv4jL8FuyNDghL R1ChXVkC6DNn8lmGozQAsCoXta1WsWQ2YnhQZ4AI99GWgj87Noz9LZLrtIPA6KkQMKbF JRUigAlMD0Uj2scUJEhRsRyrRP85pXEMq9z0jcw/+afpIiZ/VewObQTdnwVzVcdhYxzU 9bet11xIITFxSBYPxDqLwE41Uj+NdODlKhue36l2CFCFspyiWEGhxiphj1X9032EwIFt KlWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=pfoJSqUJqsGCmKEC9ZJtPKmunb6j3CTpdimjTdrcI9o=; b=WfcLNh5ibowz0iA+xzp02Rzh1wdyd5mhIV/FBveduTgyZvJmZ+wZ8boCvnyAPjqWvx XR2pd+hSeOU0yYQoM5Tq5/1YBhGbzmEy3fsYAn255gR6NbodaFP3LF2tXiOckCDy0liS /M6KH/6t2xunlImbKLRvdH/Gl4IhANKzhFslR95To0SytuMRgK8uBnpXs2Arn1LYWCcm PZg7nO0Eb6Siue1c3C4aJJKnnXjE+uXTgXEfEt4jZhT40pryP+au6jrW9+40npks6dIz lo9smBdvjoTnyh4CU0zKreDE8J0Uw3xdIhJtr1JXQqkE6qMziimKoz+7XXzRRavjDeSS RMsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@semihalf-com.20210112.gappssmtp.com header.s=20210112 header.b=gN7la6Wh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id em13si4115519pjb.175.2022.02.01.22.55.14; Tue, 01 Feb 2022 22:55:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@semihalf-com.20210112.gappssmtp.com header.s=20210112 header.b=gN7la6Wh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237677AbiBAUMo (ORCPT + 99 others); Tue, 1 Feb 2022 15:12:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239788AbiBAUMm (ORCPT ); Tue, 1 Feb 2022 15:12:42 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9D95C06173B for ; Tue, 1 Feb 2022 12:12:41 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id n12-20020a05600c3b8c00b0034eb13edb8eso1887314wms.0 for ; Tue, 01 Feb 2022 12:12:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=pfoJSqUJqsGCmKEC9ZJtPKmunb6j3CTpdimjTdrcI9o=; b=gN7la6WhB9fX25f5iMq/3MKNU4VegMYZ39NVSVxDhCib2Un+Bwdv/sgWFQ5KZTbYmy Fmxwsft1nMA0qcdwtdcmJGb9Ott5WRCUl5koJ6DbfmbuXRSW769LYS4vu7UJMy1J+Ke3 dmFVBB4Vz9uYo3o+KYgF3YwHtXdHAVK0Dhwgebyng1UHIEf4NE4QW5TSwrDiCFfpGkCZ hihBFzjNyfMPXIUsOfyKD47gmrngwdqW9w4SS9xbrUw8sYX7iISLbvwBhvtoewP3F0Kj F+mNxgBXa8ZQGBRIvH1ybKiD73/1cdqhBnqqVWd/UM8J75OX93XtqNmeDEerPdMFYWEf colw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pfoJSqUJqsGCmKEC9ZJtPKmunb6j3CTpdimjTdrcI9o=; b=h3L2qGJUAvmArCxivIMyK4XAbswr+iSykr+0D0pZL/mzD/pSTBlubOTemnx+9W0uW7 NwMt7K3kuw2Qcr0q8cm/VaBO3yhf1SLbWyUvl1VWVlE3CDHrpupdrbXFWr/s8nzdBbZS bFbd++ioy/MPlW5qEFbA2GMUHOe76GDbehDwOiesJDRze5WdpSPCxCODyxgt3puCQR5z VMDC5xRDNUU7xDWLktqIvxyxwYi99+hDet7wGY4Rpk+zPT3qz+6n0RfE5mhES+HnJrpq QcfSrHenOydZ7s1uTlyqiHE6Z5h59K33zjuS7BzSZaWdXM2/FyOspslV3vLnLpYyDVyB zmnQ== X-Gm-Message-State: AOAM53358S6qJhcS8cgqmbteFOYI4e4+FSqHUKYiMgZlht1jMJaoKinT ipIKVhx2irjDallDMPW1HW/1W6a7y88M6NqaIPKNug== X-Received: by 2002:a7b:c759:: with SMTP id w25mr3175443wmk.10.1643746360413; Tue, 01 Feb 2022 12:12:40 -0800 (PST) MIME-Version: 1.0 References: <20220201200353.1331443-1-rad@semihalf.ocm> In-Reply-To: <20220201200353.1331443-1-rad@semihalf.ocm> From: =?UTF-8?Q?Rados=C5=82aw_Biernacki?= Date: Tue, 1 Feb 2022 21:12:32 +0100 Message-ID: Subject: Re: [PATCH v2 0/2] Bluetooth: Fix skb handling in net/bluetooth/mgmt.c To: linux-bluetooth , Luiz Augusto von Dentz , Marcel Holtmann Cc: CrosBT Upstreaming , Archie Pusaka , Miao-chen Chou , Jakub Kicinski , Johan Hedberg , Linux Kernel Mailing List , "open list:NETWORKING [GENERAL]" , upstream@semihalf.com, Angela Czubak , Marek Maslanka , Radoslaw Biernacki Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey, please ignore this one as I made a typo in the domain name :| wt., 1 lut 2022 o 21:03 Radoslaw Biernacki napisa=C5=82(= a): > > Here is second version of the fix for skb handling in net/bluetooth/mgmt.= c > First patch is fixing the skb allocation which theoretically might push s= kb > tail beyond its end. > Second patch simplifies operations on eir while using skb. > Patches adds two helper functions to eir.h to align to the goal of > eliminating the necessity of intermediary buffers, which can be achieved > with additional changes done in this spirit. > > v1->v2: > - fix mgmt_device_connected() > - add eir_skb_put_data() - function for skb handing with eir > > Radoslaw Biernacki (2): > Bluetooth: Fix skb allocation in mgmt_remote_name() & > mgmt_device_connected() > Bluetooth: Improve skb handling in mgmt_device_connected() > > net/bluetooth/eir.h | 20 ++++++++++++++++++++ > net/bluetooth/mgmt.c | 43 ++++++++++++++++--------------------------- > 2 files changed, 36 insertions(+), 27 deletions(-) > > -- > 2.35.0.rc2.247.g8bbb082509-goog >