Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Feb 2022 12:17:45 +0000
From:   Alyssa Ross <hi@alyssa.is>
To:     Prashant Malani <pmalani@chromium.org>
Cc:     linux-kernel@vger.kernel.org, Tzung-Bi Shih <tzungbi@google.com>,
        Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Guenter Roeck <groeck@chromium.org>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        chrome-platform@lists.linux.dev
Subject: Re: [PATCH v2] platform/chrome: cros_ec_typec: Check for EC device
Message-ID: <20220201121745.r4dbilp3fpqhjuty@eve>
References: <20220126190219.3095419-1-pmalani@chromium.org>
 <20220126230411.nn2illij4wbpdm4q@eve>
 <YfHUXtJPU77wtCPb@chromium.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="gounvrkiin7nkkhy"
Content-Disposition: inline
In-Reply-To: <YfHUXtJPU77wtCPb@chromium.org>
Precedence: bulk


--gounvrkiin7nkkhy
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Prashant,

On Wed, Jan 26, 2022 at 11:08:14PM +0000, Prashant Malani wrote:
> Hi Alyssa,
>
> On Jan 26 23:04, Alyssa Ross wrote:
> > On Wed, Jan 26, 2022 at 07:02:20PM +0000, Prashant Malani wrote:
> > > The Type C ACPI device on older Chromebooks is not generated correctly
> > > (since their EC firmware doesn't support the new commands required). =
In
> > > such cases, the crafted ACPI device doesn't have an EC parent, and it=
 is
> > > therefore not useful (it shouldn't be generated in the first place si=
nce
> > > the EC firmware doesn't support any of the Type C commands).
> > >
> > > To handle devices which use these older firmware revisions, check for
> > > the parent EC device handle, and fail the probe if it's not found.
> > >
> > > Fixes: fdc6b21e2444 ("platform/chrome: Add Type C connector class dri=
ver")
> > > Reported-by: Alyssa Ross <hi@alyssa.is>
> > > Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
> > > Signed-off-by: Prashant Malani <pmalani@chromium.org>
> > > ---
> > > Hi Alyssa, could you kindly test this with your existing setup? Thank=
s!
> >
> > Hi Prashant, I'm happy to test, but I'm on vacation until the end of the
> > week so probably won't get a chance before Monday.
>
> No worries, whenever you get the chance is fine.
>
> >
> > I'm guessing I should be testing with latest upstream coreboot (now that
> > your fix there has been applied)?
>
> You should use the coreboot with which you discovered the crash, so the
> one which *doesn't* contain the fix.

I applied this patch to Linux 5.17-rc2 and tested with the
coreboot_tiano-eve-mrchromebox-20210806.rom firmware.

The Oops has been replaced with
"cros-ec-typec: GOOG0014:00: couldn't find parent EC device".
My laptop now reboots correctly =E2=80=94 the hang on reboot is gone.

The cros_ec_typec driver ends up being loaded, but no devices are bound
to it.  This differs from the behaviour with upstream coreboot
(cabf9e33a7), where cros_ec_typec does not end up being loaded.

Assuming all that's the intended behaviour:

Reviewed-by: Alyssa Ross <hi@alyssa.is>
Tested-by: Alyssa Ross <hi@alyssa.is>

BTW: if you need anything else tested on an eve running upstream Linux
and Coreboot in future, I'm happy to be CCed. :)

> Thanks again!
>
> -Prashant

--gounvrkiin7nkkhy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEH9wgcxqlHM/ARR3h+dvtSFmyccAFAmH5JOIACgkQ+dvtSFmy
ccBxVw//fEzb3zR8P3ov4Hhq21CxINWY7CYP/+iHTAMNIJaTQrU+1QgTnSXv2Lam
5wGg4OFaqVKOffT738eub9MSxdeTfueAno4gHd3FmhAAAbU2wjj2dPaju+lZdH08
teCmPmnGPyc5pkW+vctvjiafPuvr99sz5mkgZ51jywWGcoYBIjvtkiQVtDisMNoh
aY80WujZRx7UIqw9cMjb3fcSEvLXL9yDQXYNmEULFI72uUiMFqf5DrzYW43hJCF6
pNZwnTE1w8rvs0cGKqp1RsqjCyS4sjcPMbq3JAbQfqwrB040x7SQqB6fMjEonPns
E93ycWrEqWzOPTkM0d9kHtU69OuiX82aY/1LvZsmRmFGx/T3lq9iXswjstodAg9A
eZJCaLauSbUEApyOuJ+VlX+YfYBAtGMrZ7tPOYukMAkR6PSrLfqz2ntrL1K3rtcH
QHcCLd7/LAhGNEzwFBw4Ob85UCD3eti8X3KTCmbrklIZNNTAqTsuDtX4HgEeuuqU
X0AQAvJ13FFQFWflR+yrtl6m1fJk2sjGYflGJkjCT615fW3x3SyTVDdwPX3Nbs5N
VUWDJjbYzjubONyYitSoyrBRzKCihTOaTp06Zu0q/ubb0N5z6d8UZ0gWAu+N6XRE
yBjWy4BObHcioQzipFTAHsA5wVbmUdFLXWF7d32P2lBIgRnNRfg=
=Cjxi
-----END PGP SIGNATURE-----

--gounvrkiin7nkkhy--