Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Feb 2022 17:00:53 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Dave Hansen <dave.hansen@intel.com>
Cc:     Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Rick Edgecombe <rick.p.edgecombe@intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V8 03/44] x86/pkeys: Create pkeys_common.h
Message-ID: <20220202010053.GT785175@iweiny-DESK2.sc.intel.com>
References: <20220127175505.851391-1-ira.weiny@intel.com>
 <20220127175505.851391-4-ira.weiny@intel.com>
 <7bb7d2be-9fa0-1b0d-17d1-adb7d58d5389@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7bb7d2be-9fa0-1b0d-17d1-adb7d58d5389@intel.com>
User-Agent: Mutt/1.11.1 (2018-12-01)
Precedence: bulk

On Fri, Jan 28, 2022 at 02:43:54PM -0800, Dave Hansen wrote:
> On 1/27/22 09:54, ira.weiny@intel.com wrote:
> > From: Ira Weiny <ira.weiny@intel.com>
> > 
> > Protection Keys User (PKU) and Protection Keys Supervisor (PKS) work in
> > similar fashions and can share common defines.  Specifically PKS and PKU
> > each have:
> > 
> > 	1. A single control register
> > 	2. The same number of keys
> > 	3. The same number of bits in the register per key
> > 	4. Access and Write disable in the same bit locations
> > 
> > Given the above, share all the macros that synthesize and manipulate
> > register values between the two features.  Share these defines by moving
> > them into a new header, change their names to reflect the common use,
> > and include the header where needed.
> 
> I'd probably include *one* more sentence to prime the reader for the
> pattern they are about to see.  Perhaps:
> 
> 	This mostly takes the form of converting names from the PKU-
> 	specific "PKRU" to the U/S-agnostic "PKR".

Fair enough.

> 
> > Also while editing the code remove the use of 'we' from comments being
> > touched.
> > 
> > NOTE the checkpatch errors are ignored for the init_pkru_value to
> > align the values in the code.
> > 
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> 
> Either way, this looks fine:
> 
> Acked-by: Dave Hansen <dave.hansen@linux.intel.com>

Thanks!
Ira