Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <6fc4a81f-1a13-bff9-7b2e-d5bec382cb42@synopsys.com>
 <9bab4777-3034-b789-fdf6-ca8d7e6a8c35@infradead.org> <CAOMZO5Aa4WxuadfoFGwwyYyD4UGPm-E258xTWU3-ozp_hwG-7g@mail.gmail.com>
 <d8981e2a-4f61-72bb-e5cc-bf4ded29c08a@synopsys.com>
In-Reply-To: <d8981e2a-4f61-72bb-e5cc-bf4ded29c08a@synopsys.com>
From:   Arnd Bergmann <arnd@kernel.org>
Date:   Wed, 2 Feb 2022 08:46:00 +0100
Message-ID: <CAK8P3a3ELrSC=KX6cr8UnP6kkJN0AXeAE4EG4oUY=Zz7gG_dgg@mail.gmail.com>
Subject: Re: Kconfig CONFIG_FB dependency regression
To:     Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc:     Fabio Estevam <festevam@gmail.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Kees Cook <keescook@chromium.org>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        John Youn <John.Youn@synopsys.com>,
        Bing Yuan <Bing.Yuan@synopsys.com>,
        "linux-mediatek@lists.infradead.org" 
        <linux-mediatek@lists.infradead.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Feb 2, 2022 at 1:14 AM Thinh Nguyen <Thinh.Nguyen@synopsys.com> wrote:
> Fabio Estevam wrote:
> > On Tue, Feb 1, 2022 at 8:06 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> >>
> >> On 2/1/22 15:01, Thinh Nguyen wrote:
> >>> Hi,
> >>>
> >>> One of our test setups is unable to boot (stuck at initramfs). Git
> >>> bisection points to the commit below:
> >>>
> >>> f611b1e7624c ("drm: Avoid circular dependencies for CONFIG_FB")
> >>>
> >>> Reverting this patch resolves the issue. This issue persists in mainline
> >>> also. Unfortunately there isn't any meaningful log. Hopefully someone
> >>> can give some insight as to what could be the issue and revert/fix this
> >>> issue.
> >>
> >> Hi,
> >> Did you enable DRM_FBDEV_EMULATION?
>
> I did not enable it.
>
> >> Please provide the failing .config file.
> >
> > Does selecting CONFIG_FB=y help?
> >
>
> On the config that has the issue, this isn't set. After reverting the
> commit above, this was set. Maybe this is what's needed? I need to test it.

CONFIG_FB should not normally be needed for booting, so unless
you have a graphical application in your initramfs that requires the /dev/fb0
device to work, it is not supposed to make a difference.

Are there any other differences in your .config before and after the patch?
It's possible that you use some other driver that in turn depends on
CONFIG_FB. Does your machine have any graphical output device?
If yes, which driver do you use?

You may also want to make sure that you have 9d6366e743f3 ("drm:
fb_helper: improve CONFIG_FB dependency") in your kernel, which
fixes a minor problem with my original patch.

         Arnd