Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Feb 2022 13:10:50 +0100
From:   Michal Hocko <mhocko@suse.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     David Hildenbrand <david@redhat.com>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, stable@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH v1] drivers/base/memory: add memory block to memory group
 after registration succeeded
Message-ID: <YfkjSj59otaREsfi@dhcp22.suse.cz>
References: <20220128144540.153902-1-david@redhat.com>
 <20220131170123.42d7f46ecea0da1cb1579113@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220131170123.42d7f46ecea0da1cb1579113@linux-foundation.org>
Precedence: bulk

On Mon 31-01-22 17:01:23, Andrew Morton wrote:
> On Fri, 28 Jan 2022 15:45:40 +0100 David Hildenbrand <david@redhat.com> wrote:
> 
> > If register_memory() fails, we freed the memory block but already added
> > the memory block to the group list, not good. Let's defer adding the
> > block to the memory group to after registering the memory block device.
> > 
> > We do handle it properly during unregister_memory(), but that's not
> > called when the registration fails.
> > 
> 
> I guess this has never been known to happen.  So I queued the fix for
> 5.18-rc1, cc:stable.

I do not think this is worth stable backporting. Chances of a failure
are pretty small and I am not aware of any existing report.

-- 
Michal Hocko
SUSE Labs