Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Feb 2022 18:41:12 -0800
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     kernel test robot <lkp@intel.com>
Cc:     zhanglianjie <zhanglianjie@uniontech.com>, keescook@chromium.org,
        kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
        yzaikin@google.com, akpm@linux-foundation.org
Subject: Re: [PATCH] mm: move page-writeback sysctls to is own file
Message-ID: <YfnvSLFBoTwF1V5y@bombadil.infradead.org>
References: <20220128091901.18074-1-zhanglianjie@uniontech.com>
 <202201290051.7pu9CEMG-lkp@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202201290051.7pu9CEMG-lkp@intel.com>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

Likewise here, these test results are assuming an older kernel. Instead
linux-next can be a better target to test for for these patches.

  Luis

On Sat, Jan 29, 2022 at 01:16:53AM +0800, kernel test robot wrote:
> Hi zhanglianjie,
> 
> Thank you for the patch! Perhaps something to improve:
> 
> [auto build test WARNING on linus/master]
> [also build test WARNING on v5.17-rc1 next-20220128]
> [cannot apply to hnaz-mm/master linux/master kees/for-next/pstore]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/zhanglianjie/mm-move-page-writeback-sysctls-to-is-own-file/20220128-172052
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 23a46422c56144939c091c76cf389aa863ce9c18
> config: i386-randconfig-a003 (https://download.01.org/0day-ci/archive/20220129/202201290051.7pu9CEMG-lkp@intel.com/config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce (this is a W=1 build):
>         # https://github.com/0day-ci/linux/commit/d24502aa729978894feb2de10481cd139ae5bb42
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review zhanglianjie/mm-move-page-writeback-sysctls-to-is-own-file/20220128-172052
>         git checkout d24502aa729978894feb2de10481cd139ae5bb42
>         # save the config file to linux build tree
>         mkdir build_dir
>         make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
> >> mm/page-writeback.c:509:5: warning: no previous prototype for 'dirty_background_ratio_handler' [-Wmissing-prototypes]
>      509 | int dirty_background_ratio_handler(struct ctl_table *table, int write,
>          |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >> mm/page-writeback.c:520:5: warning: no previous prototype for 'dirty_background_bytes_handler' [-Wmissing-prototypes]
>      520 | int dirty_background_bytes_handler(struct ctl_table *table, int write,
>          |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >> mm/page-writeback.c:531:5: warning: no previous prototype for 'dirty_ratio_handler' [-Wmissing-prototypes]
>      531 | int dirty_ratio_handler(struct ctl_table *table, int write, void *buffer,
>          |     ^~~~~~~~~~~~~~~~~~~
> >> mm/page-writeback.c:545:5: warning: no previous prototype for 'dirty_bytes_handler' [-Wmissing-prototypes]
>      545 | int dirty_bytes_handler(struct ctl_table *table, int write,
>          |     ^~~~~~~~~~~~~~~~~~~
> >> mm/page-writeback.c:2002:5: warning: no previous prototype for 'dirty_writeback_centisecs_handler' [-Wmissing-prototypes]
>     2002 | int dirty_writeback_centisecs_handler(struct ctl_table *table, int write,
>          |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> 
> vim +/dirty_background_ratio_handler +509 mm/page-writeback.c
> 
> a756cf5908530e Johannes Weiner   2012-01-10  508  
> 2da02997e08d3e David Rientjes    2009-01-06 @509  int dirty_background_ratio_handler(struct ctl_table *table, int write,
> 32927393dc1ccd Christoph Hellwig 2020-04-24  510  		void *buffer, size_t *lenp, loff_t *ppos)
> 2da02997e08d3e David Rientjes    2009-01-06  511  {
> 2da02997e08d3e David Rientjes    2009-01-06  512  	int ret;
> 2da02997e08d3e David Rientjes    2009-01-06  513  
> 8d65af789f3e2c Alexey Dobriyan   2009-09-23  514  	ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos);
> 2da02997e08d3e David Rientjes    2009-01-06  515  	if (ret == 0 && write)
> 2da02997e08d3e David Rientjes    2009-01-06  516  		dirty_background_bytes = 0;
> 2da02997e08d3e David Rientjes    2009-01-06  517  	return ret;
> 2da02997e08d3e David Rientjes    2009-01-06  518  }
> 2da02997e08d3e David Rientjes    2009-01-06  519  
> 2da02997e08d3e David Rientjes    2009-01-06 @520  int dirty_background_bytes_handler(struct ctl_table *table, int write,
> 32927393dc1ccd Christoph Hellwig 2020-04-24  521  		void *buffer, size_t *lenp, loff_t *ppos)
> 2da02997e08d3e David Rientjes    2009-01-06  522  {
> 2da02997e08d3e David Rientjes    2009-01-06  523  	int ret;
> 2da02997e08d3e David Rientjes    2009-01-06  524  
> 8d65af789f3e2c Alexey Dobriyan   2009-09-23  525  	ret = proc_doulongvec_minmax(table, write, buffer, lenp, ppos);
> 2da02997e08d3e David Rientjes    2009-01-06  526  	if (ret == 0 && write)
> 2da02997e08d3e David Rientjes    2009-01-06  527  		dirty_background_ratio = 0;
> 2da02997e08d3e David Rientjes    2009-01-06  528  	return ret;
> 2da02997e08d3e David Rientjes    2009-01-06  529  }
> 2da02997e08d3e David Rientjes    2009-01-06  530  
> 32927393dc1ccd Christoph Hellwig 2020-04-24 @531  int dirty_ratio_handler(struct ctl_table *table, int write, void *buffer,
> 32927393dc1ccd Christoph Hellwig 2020-04-24  532  		size_t *lenp, loff_t *ppos)
> 04fbfdc14e5f48 Peter Zijlstra    2007-10-16  533  {
> 04fbfdc14e5f48 Peter Zijlstra    2007-10-16  534  	int old_ratio = vm_dirty_ratio;
> 2da02997e08d3e David Rientjes    2009-01-06  535  	int ret;
> 2da02997e08d3e David Rientjes    2009-01-06  536  
> 8d65af789f3e2c Alexey Dobriyan   2009-09-23  537  	ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos);
> 04fbfdc14e5f48 Peter Zijlstra    2007-10-16  538  	if (ret == 0 && write && vm_dirty_ratio != old_ratio) {
> eb608e3a344b3a Jan Kara          2012-05-24  539  		writeback_set_ratelimit();
> 2da02997e08d3e David Rientjes    2009-01-06  540  		vm_dirty_bytes = 0;
> 2da02997e08d3e David Rientjes    2009-01-06  541  	}
> 2da02997e08d3e David Rientjes    2009-01-06  542  	return ret;
> 2da02997e08d3e David Rientjes    2009-01-06  543  }
> 2da02997e08d3e David Rientjes    2009-01-06  544  
> 2da02997e08d3e David Rientjes    2009-01-06 @545  int dirty_bytes_handler(struct ctl_table *table, int write,
> 32927393dc1ccd Christoph Hellwig 2020-04-24  546  		void *buffer, size_t *lenp, loff_t *ppos)
> 2da02997e08d3e David Rientjes    2009-01-06  547  {
> fc3501d411d348 Sven Wegener      2009-02-11  548  	unsigned long old_bytes = vm_dirty_bytes;
> 2da02997e08d3e David Rientjes    2009-01-06  549  	int ret;
> 2da02997e08d3e David Rientjes    2009-01-06  550  
> 8d65af789f3e2c Alexey Dobriyan   2009-09-23  551  	ret = proc_doulongvec_minmax(table, write, buffer, lenp, ppos);
> 2da02997e08d3e David Rientjes    2009-01-06  552  	if (ret == 0 && write && vm_dirty_bytes != old_bytes) {
> eb608e3a344b3a Jan Kara          2012-05-24  553  		writeback_set_ratelimit();
> 2da02997e08d3e David Rientjes    2009-01-06  554  		vm_dirty_ratio = 0;
> 04fbfdc14e5f48 Peter Zijlstra    2007-10-16  555  	}
> 04fbfdc14e5f48 Peter Zijlstra    2007-10-16  556  	return ret;
> 04fbfdc14e5f48 Peter Zijlstra    2007-10-16  557  }
> 04fbfdc14e5f48 Peter Zijlstra    2007-10-16  558  
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org