Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1336208pxb; Wed, 2 Feb 2022 02:35:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJwza/9L7icO3nTH5vptVyhzDkkU9UcfEMTj+Ku+6B5NPlKhfL5upc4kQ8PJxE/5YGjL2aeV X-Received: by 2002:a17:90a:e288:: with SMTP id d8mr7471350pjz.196.1643798158475; Wed, 02 Feb 2022 02:35:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643798158; cv=none; d=google.com; s=arc-20160816; b=IVNe53V3cYWDEtegCm6ZnDguvHUO5Ifn/SF38zRits1MfE+nOtexodSmDMSce+9Qj0 G9YN8x3cbfwOPn9S0gAoBWQREiTUDpx49UlTCJayAFMDg5e5jkKGhUnFm8pF+Vp7T9KE ta8Avk/mdfpfR0s6Det13t1snegsJqFdXORHycekcvB/IqKNImaup53k1nC5Exr33P3S 62eAhZGHBMzk/uGdyFCd2nruD1yCq0h89Du7A2M+hp/9/qio/TxwRo1TNm7LdUWbMo1z U7SAHq4kS7z3er04epPdeoadyXmK9RzxXLKOUIMUkvHVeorSsqAOQ2WQwWABJ8dELJfl wBgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ajVyrzfKSALQ4/ceI/k/lKRKfDdtj5KLtC27fTafsDY=; b=AOcrdrKyhVMR1jvOtk++bZb8nC/rjf0aRE7FtM/ZxPWzbQc35ukcQs0K2rX8ftpT/o 5yzUSW/EYO9l1d8jH7cKpymvzO3ye1tfFqnVnRutgkjlYCPdFmGiOGDjGOdj0tqGPOJR /7Xo3BczYrKsemmhzngCMb2BIYZoTlvydjW/UmWI0fPHOsSgtUS4eHqsxYIwX+Az16w5 g6SesCopN6o2H49eGxzcecai2sLClB2Mp5L1aAJ/UN0DWwX0Z/T6sdoT705XNUlfF9QQ k5MaikSZFbGqaNPqsQIHq8hdb/W3uuRgd7zCYBJJedtufrpD2ZD2VJu3K1UKum/Ef6rB zUUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="FM9tm/a2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q1si3320155pgq.434.2022.02.02.02.35.46; Wed, 02 Feb 2022 02:35:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="FM9tm/a2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235747AbiBAItO (ORCPT + 99 others); Tue, 1 Feb 2022 03:49:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233828AbiBAItM (ORCPT ); Tue, 1 Feb 2022 03:49:12 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4A7FC061714; Tue, 1 Feb 2022 00:49:12 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 67DEE614DC; Tue, 1 Feb 2022 08:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BF06C340ED; Tue, 1 Feb 2022 08:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643705343; bh=ajVyrzfKSALQ4/ceI/k/lKRKfDdtj5KLtC27fTafsDY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FM9tm/a2y969eT4I/XdeVpMzMoyRa8iLMNN1ulOe5FA9DqOb20JBOlPoeakCH6zJa o2niQVSNew+0PwUY8Mmn1XjFXYCHuTNFRutZS+TaciysdOBlX7mFIgyWtGG91xPOvq +c+F6DjMvUuneddm4bI2VXZLAh39sI5yIqK8WEHw= Date: Tue, 1 Feb 2022 09:49:00 +0100 From: Greg KH To: "David E. Box" Cc: hdegoede@redhat.com, andriy.shevchenko@linux.intel.com, srinivas.pandruvada@intel.com, mgross@linux.intel.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Mark Gross Subject: Re: [PATCH 1/3] platform/x86: Add Intel Software Defined Silicon driver Message-ID: References: <20220201030424.1068816-1-david.e.box@linux.intel.com> <20220201030424.1068816-2-david.e.box@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220201030424.1068816-2-david.e.box@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 31, 2022 at 07:04:22PM -0800, David E. Box wrote: > +static struct bin_attribute bin_attr_provision_akc; > +static struct bin_attribute bin_attr_provision_cap; > +static BIN_ATTR_WO(provision_akc, SDSI_SIZE_WRITE_MSG); You the structure twice, why?