Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1342354pxb; Wed, 2 Feb 2022 02:47:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJzD9qGOsIFVbLTnMOcg4SienCc+WJ7ToLQpKn8iOMugomRjZIrO2LA+J5lypNQNGegab4zB X-Received: by 2002:a17:902:ed89:: with SMTP id e9mr30500027plj.88.1643798856253; Wed, 02 Feb 2022 02:47:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643798856; cv=none; d=google.com; s=arc-20160816; b=pI/TVjBPD5LWdDBr/iCMH3e/S/pzB+DZdsO8/j34rK9KG0CdF0iyV2AAaK4dSSLMv7 F/Ev7IW4JtAuG42m17GYCf1DaEWl0rHagR50BEoj/LQteI/GoqvxQr0/QkrgP2eklogP QOzE2HgrWFZlm7+TFJvhQZ8OaEaBooLrbKKTbBlqxKbyNPGdUOmV//x7E3dq2oFFwhfa OqFCqN1Vmshnh4BZFjXVPvOmhdSLLN3UrkQOaxB2GCHDj6bUAVIo7wX51RLvNueVwmyx 73bTT2ULibjhtFcUhqMsn6w+PDKTddFongHDZDzenlEegR06Y7UZtAY4nDPEdRpgZ9nO 58hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=9BCkpjG33qyByXD9F3cH6yJ7Sw71yYvYV4+80QLrB8o=; b=VTXuFCh50IdPcf0F9bw9UuFCwVpwQQrGl3P+9o1QsYMr13hetoeevEQQrzeHi0MXMK q4JBPlEXFTB2/6+NdHoxtPnwc82YA4ms/wb2KisFwFyZrAntNUp554a5KbHjYNgjGi8S Bh7yhuSDq+yYQ+9VjQl+3eUWZvm6nno8GWu/SQafuglkt2LBCkm7yh2UtlziBwT7QoVz Mh/kLWHDrKPADn9zverZWogqbObvBssvksLQPlGLot1t4ESupiIbg052Pv7LA4xqlk1i XWW1zhvlRNYpwYEwBk/+Jz7Hj9IcuhIiZwfk3076NHpeHocyMcwL/+D1GVY1kpdhSwPu CuZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VRz6QowM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r80si10514660pfc.159.2022.02.02.02.47.24; Wed, 02 Feb 2022 02:47:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VRz6QowM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237972AbiBAMY6 (ORCPT + 99 others); Tue, 1 Feb 2022 07:24:58 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:57698 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231359AbiBAMY4 (ORCPT ); Tue, 1 Feb 2022 07:24:56 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 08177614F1; Tue, 1 Feb 2022 12:24:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D3C7C340EB; Tue, 1 Feb 2022 12:24:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643718293; bh=ooC0NvRuprHdmJZFzg4LMCCX2H+CyKZoohO2KL8HGD4=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=VRz6QowMJZkaY7Dy9wn0nzAhOqiptpxHv/1QEcA9ff+rglRHtOftfgG9P7vxGSld+ Os2H7/cGbci9v6Gl0ZmP0lPElPXP+XQhN9DbTyJAwfM5UbQOkDoDcGODOgK3Cl1Lqb h4ZVHBVK4PRGEGJgtVUSaSuMmkNzi5sXulh81z3XVMWxy0mBQUX85skMxs/jVVaq9e T3pnJ8gckBW4KpXnNGX7L5SZnfnFDy/QgeLpExU0ly1A5+HIiGdnSD+F4JQYhS7R/M yZug1YGuoCrcNfzs/6F9b4bXelx0J7rD446DWxWY2tAWINP3TjTx60uPBNFYiA9RFO ytI6ClQD/znbA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: ray_cs: Check ioremap return value From: Kalle Valo In-Reply-To: <20211230022926.1846757-1-jiasheng@iscas.ac.cn> References: <20211230022926.1846757-1-jiasheng@iscas.ac.cn> To: Jiasheng Jiang Cc: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiasheng Jiang User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <164371828600.16633.15192450644077513815.kvalo@kernel.org> Date: Tue, 1 Feb 2022 12:24:51 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jiasheng Jiang wrote: > As the possible failure of the ioremap(), the 'local->sram' and other > two could be NULL. > Therefore it should be better to check it in order to avoid the later > dev_dbg. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Jiasheng Jiang Patch applied to wireless-next.git, thanks. 7e4760713391 ray_cs: Check ioremap return value -- https://patchwork.kernel.org/project/linux-wireless/patch/20211230022926.1846757-1-jiasheng@iscas.ac.cn/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches