Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1346408pxb; Wed, 2 Feb 2022 02:54:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJxJT87N8prrCIqSWqmmGIHfe6i6Mw5scocNiqRI6YHFhDynxwLykAizbmHt//e1PTbZLL/D X-Received: by 2002:a63:2a94:: with SMTP id q142mr20717699pgq.193.1643799290636; Wed, 02 Feb 2022 02:54:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643799290; cv=none; d=google.com; s=arc-20160816; b=vSTFBTRhMCOAF012zkl4hzu++xMgXrpO1vPlfOGc/sjCsYGTcvvAv97BYSEQ6jZICz St6dQ3syMl8f6Av9gymAFkd4m2662DPhQvrFZ5ZWO0ATdvcWAbfDC8h0d9eiKl7WZt8a D22UwbSZeI1pUjKVdrq2ZhrzIM7hPes2YIcGicUl52iN9iMRZlsdTpuYynFA7/WYItCE EHiTnnF16DkHy4SvNk7J6kO51YXY+77bbqW6I7plxcsyx/G5vmOtx2Ymdo+XsybJpt4K oIy5cFNGw5o3H6amTvfqC69xXF/6PUFtYcnu+Xa7Y9oulOme90nHs6zZ9S5K05vHv//d D7cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=N/ZspiK4r9TEaoVNgI7Lic8oA3IpgMqPBVL6eqdGsnI=; b=gmgL1hMpmRzQeCyTvlQOFfGpBFtKDLZoO4OsAv2S6P8tFb1cUlsPf/j7uA9w2L/l2E Cr1FSvaNSgGbKDMNhKaDuwemF09m2ERidNHzUovSup9qGEo3PF0cxjGHdu53Y+RDpbaN yPHmtL6Z1aSAWlW4hp7B1E8zNs9W/HSx/Ir+A2Iigp+x84ZsbbV8OIzMI6RPuA4jXVRK KHG9K1Ne8ol75V7zSsONwTuqrncjnooH1mrHFIuTPywG9ks66SiqTX1E6NO9rvqJUt70 in2pX2nq3Z/tF27houXn5exVPqCy92odhW/Dgwhs+FoRzii2dVl+x9I01ktZ1izUqv7X JmSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=d7EVS9w5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n4si18392722pfd.162.2022.02.02.02.54.38; Wed, 02 Feb 2022 02:54:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=d7EVS9w5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234995AbiBAHeY (ORCPT + 99 others); Tue, 1 Feb 2022 02:34:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234709AbiBAHeY (ORCPT ); Tue, 1 Feb 2022 02:34:24 -0500 Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6A39C061714 for ; Mon, 31 Jan 2022 23:34:23 -0800 (PST) Received: by mail-io1-xd2c.google.com with SMTP id d188so20052430iof.7 for ; Mon, 31 Jan 2022 23:34:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N/ZspiK4r9TEaoVNgI7Lic8oA3IpgMqPBVL6eqdGsnI=; b=d7EVS9w5ma5cTVIaW11AlKFdNKa2r8O2xD3G5tSzSoYSEuScaZ++BE8HWBgeNEv3Iw ZneqFMPx49l6xSNdozrJLmdIeoQqgPDsFpr4KdRo+VAS1brUV4gtpEEovKmLjAcVPDb7 O2GiOzzwLdnHYmV2nVQPGawPGnP7j6zN+SYg3d1wmiJSSn0uAxezPmTQF2T0w/FvxpZ3 qc9FlWDzc6wv4ohmoM7/RU9ld3Qt5zR2+qe68g0BtgYjgiZD5RS8NElZ3hB4ETh04Erk uQ2oHCqJ2qE+zpil4ph8+8HH+agGB14yU5HxhvEwXwBV/kjLqaeYuOtgQ5y2DuAcYOYl A8XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N/ZspiK4r9TEaoVNgI7Lic8oA3IpgMqPBVL6eqdGsnI=; b=tm6fkmc/mbTz5fmuqyYLpN4qD7C+b6cQ2le5drvCNMLr2Bi/uFGnuQIFJzrua3k6ZR t1Rq/V9zJ13m3k/xk9s6QS/MRp3eKnlduoBvaarkuCU8GTmmYs/3rIvXuk7W4XpShng9 n4w5SXAciGmuudIcJBm8Bdb4A/jwZM9Wf3KzQM0bZSp6hb7OtlEOfgBzhNDFv3anvOXu PntPyl0xUShia0jlfXBuAmQOuAUf6Qq6+vGJCSF+LXH7NYXm/EgGen1NRb80YQpeesSO Gb++W8LIwyb0YHafBzAyfMrubFyXpo6OHpIKFrNS8QGr1lmzkSnh0IL6ntN2ndXJhp8k wjUA== X-Gm-Message-State: AOAM533hIfuHUb53AKXH2wCSJT1Vq/ZBPCpcgzoIC/1yhoYcPTEXzDQ9 34/fzqxIYvf7fMfCGsGpaYjssrn6cquRvNfFfT0MPw== X-Received: by 2002:a6b:e20a:: with SMTP id z10mr13195524ioc.49.1643700863232; Mon, 31 Jan 2022 23:34:23 -0800 (PST) MIME-Version: 1.0 References: <20220126233454.3362047-1-eranian@google.com> <20220126233454.3362047-10-eranian@google.com> In-Reply-To: From: Stephane Eranian Date: Mon, 31 Jan 2022 23:34:12 -0800 Message-ID: Subject: Re: [PATCH v5 09/13] perf/x86/amd: add idle hooks for branch sampling To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, kim.phillips@amd.com, acme@redhat.com, jolsa@redhat.com, songliubraving@fb.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 27, 2022 at 5:07 AM Peter Zijlstra wrote: > > On Wed, Jan 26, 2022 at 03:34:50PM -0800, Stephane Eranian wrote: > > +static inline void perf_lopwr_cb(bool mode) > > +{ > > + /* key enabled only when BRS is available */ > > + if (static_branch_unlikely(&perf_lopwr_needed)) > > + perf_amd_brs_lopwr_cb(mode); > > +} > > static_call() might be better at this point.. Ok, I will fix this in v6. Thanks.