Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f0f5db0e-dec9-7291-3a6f-645a8b3df90a@nvidia.com>
Date:   Tue, 1 Feb 2022 12:38:15 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [PATCH] Revert mm/gup: small refactoring: simplify
 try_grab_page()
Content-Language: en-US
To:     Will McVicker <willmcvicker@google.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>, linux-mm@kvack.org,
        Christoph Hellwig <hch@lst.de>,
        Minchan Kim <minchan@google.com>,
        Matthew Wilcox <willy@infradead.org>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        stable <stable@vger.kernel.org>
References: <20220201092927.242254-1-jhubbard@nvidia.com>
 <CABYd82biLQ7x1zD0MibXMrMHD9Y-cejitbNo=M2=tPNfUMTePA@mail.gmail.com>
 <CABYd82Y3rFUpCpoudxuYHL6YfuXM19hO1g1FWFCQpSZWMo9p8w@mail.gmail.com>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <CABYd82Y3rFUpCpoudxuYHL6YfuXM19hO1g1FWFCQpSZWMo9p8w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUVBWTR0QXRIVkROVndMeEUwbCtaN0xWRHBQbXc5aVRBZE82NXUvWXhNZGVK?=
 =?utf-8?B?VUJoUEpmZ0hBYi9UeXpXUXBpWlBFdG5yMTNFeXFBbHFTNHdkQjQ0R21ST0o2?=
 =?utf-8?B?UlZDc25zK0xjYzJsRUlraXJGemFiMmNjWVZ6SlJGVld3SmNuY2ZNTkFrMVVJ?=
 =?utf-8?B?NXRTWUJOZk9lMmlEN2tzTytFczRrdDBQK3gyUkNQQW5IK1hIWHlHUUtZdXl1?=
 =?utf-8?B?b3R6N3kwODR4SmxEeHo4SFhFaWJPZ3oxV0ZKNzlaOUhQM3dLZzM2SGl6eDBK?=
 =?utf-8?B?b1RORWR3S0ZjWXp2YVZGakV5VTVRMm5OSzVpd3lnTXhKWmRDdWt2ZVNpdVhq?=
 =?utf-8?B?L0VRS2g0N3d2b1BlUEV1SVoybWRHalUrNGhLdGVLWEtnN3ZMZHJXU05sQ1RW?=
 =?utf-8?B?MGdsclJHUENBaVd4dDBMZWQzemVHRUtHVGc4dEQyc3UvWExycjU2REhidUY4?=
 =?utf-8?B?TnBiZ1JEdE1XOGJTVUFKM0NZTnVCeWE3UWdQdnJNMmdLRU1peDJVc3Fya2pY?=
 =?utf-8?B?Sm9iSTA1SnMzKytLL0I5WEJZNUlLMFlhQkhSODE2aU9KQW5ISE9LUUl2cEl4?=
 =?utf-8?B?eDg0WkV0SjdKM0hwZjBlaENvSEloeFBHdnI2dkJleUJLeTJLUG5CSmpncEl5?=
 =?utf-8?B?eWJsK0hsT1pZYjFtcEFYVENYUUZOSkFqNldsbWFHT0VHZENKVWZGc3NYdVVp?=
 =?utf-8?B?cFVlTVNCVHYwdlpDRDlLWFY5L2llSlZES2N5ckZDYWNkQXZCL1RCVEhuOUt5?=
 =?utf-8?B?RXpyNm1UcXZ1R1dkc01KdFFFaUlMZWtWUkFXQU8vekE0MC9jVVNDN2JuYkta?=
 =?utf-8?B?UTBYbjhUS0JDQW1BWnhDcS9uMnovL3dBT1Y3L0xLdUtxRGVMNWFzbmYzVC9T?=
 =?utf-8?B?R0ZyOEY2dnBjTUFmOWlLbHJoZXRDOEFjekFxN21oVmF5Q0h4bGVqVTUzWGlM?=
 =?utf-8?B?NUFmS25RMkJDbCtaRlpWTEx0aCtrWGlJNVAyeFVoeDVSSEJUZG83ZXBWYzFz?=
 =?utf-8?B?dzhJNW5yT2xOUFhDU0xuV2xkVDdHS29pN3lmOHZSQkp6aFRGVFEvaUx3dzA1?=
 =?utf-8?B?MUpxcFQwc3hWY0pTUDg2U3BKZEZPNWZCeXpGMm1vM0JPZ1o4Ry9ZWm84cEZp?=
 =?utf-8?B?eENHbVlaSDZXU0k5ZE5RQU8yTkJYVmdVcGtoRTh6N3N6dVB1TEg4Zk1Qa2Zt?=
 =?utf-8?B?OHk2ekxKcG8xK2R0UXpDMHdMam5lWktQQ0l5RlhNNlpXS1VTaHBoaUVOSkJ1?=
 =?utf-8?B?VUoxK1Z2d1ZhdTJSSWxKdzdESS9JZnZYYnZvZWJPRDNFMGhpMlRRNWhkTnJM?=
 =?utf-8?B?NUV5TS9FeVdJMGJTVVpocTZSRi9LQ242YnpWZGpKK3RqUEswdUdObGlHWHVD?=
 =?utf-8?B?NTNtMmt0akdoT2ZvMlVSZmVnZlhCaVVGOTVVRXg2ejJrWVR1c3V1bE96cVZq?=
 =?utf-8?B?YkpxVUJYY05FcmxnVEw3T00rKyt5TWxXL2RORHdwcTJQVVlpQ2M5MmQ2d3Jw?=
 =?utf-8?B?cUNNcERBdkJrRDU1bzh1aU1aSG5EU1U4d0dzQzFZYThtcW1YcTFURFA0UTFI?=
 =?utf-8?B?d0JPUlVKdG9wZ2JnZm5ZZkY2bVU5Z1VVRitHTVZORzRwN2o3T0NYOHFtN2NO?=
 =?utf-8?B?Y1Y5OTZnZ1ZWVTFWV0xWSy9FRFMyRlZSSEJZVEZLQ1Bielo1U2NlQ2IxTS9Q?=
 =?utf-8?B?K0czMDJleHNDcmR2MTZsWnJTU0RHOXFUVkVjemo4TktHNG9MZG5tbjBGR0h4?=
 =?utf-8?B?dy9tQkpFZG9TNzJENk5yNlZkc2FZeHFpVGJxTjZuZmlXSUlkWGd5OENVbFkz?=
 =?utf-8?B?M1p0SU9LS0VuUEpSOFIzQUZWaVQyRjlYcEllbjhlVFVzaklvT2xBb1IxdHI2?=
 =?utf-8?B?UEpsQ2gyU1VFaUVCMi80aVZtRm9BRjVjSU81TnNQekR1QXE5NGNNVnBOSWJj?=
 =?utf-8?B?RkVzUXRKY0RwZjlIUXYyYnBLVm12QVJNRnA4QUg0a21WVjdscVpFdjRZRWd2?=
 =?utf-8?B?eTJQTE00cmJ0Z1l4MTRYZmdVWXMvVVI2K3lGdDZteEVOQmc3MzRWUitUb2kr?=
 =?utf-8?B?SXZlejJDZGkya0dWMFExSUlEVHg5WmcvNW1jUURDVndYTkpvQnZMNkF4dXlk?=
 =?utf-8?B?VUlvWGZudWtRc0dpaGtRUjJvcDZnMDc5THBSWnoyZzBNSWZpMFUxbnRPK1NN?=
 =?utf-8?Q?GRr4ddLODxqrQbKpTeIMZBI=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26994833-0b9d-4736-715d-08d9e5c2c733
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 20:38:18.0588
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k+Mp44XUHk6Aq9YxY4Xy/HUuty9rE7zwMVPdV0a6u86fSRCbLydJDXB9YffVL/CjlER6M9W1CRULENg6ldCrDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5403
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/1/22 10:32, Will McVicker wrote:
...
>> Thanks John! I verified this works on the Pixel 6 with the 5.15 kernel
>> for my camera use-case. Free free to include:
>>
>> Tested-by: Will McVicker <willmcvicker@google.com>
>>
>> Thanks,
>> Will
> 
> And just so we don't miss this, I'd also like to request this be
> pulled into the 5.15 stable branch please.
> 
> Cc: stable@vger.kernel.org # 5.15
> 
> Thanks,
> Will
> 

Yes. Let's see if any feedback shows up about the approach, otherwise
I'll post a v2 in a day or so, that adds your tested-by, as well as the
Cc: stable.


thanks,
-- 
John Hubbard
NVIDIA