Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Uladzislau Rezki <urezki@gmail.com>
Date:   Tue, 1 Feb 2022 09:30:18 +0100
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] mm/vmalloc.c: Fix "unused function" warning
Message-ID: <YfjvmuzHtslp/Jao@pc638.lan>
References: <20220129034652.75359-1-jiapeng.chong@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220129034652.75359-1-jiapeng.chong@linux.alibaba.com>
Precedence: bulk

> compute_subtree_max_size() is unused, when building with
> DEBUG_AUGMENT_PROPAGATE_CHECK=y.
> 
Nit: vice versa? It is only used when DEBUG_AUGMENT_PROPAGATE_CHECK=y

> mm/vmalloc.c:785:1: warning: unused function 'compute_subtree_max_size'
> [-Wunused-function].
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  mm/vmalloc.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 028ce2b9bbf9..42d37b4bd351 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -778,17 +778,6 @@ get_subtree_max_size(struct rb_node *node)
>  	return va ? va->subtree_max_size : 0;
>  }
>  
> -/*
> - * Gets called when remove the node and rotate.
> - */
> -static __always_inline unsigned long
> -compute_subtree_max_size(struct vmap_area *va)
> -{
> -	return max3(va_size(va),
> -		get_subtree_max_size(va->rb_node.rb_left),
> -		get_subtree_max_size(va->rb_node.rb_right));
> -}
> -
>  RB_DECLARE_CALLBACKS_MAX(static, free_vmap_area_rb_augment_cb,
>  	struct vmap_area, rb_node, unsigned long, subtree_max_size, va_size)
>  
> @@ -978,6 +967,17 @@ unlink_va(struct vmap_area *va, struct rb_root *root)
>  }
>  
>  #if DEBUG_AUGMENT_PROPAGATE_CHECK
> +/*
> + * Gets called when remove the node and rotate.
> + */
> +static __always_inline unsigned long
> +compute_subtree_max_size(struct vmap_area *va)
> +{
> +	return max3(va_size(va),
> +		get_subtree_max_size(va->rb_node.rb_left),
> +		get_subtree_max_size(va->rb_node.rb_right));
> +}
> +
>  static void
>  augment_tree_propagate_check(void)
>  {
> -- 
> 2.20.1.7.g153144c
> 
Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>

--
Vlad Rezki