Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Feb 2022 14:25:10 -0800 (PST)
From:   "Kenneth R. Crudup" <kenny@panix.com>
Reply-To: "Kenneth R. Crudup" <kenny@panix.com>
To:     Vidya Sagar <vidyas@nvidia.com>
cc:     bhelgaas@google.com, lorenzo.pieralisi@arm.com,
        hkallweit1@gmail.com, wangxiongfeng2@huawei.com,
        mika.westerberg@linux.intel.com, kai.heng.feng@canonical.com,
        chris.packham@alliedtelesis.co.nz, yangyicong@hisilicon.com,
        treding@nvidia.com, jonathanh@nvidia.com, abhsahu@nvidia.com,
        sagupta@nvidia.com, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org, kthota@nvidia.com,
        mmaddireddy@nvidia.com, sagar.tv@gmail.com,
        "Kenneth R. Crudup" <kenny@panix.com>
Subject: Re: [PATCH V1] PCI/ASPM: Save/restore L1SS Capability for
 suspend/resume
In-Reply-To: <2ab59f0d-3ae7-ca5e-6bfc-12bed18813b2@nvidia.com>
Message-ID: <38a02915-906f-c53-7e13-6c8710315e7@panix.com>
References: <20220201123536.12962-1-vidyas@nvidia.com> <8aa96f79-402-4897-424f-64a2c6893de8@panix.com> <2ab59f0d-3ae7-ca5e-6bfc-12bed18813b2@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk


On Wed, 2 Feb 2022, Vidya Sagar wrote:

> BTW, I see that the ASPM L1SS capability is supported by only two endpoints
> viz. KIOXIA's NVMe drive and Realtek's Card reader. None of the root ports
> seem to have the support. So, I'm wondering how was it even getting enabled in
> the first place earlier?

> (OR)

> was it the case that L1SS sub-states were never enabled earlier also and the
> issue was occurring without having ASPM L1SS enabled? (but with only L0s and
> L1 enabled??)

I'm not proficient enough in PCIe to be able to be sure of the answers to those-
what can/could I do to determine this?

> Also, I see that from 'before' and 'after' logs that for both NVMe and Card
> reader and their corresponding root ports, none of the ASPM states are enabled
> (not even L0s or L1).
> Did you set the policy to 'powersupersave' before hibernating the system?

Yeah:

CONFIG_PCIEASPM_POWER_SUPERSAVE=y

My laptop loses ~1.5%/hr in S3; I was trying anything I could to reduce that,
if possible.

	-Kenny

-- 
Kenneth R. Crudup / Sr. SW Engineer, Scott County Consulting, Orange County CA