Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH v5 47/70] acct: Use VMA iterator instead of linked list
Thread-Topic: [PATCH v5 47/70] acct: Use VMA iterator instead of linked list
Thread-Index: AQHYF95+F5CDCUbjJESPHkKMRZ0nDg==
Date:   Wed, 2 Feb 2022 02:42:17 +0000
Message-ID: <20220202024137.2516438-48-Liam.Howlett@oracle.com>
References: <20220202024137.2516438-1-Liam.Howlett@oracle.com>
In-Reply-To: <20220202024137.2516438-1-Liam.Howlett@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?0G/dox8QMC6a+ynytfDn50IY8UaYRmvxRmOShFQ4sfr4bTSjpwCj+Le+WV?=
 =?iso-8859-1?Q?3UcFdx007oIpSiYNgo1yAYXW8nSuDV+BTJGu7CQNx2SE3FhzA03xAzTQn4?=
 =?iso-8859-1?Q?oyotKrRWW6num5jJTONNYLpNihTRb+KsSiavFKeqGOM7LzBUmty82UTwkn?=
 =?iso-8859-1?Q?9IkS5diOvJ9TBnJoPEYmaWBrXKenj0Vmua2iM4uuxU6CYReKrWbPUJVcF9?=
 =?iso-8859-1?Q?51xO58P0poU3kBSEaBxXDYxXNCp8TFgTJAHEDPVv7pN1zUGEIdnpB5tV5d?=
 =?iso-8859-1?Q?J3pvQwIh9ln8TP3muRWYCgk0SAW0tlU6OkvCNCUUedB1JDWrzHytJutRxu?=
 =?iso-8859-1?Q?u38NlPXt14d52bTeOV4tiGfdS9YrMuYl3qqteOn0srzwPE7nQ42N8CVfUC?=
 =?iso-8859-1?Q?Hzvy+gbel6+isWLInOcDyD5UID8sB4BR0xjqz1Gb3l/JqKQT2x3T7fUqay?=
 =?iso-8859-1?Q?OkGeY7rFw76cITQIK5dfMTWgK4HG2prmNfpcZl/qukJRftJGc01vClJfvz?=
 =?iso-8859-1?Q?IQKrt3LDA2f6yrZ0f0rqLZSOu2BnnSptgitPUQd/l1bin+d8nDzzuhrDSS?=
 =?iso-8859-1?Q?N3yMT52K5GQJ/2NWHw6de9LMz+uvzQi6J8m5JVj+UhE721BQQIlehaxFCz?=
 =?iso-8859-1?Q?ikKts9AufG0fv3lbkCXJvYlzn5ZFoTQ9Bavwy5IBAgxgfBqoHBup5c2r65?=
 =?iso-8859-1?Q?p0Xtnef8KLu8p8P6aiTj+YZtziwFNX75uMp70vB1H6xPDuWEgfHad0Geho?=
 =?iso-8859-1?Q?uXtHTdSeAtUaWveMZvzoDluxFDWLhVldMEup/oPVdFcQlkRoQIE0OBctpI?=
 =?iso-8859-1?Q?ysst7I9ZxYYukcNRA/4mvACeZuFCa3+5w6FH4DRw7W1mnjTw5rVsPq47nF?=
 =?iso-8859-1?Q?4REorqq7QOSscjw466l0K09HWiOW8GHdJjzHydeJ890WBGViRpaZuke06v?=
 =?iso-8859-1?Q?sni37fNN/g/QRQZUMwgrE1gHw7u5Q4Ut0kjMLwmuAXL9cWSoovimlXqxmE?=
 =?iso-8859-1?Q?Ru2y0Eh26BOTC3ObxVOyRQxCj8dKEgGUHPUouqeqM35yBsO1DV80qlDYu6?=
 =?iso-8859-1?Q?57zIz8FFJx1MR1eGlrBcFsXvN0kXW6ZHpsDhMcEJs9oiUZSmP+8s+KuFPA?=
 =?iso-8859-1?Q?K8x352fadyJYABsJPNfwGfbtXsywoORcYzOPhf8oTEhyeQfB2SVXv+r4Rz?=
 =?iso-8859-1?Q?VR9UJS6hqaf2huEdU3SFqylRQxVECcgM4fjfnm9hQ+hXKTOUlbtPTy97Tq?=
 =?iso-8859-1?Q?tom3GulJc5LUOy3hsuS/q9PuzN6pP2lwjO4vgoC1rxe6EYpHh0/9QMGYrA?=
 =?iso-8859-1?Q?HIdI0DnP1zbpEJ5tLpjZKbnLQqGcEt6RO9YKOrNOk2Klj5V/Po6rf2/m5i?=
 =?iso-8859-1?Q?1yQTMeURPbwrscusqkyJdWHVlsiyoR/ACF5SAc08sbkqg8t1Eu2f8CMbZJ?=
 =?iso-8859-1?Q?BQI9bTKx+ciXbji3fIUC+GSn+3CgPWKKbk6Y9iIeXm0nELI/2WnHmocDyF?=
 =?iso-8859-1?Q?nuNpbw8I1tG2X8SxAyphNSM5ujM8xpGEGpslFrq1cAF43ilJ8ySRZt5H8S?=
 =?iso-8859-1?Q?Es/AmMCiSne+eOZyxs6lVyCVSWSfsKu6fciECdmkPGM7Km3ucQLqCUF3Cd?=
 =?iso-8859-1?Q?4lE/lJLrSn8rYH9H+9/i0+Vtw2gUkKciWMA+e1N16tf9n5M+aw9C6gTeLW?=
 =?iso-8859-1?Q?LHido5JBMrWkmbxf7Bg=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b0a89e29-ba06-4daa-7cfe-08d9e5f5b612
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 02:42:17.8604
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Tp+/f/jdVchK9irPhE+TqbKVEgfG/cKvGhWFy+OdZWay8Mui5OeKrRPeuuczqtSZzNyPqhjG1ve26fPBHqJ40A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4801
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10245 signatures=673430
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 spamscore=0
 bulkscore=0 adultscore=0 mlxlogscore=999 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202020010
X-Proofpoint-ORIG-GUID: lHrJg2C1QEtdogMNNgiUKJwMJHbYzBbx
X-Proofpoint-GUID: lHrJg2C1QEtdogMNNgiUKJwMJHbYzBbx
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>

The VMA iterator is faster than the linked list.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
---
 kernel/acct.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/kernel/acct.c b/kernel/acct.c
index 3df53cf1dcd5..2e7bf8d41f04 100644
--- a/kernel/acct.c
+++ b/kernel/acct.c
@@ -535,15 +535,14 @@ void acct_collect(long exitcode, int group_dead)
 	unsigned long vsize =3D 0;
=20
 	if (group_dead && current->mm) {
+		struct mm_struct *mm =3D current->mm;
+		VMA_ITERATOR(vmi, mm, 0);
 		struct vm_area_struct *vma;
=20
-		mmap_read_lock(current->mm);
-		vma =3D current->mm->mmap;
-		while (vma) {
+		mmap_read_lock(mm);
+		for_each_vma(vmi, vma)
 			vsize +=3D vma->vm_end - vma->vm_start;
-			vma =3D vma->vm_next;
-		}
-		mmap_read_unlock(current->mm);
+		mmap_read_unlock(mm);
 	}
=20
 	spin_lock_irq(&current->sighand->siglock);
--=20
2.34.1