Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Feb 2022 10:15:31 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Sanjay R Mehta <sanju.mehta@amd.com>,
        Vinod Koul <vkoul@kernel.org>, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH] dmaengine: ptdma: Fix the error handling path in
 pt_core_init()
Message-ID: <20220202071530.GV1951@kadam>
References: <1b2573cf3cd077494531993239f80c08e7feb39e.1643551909.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1b2573cf3cd077494531993239f80c08e7feb39e.1643551909.git.christophe.jaillet@wanadoo.fr>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yaDvrehSiA7MQ4HntuTFsiRrEExzEdnv0SenfYjyMd6Cz0vqCjgwJ7DJlbCJ?=
 =?us-ascii?Q?TsKrHF5+NU7Kt/IZ2wrJfu1vzAlzF3EmMmzn7t2K3GX+Y5MJtbVQXusDz750?=
 =?us-ascii?Q?RBeHnT1XEPGFk70V1Qc/BjREPN7V1LTqHsUKxUxGkZekLeSAbrYLZRqa1vN2?=
 =?us-ascii?Q?Ch6N2TTuINFVaqSaQNcnLPE6rFPS9VMSLnfh98pJbsFLKUP2nAtICmL5z0f0?=
 =?us-ascii?Q?LLfuf2lh+WmI82CvWKXMz1vOKehMdaZEcHXHZDjEiJv/b5RIOtj/OSVyUXIs?=
 =?us-ascii?Q?w4zKkPGnytTVzzcJK6dGXaP5nQ63Hi3S0z+lDdn7oOFv64oW5EJfCQR5f1UX?=
 =?us-ascii?Q?5Acq4mX3MansHqF8yZgTRoe1xa8m9ss8Wz6TlRXh+c1keXu1cpzJBVmHzqs9?=
 =?us-ascii?Q?JAeVyqrgvo1sRNn1qAvTQKmWu42cQyFOX1XHO/0ejV7S/VZWEX0HmEqiiGJ6?=
 =?us-ascii?Q?awlhvY/YZNSBpe1X1gO5guN10uJcrX/7yDizVVW/kes78tYWHOyxLP5x44dL?=
 =?us-ascii?Q?GL7Pbdcu5vZXPBSMBpZSR7aPg7n2fKqtowPvPvids/r3qbC14/beYoRrfyPq?=
 =?us-ascii?Q?0s7YsHRSv0hCgOAckpqXxAMWdjPeB9lQqiKmdZFM9tIstqoJMuKBX7DvcLDI?=
 =?us-ascii?Q?z3Dzj3gHScYI7pzHZHFIRHAn0M5nJsR9LLMpVUAclHskHkURgey0dBSo7N9h?=
 =?us-ascii?Q?Lizt3d0SCxrQ/SdxDhuE3q+IsVspO3UOK4/rixcARBfrl3jXMuv8ftfkXyBa?=
 =?us-ascii?Q?M69Ycos1z0wQXTVF7yvTOVjrP/wxJ2fRNyRjLLDX/Bb6TlpI28/eGUZ8JL2S?=
 =?us-ascii?Q?1cVrGizBzy/xbRk9fDwR7lb47GNLNq3uEKF2jMmNGYDrXnYu6WNdMjban/5p?=
 =?us-ascii?Q?LhgMdFsPxUFT/drxxstGwdv/igiZLim4DIfMSraZHW8SYCIEwpyS/PygjFcP?=
 =?us-ascii?Q?gIKhcysm3TaJQqcNrQ/sDej/lNJ+a0RO7cSTjj6JZEeLNXoznmRfR0xdK3yy?=
 =?us-ascii?Q?H2fKlYkPkMIe5jHHv6DVXLdK6Jw6+rAuuzjkDzSwjQF6IoViJlfQuCgAsB8n?=
 =?us-ascii?Q?cr4YO7vg8Zv2bLTxIWqR9fUwI6IBYEAGz2DAwtSswQOX2z6vFDtBEihIwncu?=
 =?us-ascii?Q?qu3sUQWJKh3qnsO5uuMe7TAGqRfqIKO6r0Dgvzb7LBhOqf5tvL6Hmm5C2o/3?=
 =?us-ascii?Q?G7uDefR4pgtIw+dQwJJUk+Esv7sD5Zk486ozAE92oHfKJ8tr/unKHek+UiFc?=
 =?us-ascii?Q?rc4ib0LTpTOI8ZYwx6ZIz3OwzBhECB/UapHGngF8Gorp44yp/cYmBlMOx1d2?=
 =?us-ascii?Q?Ip8tRZJruFDJs6yt0XqcZnr6FSD1MtXHzkCp9idBVRZiEVf7p5/LfEJAX/z8?=
 =?us-ascii?Q?656ZAGG2r7NurB9gM6F8rmzfmLfLT+ojrST8D/lC02CeiSGHsCVY16uIHf+F?=
 =?us-ascii?Q?Eul0RppE4Iib/BV6emnxkcvqyI4LKkAok24ZnEEZaesEIPvR+bIZXHVYy+Mo?=
 =?us-ascii?Q?hJUjJLKPA0zLasd/zk4nXZ4Y1k+VjrKf5JLJ2xjPoCqKISFmdBDKSPjpD3FC?=
 =?us-ascii?Q?F3/Xjzr2DW5/RnEsZJTbWKRVqz2WvnpSQ+HyjAGldAtcAZ3yfMXaDDfCfyJ0?=
 =?us-ascii?Q?5uKNk9sejD4HfQULz+0/A2hxnU8Rirq3v/1YijccPfUbn6+jNVbwVQd7/f2Q?=
 =?us-ascii?Q?zK1X2E2jJUqeIOWXhYGW/M2Blmo=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c7ff7dc-79a6-49ac-a6f1-08d9e61bd7b4
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 07:15:50.9113
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GaPOMNIoBY5PIYJs+IPF48TpxJH1K7DU/+UoTjCUJJZ1HYj9j8EPCnz/Rk8q4uzQWMoCYalW4hXoXbpygqo7XBzZBbLhGRVJtvQpV8QeZ10=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3274
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10245 signatures=673430
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 spamscore=0
 bulkscore=0 adultscore=0 mlxlogscore=999 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202020035
X-Proofpoint-ORIG-GUID: iZdmXBwAeODmXHJKomkEcQj08AdkOnfI
X-Proofpoint-GUID: iZdmXBwAeODmXHJKomkEcQj08AdkOnfI
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jan 30, 2022 at 03:12:09PM +0100, Christophe JAILLET wrote:
> @@ -230,7 +230,7 @@ int pt_core_init(struct pt_device *pt)
>  	/* Request an irq */
>  	ret = request_irq(pt->pt_irq, pt_core_irq_handler, 0, dev_name(pt->dev), pt);
>  	if (ret)
> -		goto e_pool;
> +		goto e_dma_alloc;

These are ComeFrom label names.  It's an unfortunate style of naming
labels based on the goto location instead of saying what the goto does.

This is one of those cases where the code has moved on, and now the name
no longer points to where it came from or to where it's going.  It just
stands as a Hyperart Thomasson pointing to the past.  It reminds us of
change and decay.  Take time to smell the air in autumn.  Beauty is all
around.

regards,
dan carpenter