Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: HrLsfAkEaxHvnyiqLFs4XJ7ooFesl42N5wt1tF6vC/8NT++lDk5ThMENLLj6tzh3Krhlf6E5QY
 7Iht3eBe/C8hhI08nt2Mxaj8mpF6UJxE1dcBh/ljtEUrNHTDmkoDKBmGqgG8nRL45x7Ud4FdC/
 Ry8S7bRHE0UqrenG0XodLT5DOkeUJdmFR0v0CtVc6Y3TyqUA2g+SIpzQA1EGVmzgfWz3fNcXQs
 4JQyRSPp4KlSA30fWKc97Eg1UGfPeocs+Mzz6sBPBnWsunlbxC6JmwsBBBOlngffzHWmHdIDBa
 OWFVdfXglwmojel2EnKFTTfQ
From:   Steen Hegelund <steen.hegelund@microchip.com>
To:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        <UNGLinuxDriver@microchip.com>, <netdev@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        "Dan Carpenter" <dan.carpenter@oracle.com>
CC:     Steen Hegelund <steen.hegelund@microchip.com>,
        kernel test robot <lkp@intel.com>
Subject: [PATCH net v2] net: sparx5: do not refer to skb after passing it on
Date:   Wed, 2 Feb 2022 09:30:39 +0100
Message-ID: <20220202083039.3774851-1-steen.hegelund@microchip.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk

Do not try to use any SKB fields after the packet has been passed up in the
receive stack.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>
---
 drivers/net/ethernet/microchip/sparx5/sparx5_packet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c b/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c
index dc7e5ea6ec15..148d431fcde4 100644
--- a/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c
+++ b/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c
@@ -145,9 +145,9 @@ static void sparx5_xtr_grp(struct sparx5 *sparx5, u8 grp, bool byte_swap)
 	skb_put(skb, byte_cnt - ETH_FCS_LEN);
 	eth_skb_pad(skb);
 	skb->protocol = eth_type_trans(skb, netdev);
-	netif_rx(skb);
 	netdev->stats.rx_bytes += skb->len;
 	netdev->stats.rx_packets++;
+	netif_rx(skb);
 }

 static int sparx5_inject(struct sparx5 *sparx5,
--
2.35.1