Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Subject: RE: [PATCH RESEND v2] scripts/checkpatch.pl: remove _deferred and
 _deferred_once false warning
Reply-To: maninder1.s@samsung.com
Sender: Maninder Singh <maninder1.s@samsung.com>
From:   Maninder Singh <maninder1.s@samsung.com>
To:     Joe Perches <joe@perches.com>,
        "apw@canonical.com" <apw@canonical.com>,
        "dwaipayanray1@gmail.com" <dwaipayanray1@gmail.com>,
        "lukas.bulwahn@gmail.com" <lukas.bulwahn@gmail.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Vaneet Narang <v.narang@samsung.com>
In-Reply-To: <4ee87d70d5348949787b2d747f90ecffa3119d0b.camel@perches.com>
Message-ID: <20220202095225epcms5p271da4783d86cb7c51d12d80f097aea44@epcms5p2>
Date:   Wed, 02 Feb 2022 15:22:25 +0530
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
References: <4ee87d70d5348949787b2d747f90ecffa3119d0b.camel@perches.com>
        <20220202071405.1872044-1-maninder1.s@samsung.com>
        <CGME20220202071414epcas5p1d329ae4f76c281c1f8f7f07bfb36a919@epcms5p2>
Precedence: bulk

Hi,


>>=C2=A0printk_deferred=C2=A0and=C2=A0printk_deferred_once=C2=A0requires=C2=
=A0LOGLEVEL=C2=A0in=C2=A0argument,=0D=0A>>=C2=A0but=C2=A0checkpatch.pl=C2=
=A0reports=C2=A0it=C2=A0as=C2=A0warning:=0D=0A=C2=A0=0D=0A>=20When=C2=A0did=
=C2=A0that=C2=A0occur?=C2=A0=C2=A0Please=C2=A0reference=C2=A0the=C2=A0speci=
fic=C2=A0commit.=0D=0A>=20When=C2=A0printk_sched=C2=A0(now=C2=A0printk_defe=
rred)=C2=A0was=C2=A0created=C2=A0it=C2=A0did=C2=A0not=0D=0A>=20allow=C2=A0K=
ERN_<LEVEL>.=0D=0A=C2=A0=0D=0A>=20see=C2=A0commit=C2=A03ccf3e830615=C2=A0(=
=22printk/sched:=C2=A0Introduce=C2=A0special=C2=A0printk_sched()=C2=A0for=
=C2=A0those=C2=A0awkward=C2=A0moments=22)=0D=0A=C2=A0=0D=0AI=20think=20with=
=20below=20commit:=0D=0A=0D=0A98e35f5894cf208084688ec0c7bb7b713efc997f=20(p=
rintk:=20git=20rid=20of=20=5Bsched_delayed=5D=20message=20for=20printk_defe=
rred)=0D=0A=0D=0Aearlier=20it=20was=20passing=20hardcoded=20KERN_WARNING=20=
to=20all=20printk_deferred=20messages,=20but=20now=20it=20switched=0D=0Ato=
=20normal=20printk=20behavior.=0D=0A=0D=0A-=20=20=20=20=20=20=20if=20(in_sc=
hed)=0D=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20text_len=20=3D=20sc=
nprintf(text,=20sizeof(textbuf),=0D=0A-=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20KER=
N_WARNING=20=22=5Bsched_delayed=5D=20=22);=0D=0A-=0D=0A-=20=20=20=20=20=20=
=20text_len=20+=3D=20vscnprintf(text=20+=20text_len,=0D=0A-=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
sizeof(textbuf)=20-=20text_len,=20fmt,=20args);=0D=0A+=20=20=20=20=20=20=20=
text_len=20=3D=20vscnprintf(text,=20sizeof(textbuf),=20fmt,=20args);=0D=0A=
=0D=0A=0D=0AI=20did=20not=20search=20that=20earlier,=20because=20we=20were=
=20fixing=20some=20issue=20in=20our=20local=20module=20code=20with=20printk=
_deferred=0D=0Aand=20then=20checkatch=20reported=20the=20issues,=20so=20tho=
ught=20of=20fixing=20it,=20becaue=20without=20level=0D=0Apritk_deferred=20m=
essages=20was=20shifted=20to=20default=20loglevel=20as=20done=20by=20normal=
=20printk.=0D=0A=0D=0ASo=20I=20thought=20it=20was=20designed=20to=20pass=20=
loglevel=20from=20starting=20stage=20and=20checjpatch=20reports=20falsely.=
=0D=0Abut=20seems=20checkpatch=20needs=20to=20fixed=20with=20that=20commit=
=20itself,=20because=20earlier=20it=20was=20not=20required=20to=20pass=20lo=
glevel.=0D=0A=0D=0A=0D=0A>=20There=C2=A0are=C2=A0many=C2=A0existing=C2=A0pr=
intk_deferred=C2=A0uses=C2=A0without=C2=A0KERN_<LEVEL>.=0D=0A=0D=0AEither=
=20that=20needs=20to=20be=20fixed=20after=20that=20commit(98e35f5894cf)=20o=
r=20their=20purpose=20is=20to=0D=0Ause=20KERN_DEFAULT=20log=20level=20i=20t=
hink.=0D=0A=0D=0AThanks,=0D=0AManinder=20Singh=0D=0A=C2=A0=0D=0A=C2=A0