Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Feb 2022 13:21:36 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Stefan =?utf-8?B?TcOkdGpl?= <stefan.maetje@esd.eu>
Cc:     linux-can@vger.kernel.org, Wolfgang Grandegger <wg@grandegger.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/4] can: esd: add support for esd GmbH PCIe/402 CAN
 interface
Message-ID: <20220202122136.nmrza36tfqb6zfh6@pengutronix.de>
References: <20211201220328.3079270-1-stefan.maetje@esd.eu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="fhgf3yvjppidpmlv"
Content-Disposition: inline
In-Reply-To: <20211201220328.3079270-1-stefan.maetje@esd.eu>
Precedence: bulk


--fhgf3yvjppidpmlv
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 01.12.2021 23:03:24, Stefan M=C3=A4tje wrote:
> The purpose of this patch is to introduce a new CAN driver to support
> the esd GmbH 402 family of CAN interface boards. The hardware design
> is based on a CAN controller implemented in a FPGA attached to a
> PCIe link.
>=20
> More information on these boards can be found following the links
> included in the commit message.
>=20
> This patch supports all boards but will operate the CAN-FD capable
> boards only in Classic-CAN mode. The CAN-FD support will be added
> when the initial patch has stabilized.
>=20
> The patch is reuses the previous work of my former colleague:
> Link: https://lore.kernel.org/linux-can/1426592308-23817-1-git-send-email=
-thomas.koerper@esd.eu/
>=20
> *Note*: scripts/checkpatch.pl still emits the following warnings:
>   - esd_402_pci-core.c:270: Possible unnecessary 'out of memory' message
>     This error message is there to tell the user that the DMA allocation
>     failed and not an allocation for normal kernel memory.
>   - esdacc.h:255: The irq_cnt pointer is still declared volatile and
>     this has a reason and is explained in detail in the header
>     referencing the exception noted in volatile-considered-harmful.rst.

I think you can use READ_ONCE() instead of the volatile.

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--fhgf3yvjppidpmlv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmH6d00ACgkQrX5LkNig
010MYwf/anJrAUZWGxxmww7+YQW3Wo3HGQ97tBtPfQxkrhr2y+vRkrksvbqGPFkN
U8XILWMYZs1LIZfGsOVgSpLeQyF0kE8XDMyTshNkQ1edN/1EX+SVMqn366RBIA2+
f3J7FkRYIvru8QoggP/K2bTITR0jI6o/5kNscAXfpWJB+kQElots345EFM0K1Bq5
Ajd1mzlvagLvI+p0I736cfpYkrrO9xVNo76OLC1qj+VqfVavCmKQeGEbK+JadyUJ
uhEWtRfxmBLfI4A2+gA6kZvwhb8GQGlbmswdG7rrlpDmDZZ5neNYEURAMJ71fWWx
2wvTy6p383k+phq+0fHKUrWW2rZAFg==
=l77b
-----END PGP SIGNATURE-----

--fhgf3yvjppidpmlv--