Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jia-Ju Bai <baijiaju1990@gmail.com>
Subject: [BUG] vhost: two possible deadlocks involving locking and waiting
To:     jasowang@redhat.com
Cc:     kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
        netdev@vger.kernel.org, linux-kernel <linux-kernel@vger.kernel.org>
Message-ID: <22f57c53-1a0b-ced9-b36e-1b4de8d55572@gmail.com>
Date:   Tue, 1 Feb 2022 15:27:32 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

Hello,

My static analysis tool reports two possible deadlocks in the vhost 
driver in Linux 5.16:

#BUG 1
vhost_net_set_backend()
   mutex_lock(&n->dev.mutex); --> Line 1511(Lock A)
   vhost_net_ubuf_put_wait_and_free()
     vhost_net_ubuf_put_and_wait()
     wait_event(ubufs->wait ...); --> Line 260 (Wait X)

vhost_net_ioctl()
   mutex_lock(&n->dev.mutex); --> Line 1734 (Lock A)
   vhost_net_flush()
     vhost_net_ubuf_put_and_wait()
       vhost_net_ubuf_put()
         wake_up(&ubufs->wait); --> Line 253 (Wake X)

When vhost_net_set_backend() is executed, "Wait X" is performed by 
holding "Lock A". If vhost_net_ioctl() is executed at this time, "Wake 
X" cannot be performed to wake up "Wait X" in vhost_net_set_backend(), 
because "Lock A" has been already hold by vhost_net_set_backend(), 
causing a possible deadlock.

#BUG2
vhost_net_set_backend()
   mutex_lock(&vq->mutex); --> Line 1522(Lock A)
   vhost_net_ubuf_put_wait_and_free()
     vhost_net_ubuf_put_and_wait()
     wait_event(ubufs->wait ...); --> Line 260 (Wait X)

handle_tx()
   mutex_lock_nested(&vq->mutex, ...); --> Line 966 (Lock A)
   handle_tx_zerocopy()
     vhost_net_ubuf_put()
       wake_up(&ubufs->wait); --> Line 253 (Wake X)

When vhost_net_set_backend() is executed, "Wait X" is performed by 
holding "Lock A". If handle_tx() is executed at this time, "Wake X" 
cannot be performed to wake up "Wait X" in vhost_net_set_backend(), 
because "Lock A" has been already hold by vhost_net_set_backend(), 
causing a possible deadlock.

I am not quite sure whether these possible problems are real and how to 
fix them if they are real.
Any feedback would be appreciated, thanks :)


Best wishes,
Jia-Ju Bai