Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <45c0c1c2-f660-afb4-9631-e73cbbe60465@amd.com>
Date:   Tue, 1 Feb 2022 21:56:55 +0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v3 3/3] KVM: SVM: Extend host physical APIC ID field to
 support more than 8-bit
Content-Language: en-US
To:     Sean Christopherson <seanjc@google.com>
Cc:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org,
        pbonzini@redhat.com, joro@8bytes.org, mlevitsk@redhat.com,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        peterz@infradead.org, hpa@zytor.com, thomas.lendacky@amd.com,
        jon.grimm@amd.com
References: <20211213113110.12143-1-suravee.suthikulpanit@amd.com>
 <20211213113110.12143-4-suravee.suthikulpanit@amd.com>
 <Yc3qt/x1YPYKe4G0@google.com>
From:   "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
In-Reply-To: <Yc3qt/x1YPYKe4G0@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0pIcThCTVAxZy85Y2EzUkI2OElWS0ZXT01XMjR5ZWJtVXlzS05vR3BtaU5V?=
 =?utf-8?B?SDVNTGJFaHkvTEw5aTJ1ZnZVZmRsZE1ZZlZJbEl6YXl5SVVrV2hldUUwWW9P?=
 =?utf-8?B?R3RLMytjQUlwOExTYnNic0ZWUXRXZ1FTNmtueURXU1d3ZHh4SUtnMkJQTkpj?=
 =?utf-8?B?RDFKejdGeEVMb2NpWmJyNElBaDJPa3hQQm9ZWGY1NFlOWHFpOHVNdjFiT2Vx?=
 =?utf-8?B?OUNtTGdQNFJrZm9yL0pZWGZOYjZHVG9HZ3FkY21VOVFZUzRZakh5T0s4ZTVp?=
 =?utf-8?B?cEhmSDVjaGtoS096MnROWHo5WXNrVkY5czlXWHNyT3RjNmVnOXpPempXZXZP?=
 =?utf-8?B?QitVUUtPdWF1b3pGaVFzVFJ0ak9PTWF6a3g2UVBpdkFBam5WVkI4eGxjL2hZ?=
 =?utf-8?B?NWFMb3NrY01MRDBEM1NFVytsZUN4dzNhNUpqN1BRYmJSdUZFTUhaY0NYWmJn?=
 =?utf-8?B?aVhvcDBHNEJMVzVQWUFpMHlWT285MkxpVk14WGRQSXJFeHU0ejJHcHkxQ1Q4?=
 =?utf-8?B?dWdkWEcwMnU1eDIvYUk5N3FiRG1DTnJFZWN2NDZNR3R6d2ZEUDJVZHJkTVJB?=
 =?utf-8?B?S0NkS0ZjdGhGYnVVL3U1T1VMKzdEVW03Z0hvdkxwZFBHd3NXWXZ2WWFMWktw?=
 =?utf-8?B?aEp0VHF1ajRhdzMvUFVHelRYcld1UThRcys5OVE2Z25zMlJhdnA4ck1qQWw4?=
 =?utf-8?B?b245YUVpajRVYkl4c0Q2UksxNlIrK3lnciszd3VVVld4eGpMUmdFZGxKQ05o?=
 =?utf-8?B?dDFKVnFwN0dZT1lYbVMwUzBGeWxQNnZncHRYaS9sdDVQcGJpMDlHTzZvMTNj?=
 =?utf-8?B?aHpWYVlja2NKMzBSdU1kUXoxd3hmblFSRTM5RzUybm1aVkEwdGtPK3J0Q25T?=
 =?utf-8?B?K2hLbkpjQUhvUk9PdVc4dVBkdElXZ3lJcWJxekNmN2xLL1ZOeS9scmR2VXVZ?=
 =?utf-8?B?RU01eEd4Z2l2RndZZ1NlK0pkb1ZCVjlCNk9sWXQrbUFwUDhpalpMZzd6MjVN?=
 =?utf-8?B?TVBmQXlMWWV3SG1KTUtxWTdVc01sSStGRHRhNFFrOGtYR0Z6WnQydVRnZThr?=
 =?utf-8?B?OTBMNjNXcG01WTl3ZlNHUEFmUnpuZ0tkSm1YSnJrcTA5a1AyOXg5dHlWcmV1?=
 =?utf-8?B?c1g5dzZ4U0dSdWJIZVhDOExUaGRUR1JTV2NZc3UrUHRnWVBadE5GSVRqWVVz?=
 =?utf-8?B?TjA0czZOdWMxdkpjTDU2ZlBYbjN4anhyWXpmUTUvSHUyQy9TUk5FN1AzN1lN?=
 =?utf-8?B?OGpKUVlUUFZTWmYyTVdRU0lmbFdhSGdqWEc0SDNsWlJ5NEc4b2FGL2Rsdmxj?=
 =?utf-8?B?Q296Z2FNMFk4emdRSmw3WkNEaWdHYVd4cHlOSWdHdXkxRjdmcW1PYStHZGNX?=
 =?utf-8?B?TTV6eEEyckFMVGxwMzZqdm9yMmtJU3JqSkdmN3Z4Tnlkak5xV0RoeWhTb3Fq?=
 =?utf-8?B?RlFaak1wT3dKeld6UHF4b2VSTDd2S3ZtQVFxYmpreWtGYUVPWkQ4R1VaNGlw?=
 =?utf-8?B?RkJBNzg0K1NvQkY1d0hrVWd0ZEZLU0RIMFlWcHl0TU5iQWNZbGJibHlZL0Q2?=
 =?utf-8?B?emdmRUtZQTB6cHprWk5zOW5UbmkyeVFNNXVhZWdDd1RWajZKSkM5UXRwVHlp?=
 =?utf-8?B?bVNyb0RyR2F3VVlLSDdnQzFBd01zZVJ5U0VBSldwUXJDNlNVTDlyMjRWMkFG?=
 =?utf-8?B?WnNnNVVCVndkN09kUEFCOEZUeGgwWkdRNDJXRExZeGJ1TFUrL0dQcDFPdnJv?=
 =?utf-8?B?WHU0ZVd0NkVpd2N0TWtaTGxmMEVYS2YzYk5INjFYbHBWN2d4aGRMU2o4SzFa?=
 =?utf-8?B?RGFjRmJFYlZPRytyVkk5ODJkbC9xVkZVWDF3L0V5UHJaOGJ6eHlHMHpJMjdC?=
 =?utf-8?B?YTVsKzFLVlIzbDgzTzQ2b0hySGhxeW9sS1EyZHhjd0FkR1RlS1ZXSHhxS2lF?=
 =?utf-8?B?SFo2dFJGUEFHZmlmV0VhLzgrLy9UVEM2WFFrYjd1MFR6bXJFM3ZKVzhjdENa?=
 =?utf-8?B?WFllcTczd3N5SGwzaXpzc0dsVHN0SEhzZnU3dmIzMGJMcEdUUXpSZUZ2cktl?=
 =?utf-8?B?Q2kxME9nbXJVbzcrQ3BpbUVCMXJRZmE5aFBvYjhjK3NaaW5LcFB0Ty9rMjFj?=
 =?utf-8?B?azc4WW1aTm5ONjNDa2l1SlNKQm56NDU2OW1USU5HSkZVU0NOd2lvdGNTME1G?=
 =?utf-8?Q?Oboy6HR0HvC4TJzC9VL15Q8=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 983af616-ad3d-4b92-ab6c-08d9e5931e4d
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 14:57:08.5369
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0NHwzt/5++tnh9nWpce7FKEBVPEQyLAZGKNjNICWJLCSVMmreqivtBetCKAv1DYj1G8+ta3ryb+pm839A3nXjA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5476
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Sean,

On 12/31/2021 12:21 AM, Sean Christopherson wrote:
> On Mon, Dec 13, 2021, Suravee Suthikulpanit wrote:
>> The AVIC physical APIC ID table entry contains the host physical
>> APIC ID field, which the hardware uses to keep track of where each
>> vCPU is running. Originally, the field is an 8-bit value, which can
>> only support physical APIC ID up to 255.
>>
>> To support system with larger APIC ID, the AVIC hardware extends
>> this field to support up to the largest possible physical APIC ID
>> available on the system.
>>
>> Therefore, replace the hard-coded mask value with the value
>> calculated from the maximum possible physical APIC ID in the system.
> 
> ...
> 
>> +static void avic_init_host_physical_apicid_mask(void)
>> +{
>> +	if (!x2apic_mode) {
>> +		/* If host is in xAPIC mode, default to only 8-bit mask. */
>> +		avic_host_physical_id_mask = 0xffULL;
> 
> Use GENMASK(7:0) instead of open coding the equivalent.  Oh, and
> avic_host_physical_id_mask doesn't need to be a u64, it's hard capped at 12 bits
> and so can be a simple int.
> 

Actually, shouldn't it be u16 since the value returned from kvm_cpu_get_apicid()
would typically be 16-bit value (despite it has int as a return type).

Regards,
Suravee