Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Feb 2022 18:27:06 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Stefan =?utf-8?B?TcOkdGpl?= <stefan.maetje@esd.eu>
Cc:     linux-can@vger.kernel.org, Wolfgang Grandegger <wg@grandegger.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/4] can: esd: add support for esd GmbH PCIe/402 CAN
 interface
Message-ID: <20220201172706.dprwxzx3qbsmpuwm@pengutronix.de>
References: <20211201220328.3079270-1-stefan.maetje@esd.eu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ye7jseyqjijendkb"
Content-Disposition: inline
In-Reply-To: <20211201220328.3079270-1-stefan.maetje@esd.eu>
Precedence: bulk


--ye7jseyqjijendkb
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 01.12.2021 23:03:24, Stefan M=C3=A4tje wrote:
> The purpose of this patch is to introduce a new CAN driver to support
> the esd GmbH 402 family of CAN interface boards. The hardware design
> is based on a CAN controller implemented in a FPGA attached to a
> PCIe link.
>=20
> More information on these boards can be found following the links
> included in the commit message.
>=20
> This patch supports all boards but will operate the CAN-FD capable
> boards only in Classic-CAN mode. The CAN-FD support will be added
> when the initial patch has stabilized.
>=20
> The patch is reuses the previous work of my former colleague:
> Link: https://lore.kernel.org/linux-can/1426592308-23817-1-git-send-email=
-thomas.koerper@esd.eu/
>=20
> *Note*: scripts/checkpatch.pl still emits the following warnings:
>   - esd_402_pci-core.c:270: Possible unnecessary 'out of memory' message
>     This error message is there to tell the user that the DMA allocation
>     failed and not an allocation for normal kernel memory.
>   - esdacc.h:255: The irq_cnt pointer is still declared volatile and
>     this has a reason and is explained in detail in the header
>     referencing the exception noted in volatile-considered-harmful.rst.
>=20
> The patch is based on the linux-can-next testing branch.
>=20
> Changes in v6:
>   - Fixed the statistic handling of RX overrun errors and increase=20
>     net_device_stats::rx_errors instead of net_device_stats::rx_dropped.
>   - Added a patch to not increase rx statistics when generating a CAN
>     rx error message frame as suggested on the linux-can list.
>   - Added a patch to not not increase rx_bytes statistics for RTR frames
>     as suggested on the linux-can list.
>=20
>     The last two patches change the statistics handling from the previous
>     style used in other drivers to the newly suggested one.

Please squash the last 2 patches into patch 2.

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--ye7jseyqjijendkb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmH5bWgACgkQrX5LkNig
010S8wgAovHOINwKd4/UH0T42MLFNZrrQYUFWaQIlnnRAbje5V9tGlqrtQmF8IA7
ucwgawlbC0063+XhOEnKrQqpMXaf1vBycauzWjEggXgYOF2Urzq2Smt67m6AwEVT
OT9004cLMMbR6d2oUrdNw4XOQVWsPlDzhqu+YA7W2O3YUJuXrCImSH7EA5TIfIzW
r/VfJVhT54fzsvA8JycDVYPkkB6dg80lEcrsKKLKyfuswhndJgrW49xA2R0/AhS7
1Om1QLkYSq0wJJ6+gfbVnQqOi1IJSUvkAuveAbsWykNhtSVuiwNsn5X8/EhAVNYk
FdLrhCfdI8rwIWBgEYPjDfRJL3WJKQ==
=/JQP
-----END PGP SIGNATURE-----

--ye7jseyqjijendkb--