Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <01aac7b1-88e9-32e3-9b3c-625a2b03bdce@quicinc.com>
Date:   Tue, 1 Feb 2022 12:57:30 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2 1/5] arm64: dts: qcom: sc7280: Fix gmu unit address
Content-Language: en-US
To:     Douglas Anderson <dianders@chromium.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>
CC:     <konrad.dybcio@somainline.org>, <swboyd@chromium.org>,
        <kgodara@codeaurora.org>, <mka@chromium.org>,
        <sibis@codeaurora.org>, <pmaliset@codeaurora.org>,
        <quic_rjendra@quicinc.com>, Andy Gross <agross@kernel.org>,
        Rob Herring <robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20220125224422.544381-1-dianders@chromium.org>
 <20220125144316.v2.1.I19f60014e9be4b9dda4d66b5d56ef3d9600b6e10@changeid>
From:   Akhil P Oommen <quic_akhilpo@quicinc.com>
In-Reply-To: <20220125144316.v2.1.I19f60014e9be4b9dda4d66b5d56ef3d9600b6e10@changeid>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/26/2022 4:14 AM, Douglas Anderson wrote:
> When processing sc7280 device trees, I can see:
>
>    Warning (simple_bus_reg): /soc@0/gmu@3d69000:
>      simple-bus unit address format error, expected "3d6a000"
>
> There's a clear typo in the node name. Fix it.
>
> Fixes: 96c471970b7b ("arm64: dts: qcom: sc7280: Add gpu support")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>
> (no changes since v1)
>
>   arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 937c2e0e93eb..eab7a8505053 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -1790,7 +1790,7 @@ opp-550000000 {
>   			};
>   		};
>   
> -		gmu: gmu@3d69000 {
> +		gmu: gmu@3d6a000 {
>   			compatible="qcom,adreno-gmu-635.0", "qcom,adreno-gmu";
>   			reg = <0 0x03d6a000 0 0x34000>,
>   				<0 0x3de0000 0 0x10000>,

My bad! Thanks for the fix.

fwiw, Reviewed-by: Akhil P Oommen <quic_akhilpo@quicinc.com>

-Akhil.