Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b9fc1081-98b8-64e8-b4a6-fdd5809c1255@amd.com>
Date:   Wed, 2 Feb 2022 13:26:08 +0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v4 1/3] KVM: SVM: Only call vcpu_(un)blocking when AVIC is
 enabled.
Content-Language: en-US
To:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org
Cc:     seanjc@google.com, mlevitsk@redhat.com, pbonzini@redhat.com,
        joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, peterz@infradead.org, hpa@zytor.com,
        jon.grimm@amd.com
References: <20220202041112.273017-1-suravee.suthikulpanit@amd.com>
 <20220202041112.273017-2-suravee.suthikulpanit@amd.com>
From:   "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
In-Reply-To: <20220202041112.273017-2-suravee.suthikulpanit@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SW04NXkzS01ZazVVZ1dxRm9NNnh5bHlyU0FBNXZlRW5kTWhNQlVTeE9Zb1Vp?=
 =?utf-8?B?VkFudFVsNFBDd1l1SkFmaTFLc2kvTnl2eXRGMWs1cGhRRVRBaEFXYzVHSndL?=
 =?utf-8?B?b3Zzc1o1SytmeHZ4M3cvc2VWZnNCU0VBSURTc3psT01CbDhHcG9QQmU5ekVI?=
 =?utf-8?B?OGNHMm5yTXY1YU5XV3A3WEZDUVkwY0dZRzUraEJEaTlUOUVNRjY3QVorNjEw?=
 =?utf-8?B?MXpuTlo2dG5SN2FvV3pMazRwZWdTUDZKWXJFR3plblNQeUdWNXdRSFE1M0NR?=
 =?utf-8?B?Q1M2aWk5MDI5UWtPb2txMENiK1dsUnVYRXRmZGNuSkxIZGtmeEJ5bmZacEpy?=
 =?utf-8?B?QTFua2VDbzlVWWduS0JaMmZOZmIvRnh4VDRGVW9zMHIzRHF3WS9IaXhOd1Y5?=
 =?utf-8?B?QldJN1BiTmtFd1R5OWdHbk5EOUlwZjFYLzFEUW43WTNrSDdvNGM0RXVjY3FW?=
 =?utf-8?B?MCttM0ZoUDl1SDh6QlN1WlY0ZW9qenplV2VVVnpUWHhRdmJ6SndzaGxLK0NF?=
 =?utf-8?B?Y0toSjd6QWZqZnJOUytyeUc0dXFYNkxHN2JYMERFSGQ4dFptLzRDZ0J3cmRM?=
 =?utf-8?B?Q1FONFdWUCtjaFA2T2tGZEdwRmtEZmVpTUdIR0xMZ3JhOWZkVDhpa0JFWVlI?=
 =?utf-8?B?Z0FxN29xREszUFZxNzcyRmM3eVM5ZElyS2JFTHJtWHZIdkw2cFZNcTk3T3hY?=
 =?utf-8?B?ZHd5TmdkRlYyTTFTR2pKVTMzVThjeTNWQ0NiQnp3OEt2N1VvRzQxcmhVcjhJ?=
 =?utf-8?B?OEthODNSbFd4MFZMbjJac1BjaVVzU3pjelFZRGRDTjYrZmRBY0NTajYxcTh3?=
 =?utf-8?B?QjN1VzZ0NU40cC9Lb3oyN0RPc1puN3p3d3k4ZzN4cDBxcUxUdXVUR09yYVRR?=
 =?utf-8?B?dFlveFMzYjB4QTUzTTBBUFhTUjVLeTl2M2VRMU4wTXdYSGhXWVFHZnYzKzhG?=
 =?utf-8?B?TDFGQlpRWC9KRmpKSUNJMStVNWkwbW9ENU1Ka2phZFA1MkY4L3NkeHlyZGVa?=
 =?utf-8?B?R25lUUFQeUNRTHNHblh5b2Z5c0xDY1BNdWlhNmV1MGluMUI0SDFTVUJtNERV?=
 =?utf-8?B?Y1cyZGZCQUNuZUJtSHM3cDREM0NXcEkxWS9JNDR3UC95K2owZlcxSVkvSFFk?=
 =?utf-8?B?NjhXUFBYWkZqUWQzZ1lZWklRaS8xRllDam1pMjJmYkR1OWpkU1pjRkpBTVZN?=
 =?utf-8?B?NVF1MFVrREdaWlZzSWpYM3JKdUF5UFcvR1l4TFhmVmwxNTJzVjV5WUEvdU1U?=
 =?utf-8?B?RXZoNjNWdnV4T25SanNBOHJyeHBxMU0ySTRIb0Z1aHY5a3NFL3pkMWNOYS9U?=
 =?utf-8?B?UDgwSkZWU2R5TDVlNWpWMXp2NGJFOXhEekg2Qkh6T1N6YkpPZ080M0Vyc3BU?=
 =?utf-8?B?RmxqSGV4NFppUjh1U1lmMllHeGVBdXl4NWtSZmd5Y3lOa3ZGZUlLdGpNWW9o?=
 =?utf-8?B?Ry81Q29KVHJEYzZJQTdhb3FtM0RKS21pbUNjNWlJN25wM3JaUlY4SFkwcTNI?=
 =?utf-8?B?L3J5TTVPMFNoK1dmenNuNDd1OC9YT2JuNkVUM3hHblVmZVJvMngwT3c3SUo3?=
 =?utf-8?B?VFZxd1JzbFJadXgxZytsRTFWMGJmMzNvQlRtc0JMajhYcVdlcXlzdUtXNWpv?=
 =?utf-8?B?S0Q3NjJhczhZUkZQMjdWMmZZbVp1M2RMN09JV0l6Q21VenVOdWJMUHhjY1pQ?=
 =?utf-8?B?TzNwTHhTMjNVd2kzcXJzSTlkUHpNZ1Z2TGpWZkN3Smg2aFoybkg0VU5HeS9V?=
 =?utf-8?B?UFBmZjYrN3hNM3BmWFU0d0ZqU3drVVhwQUtGUVUrNElnUSsrVkxBUFF2WXR2?=
 =?utf-8?B?ejJFS2lCSVNLU1pRTlFoNXdsRlRVbG5xbE04TTdDZ2QzQ1lUUW91ZmV2d0xz?=
 =?utf-8?B?V2VSeU5IVUJXeWJyRHZacHIvLzZKeVNySEduQVZCM2lqRUpEdm0xZG9uNU00?=
 =?utf-8?B?YllxVTByODVMbUpGYks1eFVBU2lpZjZ5SnJ1Vk9Sc2RFRjNlVWsyT0o5NDZM?=
 =?utf-8?B?aEt1a3FhZ0pqVjhhRDFacXozYmg2cGp0ZmNCUjJVZC8zcVJoRnJnNGd0aktR?=
 =?utf-8?B?aUVKTVBTaWhiNnorYkdDamFONXpPTkI1ZlM5T3c2dlpaQ2t1YUtYUlZ1dGNu?=
 =?utf-8?B?R3JuamhITy9Sc2liREFNVDBvT0pJS1FIa0NYOWdmV1pyVXZOWkVMUlp5ODRC?=
 =?utf-8?Q?g7fZtGyktv8nrK+jyfRuiVA=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb98694d-c550-408d-1607-08d9e614edf8
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2022 06:26:21.8953
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9vQtn33QHk5cRftKyUVum5PoC0Iw644q0NZtaCjSJx6RhePdWvNSLUDX6SW7uLgkCUv4TYEfkKKEnc7XpafrFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3595
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/2/2022 11:11 AM, Suravee Suthikulpanit wrote:
> The kvm_x86_ops.vcpu_(un)blocking are needed by AVIC only.
> Therefore, set the ops only when AVIC is enabled.
> 
> Also, refactor AVIC hardware setup logic into helper function
> To prepare for upcoming AVIC changes.
> 
> Suggested-by: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> ---
>   arch/x86/kvm/svm/avic.c | 17 +++++++++++++++--
>   arch/x86/kvm/svm/svm.c  | 10 ++--------
>   arch/x86/kvm/svm/svm.h  |  3 +--
>   3 files changed, 18 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c
> index 90364d02f22a..f5c6cab42d74 100644
> --- a/arch/x86/kvm/svm/avic.c
> +++ b/arch/x86/kvm/svm/avic.c
> @@ -1027,7 +1027,7 @@ void avic_vcpu_put(struct kvm_vcpu *vcpu)
>   	WRITE_ONCE(*(svm->avic_physical_id_cache), entry);
>   }
>   
> -void avic_vcpu_blocking(struct kvm_vcpu *vcpu)
> +static void avic_vcpu_blocking(struct kvm_vcpu *vcpu)
>   {
>   	if (!kvm_vcpu_apicv_active(vcpu))
>   		return;
> @@ -1052,7 +1052,7 @@ void avic_vcpu_blocking(struct kvm_vcpu *vcpu)
>   	preempt_enable();
>   }
>   
> -void avic_vcpu_unblocking(struct kvm_vcpu *vcpu)
> +static void avic_vcpu_unblocking(struct kvm_vcpu *vcpu)
>   {
>   	int cpu;
>   
> @@ -1066,3 +1066,16 @@ void avic_vcpu_unblocking(struct kvm_vcpu *vcpu)
>   
>   	put_cpu();
>   }
> +
> +bool avic_hardware_setup(struct kvm_x86_ops *x86_ops)
> +{
> +	if (!npt_enabled || !boot_cpu_has(X86_FEATURE_AVIC))
> +		return false;
> +
> +	x86_ops->vcpu_blocking = avic_vcpu_blocking,
> +	x86_ops->vcpu_unblocking = avic_vcpu_unblocking,

Sorry for confusion, I made a mistake during patch re basing. I'll send out V5.

Suravee