Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Feb 2022 13:25:02 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Curtis Malainey <cujomalainey@google.com>
Cc:     V sujith kumar Reddy <vsujithkumar.reddy@amd.com>,
        ALSA development <alsa-devel@alsa-project.org>,
        Vijendar.Mukunda@amd.com,
        "Hiregoudar, Basavaraj" <Basavaraj.Hiregoudar@amd.com>,
        "Dommati, Sunil-kumar" <Sunil-kumar.Dommati@amd.com>,
        "Pandey, Ajit Kumar" <ajitkumar.pandey@amd.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: amd: acp: Set gpio_spkr_en to None for max speaker
 amplifer in machine driver
Message-ID: <YfqGLtmGBsD2WqtH@sirena.org.uk>
References: <20220131203225.1418648-1-vsujithkumar.reddy@amd.com>
 <YfmCWuD88sT8YxfG@sirena.org.uk>
 <CAOReqxiGW+8BR5VRVHDJuBXxkpB_oQ_4TTNBqm1tuK6shUKLpg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="OYVC+pEbH0ukOWFY"
Content-Disposition: inline
In-Reply-To: <CAOReqxiGW+8BR5VRVHDJuBXxkpB_oQ_4TTNBqm1tuK6shUKLpg@mail.gmail.com>
Precedence: bulk


--OYVC+pEbH0ukOWFY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Feb 01, 2022 at 01:43:38PM -0800, Curtis Malainey wrote:

> Yes that is correct, this is the quick fix that will alleviate the
> gpio contention issue. But I think there is a better solution here.
> According to the sheet I have, the pin for the alc1019 is the same as
> the max98357a and its a shutdown pin for the amp.

OK, that sounds like it should be added to the driver then.

--OYVC+pEbH0ukOWFY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmH6hi0ACgkQJNaLcl1U
h9BM6wf/bydWhYb/gkHNtrvSQ/dJxc7Gf7XsY0PY63Xddav43XnO7jtGQHNgIusX
TGAwX/Nv1vdJO3clfk/cwBTy8mXL77lEBiEY+uauRpbD7N215EDFKBO/oYOoMmGB
8G/TGXoxF6FVirgzW2MhYh8Kg3biGxV2xQ5B+oBKW1QvCYp8cvP026GjuegtWJSa
WbvAo3nan6hAo8M3JoYl0/UiUQT22Lt+c/JBhrqKtTVsWiQ9m96W+5uU1qyt3B4E
5NNXyzFvpRh2k0AonStGPzaefdVSRAArEUNKq0wZO0OzWJJ5xUF1Ru19m8CSvygz
jebBoykr+hBTV4pb9Qlv27O7vxYiag==
=18y7
-----END PGP SIGNATURE-----

--OYVC+pEbH0ukOWFY--