Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Feb 2022 10:04:35 -0800
From:   Benson Leung <bleung@google.com>
To:     linux-kernel@vger.kernel.org,
        Prashant Malani <pmalani@chromium.org>,
        chrome-platform@lists.linux.dev
Cc:     Guenter Roeck <groeck@chromium.org>, Alyssa Ross <hi@alyssa.is>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Tzung-Bi Shih <tzungbi@google.com>, bleung@chromium.org
Subject: Re: [PATCH v2] platform/chrome: cros_ec_typec: Check for EC device
Message-ID: <164373850836.3544522.16027166265181689567.b4-ty@chromium.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="oODRVVzWBO06e+4n"
Content-Disposition: inline
In-Reply-To: <20220126190219.3095419-1-pmalani@chromium.org>
Precedence: bulk


--oODRVVzWBO06e+4n
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, 26 Jan 2022 19:02:20 +0000, Prashant Malani wrote:
> The Type C ACPI device on older Chromebooks is not generated correctly
> (since their EC firmware doesn't support the new commands required). In
> such cases, the crafted ACPI device doesn't have an EC parent, and it is
> therefore not useful (it shouldn't be generated in the first place since
> the EC firmware doesn't support any of the Type C commands).
>=20
> To handle devices which use these older firmware revisions, check for
> the parent EC device handle, and fail the probe if it's not found.

Applied, thanks!

[1/1] platform/chrome: cros_ec_typec: Check for EC device
      commit: ffebd90532728086007038986900426544e3df4e

Best regards,
--=20
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

--oODRVVzWBO06e+4n
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQCtZK6p/AktxXfkOlzbaomhzOwwgUCYfl2MwAKCRBzbaomhzOw
wrOZAP4gPkKd5dYI30xkDbEsgdlYovSEQfOhfSdEitv1g6mM1wD+LH5SF6np/5n3
LjSaW7b5/D+95IWhz557i94GvzlycAI=
=J6JR
-----END PGP SIGNATURE-----

--oODRVVzWBO06e+4n--