Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp1936457pxb; Wed, 2 Feb 2022 16:26:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJxLuX2FKwYDD07myNibkOK0Lsit/8Pdk6EKbXn03DsYGcuDOunxDnc3GeH7WtkhV1g5CL09 X-Received: by 2002:a17:906:cc54:: with SMTP id mm20mr26255074ejb.313.1643847999410; Wed, 02 Feb 2022 16:26:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643847999; cv=none; d=google.com; s=arc-20160816; b=P2NTLiJwlNedA+g9b+WWkDeKvW+P3/SZPvEa1Nf9kaddTiJ8KDFlDRa1dMaXpSOuPw F/wh4g9gjMv8+9hwql6z7Z1r/CTYCzloqOOPKOwChax4DU/tFkU/gfdlEdeiCuI6mMpl oweN/7QYZ267IWcBygcsIBoUgI1APuRe9D+KP49LX/ikEdrcj4YdKx+YLKqrGnjOleVg GUTJ+vCqhChk9Bql+GYmVk5DZb9BR4AbJ1WgUavCgYIEu9IVWHWD9aub5SBmUiKhTVcO oAJr+OqKXvx7vjunKl+bzqV1hBPBn5ryQoSfQUwAHyGch83WTkX/eIE5YvkMu1FAHtrI 0Q4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version:dkim-signature; bh=HEKpAL8zUujJk/o0QQVajUy6UBmtafxTCRO7fO2vf5I=; b=R9RGo7ENTYTvBsQmHlEQkR39pGsqTHmkRSPJJ5A3bBX42Euygbhsa33zfnMGkjOCfe OlmZvm3xj/eGsO68alrAANLnTRzF4MOJMUKJPJfOQ7t4dVJEQD3azPxIeILhEATLRsyp E8yTTtjxaEroaIjyd42ZboHzT++ouTYWEyMNhqr303kXWhe954gaaWmoiis497fMugFw /ycZ4Xk7JFGJvwaY4oP6roolUdN2kkuBfO1NKv+xNZkjxPr/rt83WL5a8q/yrc2B6S78 3dyABLnyNo0x6Z1EdKVoL5q/xwBkWWy/Hb/YtApccEUEa8MfPn1aaT4vyru8+kIP8T0R Mapw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@goldelico.com header.s=strato-dkim-0002 header.b=f4WIYLhe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f7si12169432ejj.794.2022.02.02.16.26.14; Wed, 02 Feb 2022 16:26:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@goldelico.com header.s=strato-dkim-0002 header.b=f4WIYLhe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344154AbiBBMdp (ORCPT + 99 others); Wed, 2 Feb 2022 07:33:45 -0500 Received: from mo4-p04-ob.smtp.rzone.de ([85.215.255.121]:42205 "EHLO mo4-p04-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229706AbiBBMdp (ORCPT ); Wed, 2 Feb 2022 07:33:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1643805197; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:Cc:Date: From:Subject:Sender; bh=HEKpAL8zUujJk/o0QQVajUy6UBmtafxTCRO7fO2vf5I=; b=f4WIYLhe6bdfheCRpkePnaHx3akFvti5kEB/I28gGltL0yaAZEZC014OI1eloEhC4q NiusV5G6RoQAkXtMuufjNYgVT48zBANcSkASrQK9FpvsWXkq1mW/Tqmg8MF5Lhl1NkRX 01A4kEDQxz0GWM3rSSl5RK/jaroLuS4szwwpOrQKInDnzLTN/EskGbmOLvjaQ+6ZhY4e j9k0AiZhSy1BUniEnQY7CA6A6upxatu9gwjeZshKBQjmVUrWOXvHpvyEI1raTR0pOmlc m3cCw5lQVVZVtuE0n9dRlIUtCaYjnq4IiZZi9LuuuUtfz2ff6877pbN6b2XReSBLrYH8 eKow== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj7wpz8NIGH/jrwDCocQ==" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 47.39.0 DYNA|AUTH) with ESMTPSA id L29417y12CXGAH1 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Wed, 2 Feb 2022 13:33:16 +0100 (CET) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: [PATCH v12 2/9] drm/ingenic: Add support for JZ4780 and HDMI output From: "H. Nikolaus Schaller" In-Reply-To: <5ZFO6R.M6Z7S3EBA1YC1@crapouillou.net> Date: Wed, 2 Feb 2022 13:33:15 +0100 Cc: Rob Herring , Mark Rutland , Thomas Bogendoerfer , Geert Uytterhoeven , Kees Cook , "Eric W. Biederman" , Miquel Raynal , David Airlie , Daniel Vetter , Neil Armstrong , Robert Foss , Laurent Pinchart , Jernej Skrabec , Harry Wentland , Sam Ravnborg , Maxime Ripard , Hans Verkuil , Liam Girdwood , Mark Brown , Paul Boddie , Andrzej Hajda , Kieran Bingham , devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org, Jonas Karlman , dri-devel@lists.freedesktop.org, Ezequiel Garcia Content-Transfer-Encoding: quoted-printable Message-Id: <78F51BD7-112A-458D-8FCE-6A67572A182B@goldelico.com> References: <6a7b188769a7ad477bf8cb71e1b9bc086b92388d.1643632014.git.hns@goldelico.com> <1F27171F-DFCA-4707-8F50-D1A343F6D78E@goldelico.com> <37CB6D86-4295-4281-BF3E-3E4B40E74196@goldelico.com> <5ZFO6R.M6Z7S3EBA1YC1@crapouillou.net> To: Paul Cercueil X-Mailer: Apple Mail (2.3445.104.21) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Am 02.02.2022 um 13:28 schrieb Paul Cercueil : >=20 >=20 >=20 > Le mer., f=C3=A9vr. 2 2022 at 13:17:14 +0100, H. Nikolaus Schaller = a =C3=A9crit : >> Hi Paul, >>> Am 02.02.2022 um 13:06 schrieb Paul Cercueil : >>> Hi Nikolaus, >>>>>> @@ -446,6 +454,9 @@ static int = ingenic_drm_plane_atomic_check(struct drm_plane *plane, >>>>>> if (!crtc) >>>>>> return 0; >>>>>> + if (plane =3D=3D &priv->f0) >>>>>> + return -EINVAL; >>>>> This will break JZ4725B -> JZ4770 SoCs, the f0 plane is perfectly = usable there. >>>> Hm. I think it was your request/proposal to add this [1]? >>> Because otherwise with your current patchset the f0 plane does not = work *on JZ4780*. >> Not that I am eager to fix that, but... >> maybe it could be better to fix than having the check and -EINVAL = depend on SoC compatible string >> (or some new flag in soc_info. plane_f0_not_working)? >=20 > Totally agree! A proper fix would be much better. A = "plane_f0_not_working" in the meantime is OK with me. Ok, then I'll prepare a v13 with plane_f0_not_working. >=20 > Note that there are other things not working with your current = implementation, for instance you cannot set the X/Y start position of = the f1 plane, which means it's only really usable for fullscreen = desktop/windows. Is setting x/y possible for the other SoC? >=20 >>> It does work on older SoCs. >>>> What I have forgotten is why the f0 plane should not be usable for = jz4780. >>> We return an error here to prevent userspace from using the f0 plane = until it's effectively working on the JZ4780. >> Well, what would be not working with that plane if user-space would = try to use it? >=20 > =46rom what I remember, it wouldn't show anything on screen, and after = that trying to use the f1 plane wouldn't work either. Ok. That may become a big project to fix. So let's do step 1 first. BR and thanks, NIkolaus