Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: w3rITx7u64h9l7Gs0DxFQOWSJ66YqBkKyhQY9NdiSLQ+eDQH9mznLldinTDscQpRVaMKZQ5igL
 zBy35UN7Fop2njsGuivoFAKtOJdL6OT6B90+XjrblRRx4qmrUJgtjmJy2A1P8LJPl68v7irSKm
 Z6T03Md8PgMqKekNOuu6+VfxV0HDHdX45BbtBAppRjMa2cy7v+tR8bhRMUrybgR0d7BEA4EsbS
 h9XrVV8OpKNL6sy1DdVbysHCxN8IZOAMGo0ilRUIkBMVRfzyR1aQcZ7mRYZFirTsucPX9bSm3F
 tyxUJ4NOyllljvh3JAKMmeKH
IronPort-SDR: ftyKrt3ILxfzb2UOfu3Akc9JANp53aYr75j57tII6FjRZqNVF4NpgVsg14B2Ip7jY7EmsAyyqm
 KPL0PDcAXaec80Bg8kyir9HxQJd6B7TrdhVRzrChMLc7AkO5E+uPg0xW9STqE4CFiJz13W/XFg
 XgOrnRrGFX2TcP/PFkhMoF1rzrlx0fg2Ex2ppRBojKqaGFTmOSvAbMxH9dqvVMB0W/4dqSls5V
 hhMmFdj/rspdXkra/17GgiLCBg/Iffj5S8GtvoLhmMYfpxZbha4irQnqIJt7ZfEIut9iOTPC5p
 iWE=
WDCIronportException: Internal
Message-ID: <4c3df325-dc9f-5eed-5585-7d2e5203b65f@opensource.wdc.com>
Date:   Thu, 3 Feb 2022 08:05:57 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v3] ata: ahci: Skip 200 ms debounce delay for Marvell
 88SE9235
Content-Language: en-US
To:     Paul Menzel <pmenzel@molgen.mpg.de>
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220201071229.6418-1-pmenzel@molgen.mpg.de>
 <3437ffcb-68b5-04e5-acd5-b3857fbf1be7@opensource.wdc.com>
 <1378dd0a-52d2-c998-5713-e6875c601194@molgen.mpg.de>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <1378dd0a-52d2-c998-5713-e6875c601194@molgen.mpg.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 2/2/22 23:29, Paul Menzel wrote:
> Dear Damien,
>=20
>=20
> Am 02.02.22 um 09:14 schrieb Damien Le Moal:
>> On 2/1/22 16:12, Paul Menzel wrote:
>>> The 200 ms delay before debouncing the PHY in `sata_link_resume()` is
>>> not needed for the Marvell 88SE9235.
>>>
>>>      $ lspci -nn -s 0021:0e:00.0
>>>      0021:0e:00.0 SATA controller [0106]: Marvell Technology Group Lt=
d. 88SE9235 PCIe 2.0 x2 4-port SATA 6 Gb/s Controller [1b4b:9235] (rev 11=
)
>>>
>>> So, remove it. Tested on IBM S822LC with current Linux 5.17-rc1:
>>>
>>> Currently, without this patch (with 200 ms delay), device probe for a=
ta1
>>> takes 485 ms:
>>>
>>>      [    3.358158] ata1: SATA max UDMA/133 abar m2048@0x3fe881000000=
 port 0x3fe881000100 irq 39
>>>      [    3.358175] ata2: SATA max UDMA/133 abar m2048@0x3fe881000000=
 port 0x3fe881000180 irq 39
>>>      [    3.358191] ata3: SATA max UDMA/133 abar m2048@0x3fe881000000=
 port 0x3fe881000200 irq 39
>>>      [    3.358207] ata4: SATA max UDMA/133 abar m2048@0x3fe881000000=
 port 0x3fe881000280 irq 39
>>>      [=E2=80=A6]
>>>      [    3.677542] ata3: SATA link down (SStatus 0 SControl 300)
>>>      [    3.677719] ata4: SATA link down (SStatus 0 SControl 300)
>>>      [    3.839242] ata2: SATA link up 6.0 Gbps (SStatus 133 SControl=
 300)
>>>      [    3.839828] ata2.00: ATA-10: ST1000NX0313         00LY266 00L=
Y265IBM, BE33, max UDMA/133
>>>      [    3.840029] ata2.00: 1953525168 sectors, multi 0: LBA48 NCQ (=
depth 32), AA
>>>      [    3.841796] ata2.00: configured for UDMA/133
>>>      [    3.843231] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl=
 300)
>>>      [    3.844083] ata1.00: ATA-10: ST1000NX0313         00LY266 00L=
Y265IBM, BE33, max UDMA/133
>>>      [    3.844313] ata1.00: 1953525168 sectors, multi 0: LBA48 NCQ (=
depth 32), AA
>>>      [    3.846043] ata1.00: configured for UDMA/133
>>>
>>> With this patch (no delay) device probe for ata1 takes 273 ms:
>>>
>>>      [    3.624259] ata1: SATA max UDMA/133 abar m2048@0x3fe881000000=
 port 0x3f e881000100 irq 39
>>>      [    3.624436] ata2: SATA max UDMA/133 abar m2048@0x3fe881000000=
 port 0x3f e881000180 irq 39
>>>      [    3.624452] ata3: SATA max UDMA/133 abar m2048@0x3fe881000000=
 port 0x3f e881000200 irq 39
>>>      [    3.624468] ata4: SATA max UDMA/133 abar m2048@0x3fe881000000=
 port 0x3f e881000280 irq 39
>>>      [=E2=80=A6]
>>>      [    3.731966] ata3: SATA link down (SStatus 0 SControl 300)
>>>      [    3.732069] ata4: SATA link down (SStatus 0 SControl 300)
>>>      [    3.897448] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl=
 300)
>>>      [    3.897678] ata2: SATA link up 6.0 Gbps (SStatus 133 SControl=
 300)
>>>      [    3.898140] ata1.00: ATA-10: ST1000NX0313         00LY266 00L=
Y265IBM, BE33, max UDMA/133
>>>      [    3.898175] ata2.00: ATA-10: ST1000NX0313         00LY266 00L=
Y265IBM, BE33, max UDMA/133
>>>      [    3.898287] ata1.00: 1953525168 sectors, multi 0: LBA48 NCQ (=
depth 32), AA
>>>      [    3.898349] ata2.00: 1953525168 sectors, multi 0: LBA48 NCQ (=
depth 32), AA
>>>      [    3.900070] ata1.00: configured for UDMA/133
>>>      [    3.900166] ata2.00: configured for UDMA/133
>>>
>>> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
>>> ---
>>> v2: address comments for commit message (but forgot v2 tag)
>>> v3: resend with v3 tag in subject line/commit message summary
>>>
>>>   drivers/ata/ahci.c | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
>>> index ab5811ef5a53..edca4e8fd44e 100644
>>> --- a/drivers/ata/ahci.c
>>> +++ b/drivers/ata/ahci.c
>>> @@ -582,6 +582,8 @@ static const struct pci_device_id ahci_pci_tbl[] =
=3D {
>>>   	  .driver_data =3D board_ahci_yes_fbs },
>>>   	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL_EXT, 0x9230),
>>>   	  .driver_data =3D board_ahci_yes_fbs },
>>> +	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL_EXT, 0x9235),
>>> +	  .driver_data =3D board_ahci_no_debounce_delay },
>>>   	{ PCI_DEVICE(PCI_VENDOR_ID_TTI, 0x0642), /* highpoint rocketraid 6=
42L */
>>>   	  .driver_data =3D board_ahci_yes_fbs },
>>>   	{ PCI_DEVICE(PCI_VENDOR_ID_TTI, 0x0645), /* highpoint rocketraid 6=
44L */
>>
>> Applied to for-5.18 with commit title and message changes. The title i=
s now:
>>
>> ata: ahci: Add support for Marvell 88SE9235 adapter
>>
>> Since it is exactly what this patch is doing by adding a PCI ID.
>=20
> Thank you for applying the patch. I saw the summary/title change also=20
> with the other patch. I am sorry, but I totally disagree. Reading that=20
> summary/title in `git log --oneline`, it=E2=80=99s not clear at all, wh=
at the=20
> patch does, and the full description or diff has to be read. =E2=80=9CA=
dd=20
> support=E2=80=9D for me means, that it was unsupported before, which is=
 not true=20
> at all as the defaults were used.

Right... I did not consider the final entry in the ahci_pci_tbl table
which matches against the device against the PCI AHCI storage class.
So right you are. I will restore your original commit title/message.

Thanks for checking.

--=20
Damien Le Moal
Western Digital Research