Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp2155545pxb; Wed, 2 Feb 2022 23:57:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJzimJ9TiqBRKNLKIie3DB6JNfaUfWVMnDqucKTtVynjiccKCtw+it6HzPK2UyKh4y6qWG/j X-Received: by 2002:a63:8b42:: with SMTP id j63mr27534595pge.551.1643875057556; Wed, 02 Feb 2022 23:57:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643875057; cv=none; d=google.com; s=arc-20160816; b=s4YQD6JDqLgL9Qen6arGx4ZL5mhrTBLGOB5thvFPhfmMvpb1ekJX7zn+7+n98jebox qxQUAyFNLiQy2YNMpsLrb76uDk7n9V6y1obObWJif8zfJlxVlT7OO4z0PoavFmsO9InW vlQCkcz9MWpi4SVWcc1/q0lPHSlq0sqAZbWsmwSA9UJRzfuOOWwp3i2N1CMBtwkrjaC4 AwYMYhuLU45wR9Ye/hL8tFtYSIrrp7Ca4tCrQSbzDUHgKscMDzSx6IlFFeI5NuF4tdjE luZkvlasxw7UULRKk6VajGXKfrSsTAsHyka2QdbvdU42uWY8sM6Jg0l/H0AfDZAxDJxr Birw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=fFr35wABT1Ag+M7eB8Ldl2IgucK7WzY17RANVrytmIU=; b=lPf6OgLnbUGEKn8TmZMR71HZO9/Cx8svUe9zrjQxwJW8N0LXxUDVPFXcRVPK+O4Eh8 FIuQgH3zvnwa649G1rIRUAppPK29XLk8FDVQj+gPsqyD/x0SNhDl/t4cBjAoQ1R1Dfvr IxH5caceAU9Jq9OLxSAyS4+5HJ069cbiwRF1zRD4bzSB6s1trOH0BFRiqQlyeKJfvubt y+ujRHF3W0k6CRmPMIycljoDOEH9Ac6LdH1uqr52sCP9EClZo75LT6h5kYM0iv12u/jp jg6/lRWl4sKZcjy14RjXury+/1aMJxL90ArKv6uFY26dE3wQzAs6kGwP7BIyzPd1iCym FFqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=M3VMxzHI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pf1si8745171pjb.132.2022.02.02.23.57.25; Wed, 02 Feb 2022 23:57:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=M3VMxzHI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245056AbiBBIlP (ORCPT + 99 others); Wed, 2 Feb 2022 03:41:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:28276 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245036AbiBBIlM (ORCPT ); Wed, 2 Feb 2022 03:41:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643791271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fFr35wABT1Ag+M7eB8Ldl2IgucK7WzY17RANVrytmIU=; b=M3VMxzHI2Rpi+ouJTSux81Abr/bynxySqIe4ACQUzZnBsNISlpdzXuR8o2EMiNGI+QzwOI f3m7/qwMaamzHt+A2LQd5fyfwDdOv7raYZREy6n/5gIFaspKO29h+j/qOApCUQNAtDWaUY fMDDowSXw5Ucp00VYxNrbl/HIA6otjU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-73-3oBYIt5vNsyzynImwyx0gw-1; Wed, 02 Feb 2022 03:41:08 -0500 X-MC-Unique: 3oBYIt5vNsyzynImwyx0gw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1DA3846861; Wed, 2 Feb 2022 08:41:06 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CC2BE16A5A; Wed, 2 Feb 2022 08:41:05 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 20C131800397; Wed, 2 Feb 2022 09:41:04 +0100 (CET) Date: Wed, 2 Feb 2022 09:41:04 +0100 From: Gerd Hoffmann To: Dov Murik Cc: linux-efi@vger.kernel.org, Borislav Petkov , Ashish Kalra , Brijesh Singh , Tom Lendacky , Ard Biesheuvel , James Morris , "Serge E. Hallyn" , Andi Kleen , Greg KH , Andrew Scull , Dave Hansen , "Dr. David Alan Gilbert" , Lenny Szubowicz , Peter Gonda , James Bottomley , Tobin Feldman-Fitzthum , Jim Cadden , Daniele Buono , linux-coco@lists.linux.dev, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 2/5] efi/libstub: Reserve confidential computing secret area Message-ID: <20220202084104.zkhnclpxigct4tf6@sirius.home.kraxel.org> References: <20220201124413.1093099-1-dovmurik@linux.ibm.com> <20220201124413.1093099-3-dovmurik@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220201124413.1093099-3-dovmurik@linux.ibm.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 01, 2022 at 12:44:10PM +0000, Dov Murik wrote: > Some older firmware declare the confidential computing secret area as > EFI_BOOT_SERVICES_DATA region. Fix this up by treating this memory > region as EFI_RESERVED_TYPE, as it should be. > > If that memory region is already EFI_RESERVED_TYPE then this has no > effect on the E820 map. Hmm, sure we actually want merge this? I suspect by the time this landed in an upstream kernel "older firmware" isn't much of a problem any more. take care, Gerd